News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

Bookmarks

Started by Matthew K., July 16, 2007, 01:07:24 PM

Previous topic - Next topic

Nuks

Whoops. Sorry, didn't know that !

whoey

that's why I offered the fixes, and not the files :D

panicattack

Using 1.1.12 SFW.

Only Administrators are seeing the bookmark button.  Regular members are unable to see them.  Is there a setting that I am missing?

Thanks!

Illori

you need to enable the permission for each group.

Jayne Louise

Quote from: noelksmall on April 05, 2010, 03:29:03 PM
I've downloaded this mod and installed it successfully, i can see the bookmarks at the top of the form, but when i go into a topic, i don't see "add bookmark" button, the package manager said it installed ok, im using 2 RC2

Quote from: noelksmall on April 05, 2010, 04:30:00 PM
I've modified my Display.Template file and added the code for the button as its working, well fingers crossed so far!

Having the same problem here with RC4; there is no Add Bookmark button. Permissions are fine. What do I need to put into the display template for the add bookmark button to appear?

Thanks.
~J:L

Illori

<file name="$themedir/Display.template.php">
<!-- Add a button for making bookmarks, Curve style. Optional. -->
<operation error="ignore">
<search position="before"><![CDATA[
'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'], 'active' => true),]]></search>
<add><![CDATA[
'bookmark' => array('test' => 'can_make_bookmarks', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic'] . ';' . $context['session_var'] . '=' . $context['session_id']),]]></add>
</operation>

Jayne Louise

Many thanks Illori, that seems to be working perfectly now :)
~J:L

sharks

Hi guys

First, i want to say that this is an excellent idea for a mod and i plan to use it as soon as possible.

I uploaded the latest package for my SMF 1.1.11 and SMF 1.1.12 installations, but after clicking on the [Apply Mod] button, i see a blank page for both installations. Did the package get corrupted? Other mods installed fine, so i suppose that this mod was badly packaged?

Illori

Quote from: DarioBros on October 12, 2010, 06:31:49 AM
Quote from: marcberm on July 25, 2010, 10:03:07 PM
So for some reason, when I attempt to install this package automatically through the SMF interface, instead of proceeding to the screen where the file tests are displayed, I get just a blank white screen (refresh doesn't do anything). 

The same thing happens to me.

I resolved this issue modifying the file "package-info.xml" contained in the archive.

In this file, I replaced every istance of
<database type="file">
with
<code>

and
</database>
was replaced by
</code>

sharks

#589
Thanks for the help, Illori. :) Tested and works!

I have attached the fixed package to my reply for all those who like this modification. Please encourage its development! ;)



(admin edit - attachment removed, see explanation below)

Illori

please remove the attachment.

Quote from: Kindred on November 05, 2010, 08:34:22 PM
sorry... standard mod authorship rights do not allow others to modify or distribute other people's mods

sharks

Illorim, what you're saying doesn't make any sense. I've just fixed it so others won't have trouble installing it. I have made no changes other than that. Also, the creator of this mod is offline since November 20, 2010 and like so many other mods, this mod has most probably been abandoned as well, which is becoming clearer now... why nobody else is picking up abandoned mods because of your "fantastic" rule. Ah ha! :D

Illori

it is not allowed to post attachments of mods with any changes done to them without authors permission which we do not have. also 1 month off line is not much time compared to some mod authors.

Kindred

it's not Illori's rule.... it is actually SM's rule.

Mods are owned by the mod author. Unless that author has specified an open license, the mod is not allowed to be distributed by anyone else. In addition, attaching mods in a thread means that they bypass the normal checks and balances (i.e. they are not checked by the cust team, you can not report them as unsafe, etc)

So, as a general rule....  users are not allowed to post their revisions to the mod as an attachment. You can post your changes in code tags in a message, but not as a full-blown install package/attachment.

I've said this in MANY other threads as well.
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

samurai-lupin

Quote from: Kindred on December 24, 2010, 11:41:38 AM
it's not Illori's rule.... it is actually SM's rule.

Mods are owned by the mod author. Unless that author has specified an open license, the mod is not allowed to be distributed by anyone else. In addition, attaching mods in a thread means that they bypass the normal checks and balances (i.e. they are not checked by the cust team, you can not report them as unsafe, etc)

So, as a general rule....  users are not allowed to post their revisions to the mod as an attachment. You can post your changes in code tags in a message, but not as a full-blown install package/attachment.

I've said this in MANY other threads as well.

This is very silly and why I nowadays regret having choosen SMF many years ago ...

I see abandoned and not working mods all over the place and if some great guy wishes to help he gets kicked in the teeth ...

Arantor

QuoteI see abandoned and not working mods all over the place and if some great guy wishes to help he gets kicked in the teeth ...

It's actually the law. Mods written by someone are legally copyrighted to that person and unless they give permission, the works cannot legally be modified or redistributed. Only the instructions to change them (as Kindred says) can.

sharks

Quote from: Arantor on January 07, 2011, 07:46:56 PM
It's actually the law. Mods written by someone are legally copyrighted to that person and unless they give permission, the works cannot legally be modified or redistributed. Only the instructions to change them (as Kindred says) can.

But what if the author of the mod is offline for a long time and might never return, or has been deleted and is now showing as Guest user?

Arantor

Doesn't matter. Under the terms of countries following the Berne Convention, which includes the US where the servers here are located (and thus the team are kind of bound to uphold them!), copyright is assigned at the moment of creation, so the moment code is written it's copyrighted. And unless there is something explicitly granting the right of takeover, such as a licence document, no takeover can be done in any form without the permission of the author.

This is why, for example, SlammedDime recently listed all his mods as under the Mozilla Public Licence, so that if he's not available, someone else can take over and modify/update the mods or branch off and make derived works. The law doesn't grant such rights but the licence applied to the works *does*.

Just because an author is absent doesn't prevent the work being copyrighted, though in some territories there are grounds for transferral in absentia, but unless you have someone who knows the laws in all related areas (original author's country/state, the states where SMF is based, which includes Arizona, Nevada and wherever the servers are, and the subsequent author's country/state) and can give a qualified legal opinion, it's safer just to not do so.

ret

I can uninstall and reinstall v1.0.1 of this mod with no issues, but cannot get this updated version to work. Either:

1. blank screen as per other respondents above, or
2. after making the database => code change, the zip-file refuses to install at all, with "The package you tried to upload either is not a valid package or has become corrupted."

I've edited the file with vim, and I'm pretty confident I haven't broken it by changing line-endings etc.

Jessica.

when I clicked on Apply Mod (using 1.1.12) I get a blank page......
Testing Zone - SMF 2.0.7, default Curve
School & Chat - phpBB3, over 170 mods installed, official live forum

I use the latest version of Chrome

phpBB: Forum = a section; Board = whole site
SMF: Forum = whole site; Board = a section

Advertisement: