News:

SMF 2.1.4 has been released! Take it for a spin! Read more.

Main Menu

Birthday Post v0.12.1 Beta (Now RC2 Compatible!)

Started by Suki, July 31, 2009, 11:49:30 PM

Previous topic - Next topic

MoreBloodWine

Quote from: Suki on January 26, 2013, 07:18:34 PM
Thats not possible unless you manually modified the mod's code. Make sure you are indeed using the latest version as there was a bug where people with no date  been set had b-day post but that was fixed a long time ago before I took it over.

I can't help if you don't provide more details.
I dont have a habbit of installing mods and then changing code. As for more details, other than I installed the mod and made sure the task was set to run because it wasnt after install I got the posts. I've since uninstalled the mod because I dont need to chance this happening every night.
Want a sig like mine for your BTCGuild stats ? Then check this out: Spend-ur-Bits


MoreBloodWine

Ok, o I just hit reinstall the mod... hit run task to see if it would do it again. Well, it didnt, at least not for the users it already goofed on. What it did do though was make a post for rthe newet member to the site who doesn't even have a birthday set. I uspect next time someone signs up and the scheduled task is set to run to chek for birthdays that it will post a post for the new user.
Want a sig like mine for your BTCGuild stats ? Then check this out: Spend-ur-Bits


dave1p

Quote from: MoreBloodWine on January 26, 2013, 01:47:59 AM
Ok, so I jut checked my forum and have birthday posts for every member including myself and not one had a birthday today (yessterday the 25th), whats up with that lol

Mines doing the exact same thing although an uninstall and re-install changed nothing. It posts a birthday greeting for everyone that fulfil the number of posts criteria every time it runs.


scvoyager

I had this mod do the same thing twice. When one member has a birthday it makes a new post for all members. If no members have a birthday then it doesn't post like it's supposed to. No modifications have been made and I did upload the latest version.

MoreBloodWine

Im sorry but I am DONE with thi mod because it happened again and I have all my members complaining !!!
Want a sig like mine for your BTCGuild stats ? Then check this out: Spend-ur-Bits


Suki

Si el mod es tán malo, solo desinstalalo y listo... no pagaste nada por el...

El mod es código libre, cualquiera puede actualizarlo, no solo yo.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

MoreBloodWine

Quote from: Suki on January 29, 2013, 09:12:09 AM
Si el mod es tán malo, solo desinstalalo y listo... no pagaste nada por el...

El mod es código libre, cualquiera puede actualizarlo, no solo yo.

---

If the mod is so bad, just uninstall it and go ... did not pay anything ...

The mod is open source, anyone can update it, not just me.
Maybe so but as the mods author arent you supposed to investigate thee issues ? Sure details help but there' nothing to give other than I installed the mod and got posts for everyone, which happens every time a new member registers before the task runs. So, if I get one new member a day before 7pm EST the task runs and makes a post for everyone. I did not special modifications and installed this out of the box so AFAIK this is a problem with the mod, not me. This theory holds true on two different sites, one of which is a completely brand new install.

Edit: As far ras anyone updating it goes, if anyone knows how to fix the mod with a proper patch would you kindly consider doing so ;-)
Want a sig like mine for your BTCGuild stats ? Then check this out: Spend-ur-Bits


Arantor

QuoteMaybe so but as the mods author arent you supposed to investigate thee issues ?

Maybe so but as the mod's user aren't you supposed to be polite?

Let's take a look at the history of the mod. The original author - JBlaze - doesn't hang around here. The subsequent maintainer - me - doesn't touch mods with a barge pole for SMF because of people who don't understand that I come here in my spare time to help out, not to serve everyone's requests and demands.

If you want to make the 'the mod's author' argument, make it at one of us. It was fine when we wrote it. It's entirely possible your installation is broken because I can't reproduce this on my setup (and I tried)

QuoteEdit: As far ras anyone updating it goes, if anyone knows how to fix the mod with a proper patch would you kindly consider doing so ;-)

I was considering spending some time on it, but given your rudeness to people giving you things for free, not no way.

Suki

I can for sure investigate, what bothers me is the "I'm done with this mod" type of threat... thats not a good way of convincing a voluntary dev to look after an issue...

Far from me wanting to fix it, all you did by complaint is scared me away.

With that said, even if I wanted to give a patch, apparently, the way I do things right now is ****** and doesn't work for a forum software so I might end up ******ing this more than it already is...
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Arantor

QuoteWith that said, even if I wanted to give a patch, apparently, the way I do things right now is ******

The only person saying that is you... there's truly nothing wrong with what I've seen of what you've made, other than the need to keep remaking it to conform to a new design pattern.

MoreBloodWine

#370
Quote from: Arantor on January 29, 2013, 09:40:29 AM
Maybe so but as the mod's user aren't you supposed to be polite?
Yes and for the most part I have been except with maybe the snippyness of my last reply and the I'm done with this mod comment.

Quote from: Arantor on January 29, 2013, 09:40:29 AM
Let's take a look at the history of the mod. The original author - JBlaze - doesn't hang around here. The subsequent maintainer - me - doesn't touch mods with a barge pole for SMF because of people who don't understand that I come here in my spare time to help out, not to serve everyone's requests and demands.
If it's one thing I understand it's that everyone here including the SMF team themselves do this in their spare time.

Quote from: Arantor on January 29, 2013, 09:40:29 AM
If you want to make the 'the mod's author' argument, make it at one of us. It was fine when we wrote it. It's entirely possible your installation is broken because I can't reproduce this on my setup (and I tried)
Ok, so I didn't look at the transfer rhistory of this mod or whatever you want to call it. Thats a fault I claim and own, I just looked at the created by on the mod page.

Quote from: Arantor on January 29, 2013, 09:40:29 AM
I was considering spending some time on it, but given your rudeness to people giving you things for free, not no way.
I may come accross like a total ass in some of my replies and for that I apologize but I do not always expect thigns for free. In the past two years I have spent around  thousand bucks here on different people for different things.

All of my frutration, rudeness, assholeishnes or whatever you want to call it is just that... frustration.... maybe I just took all my members accross four sites yelling at me for post flooding out on you guys, I don't know, but either way there's no taking it back since whats been said has been said. All one can do is apologize but depending on the reciving end of it they might just blow it off any way because they don't know how to forgive. Not saying anyone here doesnt know how to forgive, just that sometimes even the most sincerest of apologies doesnt mean a damn thing to some people.

Quote from: Suki on January 29, 2013, 10:00:35 AM
I can for sure investigate, what bothers me is the "I'm done with this mod" type of threat... thats not a good way of convincing a voluntary dev to look after an issue...

Far from me wanting to fix it, all you did by complaint is scared me away.

With that said, even if I wanted to give a patch, apparently, the way I do things right now is ****** and doesn't work for a forum software so I might end up ******ing this more than it already is...
Sometimes something has to be messed up more than it already is to be properly fixed... jut depends on the situation but scaring you away or anyone for that mater was never my intention.

Ass for not duplicating this problem... like I said, one site was a brand new fresh install and the others of various ages and this happened on all of them so I honestly don't know what to say about why it cannot be reproduced but assuming the other two "this is happening to me too" replies are legitimate posts and not trolls then I'm not the only one so there is a clear issue here.

Edit: I would alo add that I am using the DL labeled BirthdayPosts.zip from the mod page and it labels verion number 0.13 Beta in the Package Manager.
Want a sig like mine for your BTCGuild stats ? Then check this out: Spend-ur-Bits


dave1p

#371
I am one of those that replied that I have this issue too.

I moved from phpbb to SMF after about 5 years because of issues I had with phpbb and corrupted installs. Most of the time doing any mods manually as Automod cased all sorts of problem

Very happy with SMF in the main. It adds features not available in phpbb and I like the package management. My site has a number of mods applied in order to get as close to what existed before in phpbb but this one does not work  When it runs it posts a greeting for every member that meets the criteria (min number of posts etc) in the settings.

My forum is at hxxp:nothlondonpride.com/forum [nonactive] and the members database is linked to the wordpress installation at hxxp:northlondonpride.com [nonactive] using the WPSMF - Wordpress to SMF plugin.

SMF is at 2.02 with the following Mods;

httpBL - 2.5.1
Add Twitter Tweet Button to Posts - 1.1
Alternate User Posting - 1.01
Admin Notepad - 2.02
Add Facebook Like to Posts - 1.1
Last Edit Link - 2.0
6 Custom buttons / tabs with Sub Menus (4) - 0.5
Button 1 Menu Extender for 6 custom buttons mod 1.0
Global Headers Footers 2.0
MessagePreviewOnHover 1.8
Stop Spammer 2.3.9
Ohara YouTube Embed 1.0

The default template is set for everyone to use a slightly modified curve template

The default smf email to members on their birthday works ok

In the smf_members table default  dobs (where a user hasn't entered one are all set to  0001-01-01 despite the smf members\forumprofile shown as 0000-00-00 although I am not sure that's the problem as all members including those with a correctly set birthdate, get a happy birthday post every time it is run



That is about all the information I can think of that I can give you  and I would be very grateful if someone could look into this

Suki

What are your settings for the mod? are you using a single topic or new topics for each user? do you have any custom checks like the active one or the minimum post an user must have?
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

MoreBloodWine

Quote from: Suki on January 29, 2013, 04:07:05 PM
What are your settings for the mod? are you using a single topic or new topics for each user? do you have any custom checks like the active one or the minimum post an user must have?
As far as I go, new topic for each member... atached are the settings, same ones used accross all sites.

Then under tasks I hav the mod post thing checked, which again it wasnt after initial install then I have the core email thing ticked as wel lfor birthdays.
Want a sig like mine for your BTCGuild stats ? Then check this out: Spend-ur-Bits


dave1p

new topic for each user (which meant on three occasions I have had to delete up to 300 posts)

Must be active in the past 365 days

No PMs set

Does the same if minimum posts is set or not. if it is set to 0 everyone gets a post - if set to a number only those with post count higher get one


Suki

I dunno why these checks got deleted on the new version:

         AND MONTH(birthdate) = {int:month}
         AND DAYOFMONTH(birthdate) = {int:day}
         AND birthdate > {string:nondate}

I don't remember modifiying anything on the scheduled_birthday_posts() func when I did the update...

Anyway, open yourSources/ScheduledTasks.php file and find:


$result = $smcFunc['db_query']('', '
SELECT id_member, real_name
FROM {db_prefix}members
WHERE bp_lastpost < {int:lastpost}
AND notify_announcements = {int:notify_announcements}' . (!empty($modSettings['bp_lastactive']) ? '
AND last_login > {int:last_login}' : '') . (!empty($modSettings['bp_min_posts']) ? '
AND posts >= {int:posts}' : '') . (!empty($modSettings['bp_minregdays']) ? '
AND date_registered < {int:minreg}' : '') . (empty($modSettings['bp_banned']) ? '
AND is_activated >= 1 AND is_activated <= 10' : '
AND is_activated >= 1'),
array(
'lastpost' => time() - 172800, // more than 2 days ago
'nondate' => '0001-01-01',
'notify_announcements' => 1,
'year' => 1,
'month' => $month,
'day' => $day,
'last_login' => !empty($modSettings['bp_lastactive']) ? time() - ($modSettings['bp_lastactive'] * 86400) : 0,
'posts' => !empty($modSettings['bp_min_posts']) ? $modSettings['bp_min_posts'] : 0,
'minreg' => !empty($modSettings['bp_minregdays']) ? time() - ($modSettings['bp_minregdays'] * 86400) : 0,
)
);


and replace with:


$result = $smcFunc['db_query']('', '
SELECT id_member, real_name
FROM {db_prefix}members
WHERE bp_lastpost < {int:lastpost}
AND MONTH(birthdate) = {int:month}
AND DAYOFMONTH(birthdate) = {int:day}
AND birthdate > {string:nondate}
AND notify_announcements = {int:notify_announcements}' . (!empty($modSettings['bp_lastactive']) ? '
AND last_login > {int:last_login}' : '') . (!empty($modSettings['bp_minregdays']) ? '
AND date_registered < {int:minreg}' : '') . (empty($modSettings['bp_banned']) ? '
AND is_activated >= 1 AND is_activated <= 10' : '
AND is_activated >= 1'),
array(
'lastpost' => time() - 172800, // more than 2 days ago
'nondate' => '0001-01-01',
'notify_announcements' => 1,
'year' => 1,
'month' => $month,
'day' => $day,
'last_login' => !empty($modSettings['bp_lastactive']) ? time() - ($modSettings['bp_lastactive'] * 86400) : 0,
'minreg' => !empty($modSettings['bp_minregdays']) ? time() - ($modSettings['bp_minregdays'] * 86400) : 0,
)
);


That should cover it.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

MoreBloodWine

Just for the sake of argument so I can say that I asked, what do those checks do exactly ?

I will test patch here in a few mins but if you could make a new package as well that would be awesome so others don't have the same issues we did and again, sorry about earlier I sometimes have a tendancy to throw frustration tossed at me on to others.
Want a sig like mine for your BTCGuild stats ? Then check this out: Spend-ur-Bits


Suki

AND MONTH(birthdate) = {int:month}  extracts the month form the birthday field and checks it againts the $month var

AND DAYOFMONTH(birthdate) = {int:day}  The same but for the day
AND birthdate > {string:nondate}  This checks that the birthday field isn't 0001-01-01
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

MoreBloodWine

Quote from: Suki on January 29, 2013, 04:36:54 PM
AND MONTH(birthdate) = {int:month}  extracts the month form the birthday field and checks it againts the $month var

AND DAYOFMONTH(birthdate) = {int:day}  The same but for the day
AND birthdate > {string:nondate}  This checks that the birthday field isn't 0001-01-01
So thats basically what says a birthday doesnt exist or isnt today o don't post ?

Cool...
Want a sig like mine for your BTCGuild stats ? Then check this out: Spend-ur-Bits


dave1p

#379
been testing this patch and it didn't seem to post at all

However - set the bp_lastpost field to 0 and it worked

I assume that the task also checks this and if less than a year does not post a thread.

If so I will need to reset all of these to take into account all the previous failed runs

Time to dust of the rusty SQL

Advertisement: