Snowflakes

jsx · January 06, 2021, 01:10:37 PM

Quote from: Chen Zhen on January 04, 2021, 05:22:32 PM
Prior to the recent changes I have not seen that behavior on desktop/laptop. Also using Simple Portal or EhPortal I never had those problems with any of the light scripts.

Unfortunately, while browsing the forum on the monitor, I see blinking from time to time.

lemur21 · January 09, 2021, 11:29:13 PM

Looks like I'm having a similar issue (running 2.0.17)

I am able to see *some* of the effects; but not all.

I am not able to see these effects:

Snowflake
Flurry
Diverse
Fireworks
Halloween

I *can* see the Snowstorm and all the Xmas lights effects.

Weird :/

Chen Zhen · January 14, 2021, 08:02:50 PM

@jsx:

Try the v1.75-RC2 version from my forum at the link I previously gave you in this thread.
I reworked the buffer hook function quite extensively.

Keep in mind that any JavaScript / (X)HTML errors from other 3rd party mods, custom portal blocks and/or your own file edits may cause this mod's scripts to fail.
This has been tested while also having Tiny Portal installed.
ref. to possible current TP issue/scenario:
https://github.com/Tinyportal/TinyPortal/pull/816/files

jsx · January 17, 2021, 06:59:28 AM

I installed this version v1.75-RC2 and I noticed two flashes on the screen while writing a private message on the forum. It is possible that this is a bug in JavaScript from another modification installed.

Chen Zhen · January 17, 2021, 11:30:48 AM

I can see on your forum page that document.write is invoked approx. 6 times and it appears a JQuery library is being loaded more than once.
Due to one of your mods there may be more problems on the actual post page but I'd have to register to test that out.

- Lex removed a web address on request.

jsx · January 18, 2021, 03:00:44 AM

Quote from: Chen Zhen on January 17, 2021, 11:30:48 AM
Due to one of your mods there may be more problems on the actual post page but I'd have to register to test that out.

I sent you private messages. One of them contains data to log into the account.

Chen Zhen · January 18, 2021, 04:26:22 PM

Quote from: jsx on January 17, 2021, 06:59:28 AM
I installed this version v1.75-RC2 and I noticed two flashes on the screen while writing a private message on the forum. It is possible that this is a bug in JavaScript from another modification installed.

Update to v1.76

I don't see any flashes on the screen when attempting to write a post or PM.
What you can do is just disable snowflakes for those actions.
Imo it's not a big deal if the effects are not visible when users are actually writing a post or PM.
It will still show when they are reading PM's or browsing the forum posts.

Go to the Snowflakes admin and find the input box for:

QuoteList actions/subactions to disable Snowflakes (comma separated)

enter the following & save the settings.

Code Select

post,pm~send

Shades. · December 10, 2021, 09:41:45 AM

2.1RC4

Getting the following error on newest install:

QuoteError
Type of error
Undefined_vars
Error message
8: Undefined variable: currentAction
File
/home2/*****/public_html/*****/Sources/snowflakesSMF.php
Line
704
URL of page causing the error
https://*****.com/index.php?action=admin;area=modsettings;sa=snowflakes

Backtrace information
#0: smf_error_handler()
Called from /home2/*****/public_html/*****/Sources/snowflakesSMF.php on line 704
#1: smf_snowflakes_buffer()
Called from unknown on line -1

Chen Zhen · December 10, 2021, 06:29:02 PM

I fixed the undefined error & updated the modification.
Thanks for the report.

Dwev · December 27, 2021, 03:40:55 PM

I had Snowflakes 1.7 installed, everything worked, except Fireworks.

Just installed 1.7.8 and now everything works, except Xmas Lights (which I really liked, and was popular on the forum as well).

Can't make heads or tails why some of the effects do or don't work...

(either way, great mod..!

)

Chen Zhen · December 27, 2021, 06:57:11 PM

@Dwev:

It might be some sort of JS conflict.
Have you attempted to adjust various settings such as attach to the body or perhaps click on the checkbox that sets the defaults for the lights?

First try to enable "Append to <body> of the HTML page".

Dwev · December 28, 2021, 03:57:00 AM

Quote from: Chen Zhen on December 27, 2021, 06:57:11 PM@Dwev:
Have you attempted to adjust various settings such as attach to the body or perhaps click on the checkbox that sets the defaults for the lights?

Never had to that before, so have to admit that I didn't try to do this.

QuoteFirst try to enable "Append to <body> of the HTML page".

That did the trick, so now everything works!

Thanks a lot for the fast and very helpful reaction!

mickjav · December 28, 2021, 05:16:49 AM

Thanks Love it

Steve · December 28, 2021, 08:00:34 AM

Quote from: Chen Zhen on December 27, 2021, 06:57:11 PMFirst try to enable "Append to <body> of the HTML page".

Is that something everyone should do?

mickjav · December 28, 2021, 09:25:08 AM

Quote from: Steve on December 28, 2021, 08:00:34 AM
Quote from: Chen Zhen on December 27, 2021, 06:57:11 PMFirst try to enable "Append to <body> of the HTML page".

Is that something everyone should do?

Thats what I had to do with my 2.0.19 my 2.1 RC4 support site seems to work without it.

Steve · December 28, 2021, 10:59:34 AM

Thanks.

Chen Zhen · December 28, 2021, 04:08:19 PM

SMF Snowflakes has been updated to v1.79.

This release includes some fixes mostly affecting Xmas Lights, Halloween Effects & the user/welcome container detection.

@mickjav & steve:
You should be able to disable that previous setting for your Xmas Lights with this version & going forward.
Please let me know if it works as expected.

mickjav · December 28, 2021, 04:49:37 PM

Quote from: Chen Zhen on December 28, 2021, 04:08:19 PMSMF Snowflakes has been updated to v1.79.

This release includes some fixes mostly affecting Xmas Lights, Halloween Effects & the user/welcome container detection.

@mickjav & steve:
You should be able to disable that previous setting for your Xmas Lights with this version & going forward.
Please let me know if it works as expected.

Won't be able uninstall and install version till tomorrow but will let you know thanks.

Mick

Chen Zhen · December 28, 2021, 05:07:48 PM

Please take note for anyone updating this modification that the browser history should be initially cleared for the JavaScript changes to take effect.

mickjav · December 28, 2021, 06:40:36 PM

Managed to install on my tab turned off <body> and seems to work, I have a few random events selected one seems not to show i'll look more into that tomorrow.

I did clear history before installing.

News:

Snowflakes