Simple Colorizer

Started by Diego Andrés, June 26, 2011, 10:03:48 PM

Previous topic - Next topic

jsx

Quote from: Diego Andrés on September 20, 2022, 01:59:09 PMFor the actual list? It should work in 2.1.3 with no additional changes required.
See: https://github.com/SimpleMachines/SMF/pull/7500

I want to share such a suggestion. It's nice that in 2.1.3 this possibility appeared, but maybe in 2.1.4 developers could implement nick colors in the post?

Simple Colorizer is a great mod, but I feel like there should be some consistency and if 2.1.3 implemented nick coloring in the online list, I think nicks in posts should be colorized by the software as well.

Diego Andrés

I'm not sure what you are referring to

SMF Tricks - Free & Premium Responsive Themes for SMF.

jsx

In SMF 2.1.3 it was implemented that nicks display in color in "Who's Online?" So I wanted to leave an idea here, so that you think about implementing in version 2.1.4 the possibility of displaying nicks in color in the post. I mean what your mod does. I refer to it: https://github.com/SimpleMachines/SMF/pull/7500

Just wanted to share this thought of mine. :)

Diego Andrés

I thought it already displayed names in colors, that's why I don't understand what one thing has to do with another.
Do you have a screenshot of what area you are referring to?

Also keep in mind the mod only colors links, it will not color plain text.

SMF Tricks - Free & Premium Responsive Themes for SMF.

Speed King

#144
Installed Simple Colorizer version 1.3.1 on my SMF 2.1.3 forum.
This 1.3.1 version has conflict with Mentions feature, the mentioned members are displayed with different color instead of their membergroup. Problem appears when editing already submitted post including mentions.

Installed version 1.1 works fine with SMF 2.1.3 :)

jsx

I meant that in SMF 2.1.3 was implemented that the nick of e.g., admin, moderator is displayed in color in Who is online?



So, I just shared an idea to take it a step further and, for example, in SMF 2.1.4, implement the display of nickname colors in the post. Exactly what your mod does. :)


Steve

Quote from: Speed King on November 23, 2022, 04:34:45 AMThis 1.3.1 version has conflict with Mentions feature, the mentioned members are displayed with different color instead of their membergroup.
I've noticed this as well. But it's not always constant (at least for me). Sometimes the color is right, sometimes it's not.
DO NOT pm me for support!

Diego Andrés

Quote from: jsx on November 23, 2022, 06:25:46 AMSo, I just shared an idea to take it a step further and, for example, in SMF 2.1.4, implement the display of nickname colors in the post. Exactly what your mod does. :)



It already does this, because it colors the links. Not sure if that's an issue you have with other mod?
You cannot view this attachment.



Quote from: Speed King on November 23, 2022, 04:34:45 AMThis 1.3.1 version has conflict with Mentions feature, the mentioned members are displayed with different color instead of their membergroup. Problem appears when editing already submitted post including mentions.

I can't reproduce it.
You cannot view this attachment.
You cannot view this attachment.

SMF Tricks - Free & Premium Responsive Themes for SMF.

jsx

Quote from: Diego Andrés on November 23, 2022, 06:19:11 PMIt already does this, because it colors the links. Not sure if that's an issue you have with other mod?

You cannot view this attachment.

You mean that SMF 2.1.3 has username coloring where you showed it on screen or do you mean Simple Colorizer mod does it?

Diego Andrés

The mod does it, always had it.

SMF Tricks - Free & Premium Responsive Themes for SMF.

jsx

I know and appreciate your mod.

I meant that in SMF 2.1.3 the admin, moderator is displayed in his color in the Who is online list, so I just gave an idea to, for example, in version 2.1.4 implement the color display right here:



I wrote this idea in your mod topic because I referenced this quote:

Quote from: jsx on September 20, 2022, 01:14:33 PM@Diego Andrés

Have you thought about implementing member name coloring in Who's Online? This is missing here.

Quote from: Diego Andrés on September 20, 2022, 01:59:09 PMFor the actual list? It should work in 2.1.3 with no additional changes required.
See: https://github.com/SimpleMachines/SMF/pull/7500

jsx

@Diego Andrés

I noticed that the color of the username of e.g. admin stops working in the post when a post is merged and the post merge information is displayed. I am using Merge double posts mod to merge posts: https://custom.simplemachines.org/index.php?mod=4286

jsx

And I noticed one more thing that Simple Colorizer doesn't show the color of my nick in "The following users thanked this post" from the Say Thanks mod, if I'm logged in to the forum I can't see my nick color there, if I log out of the forum I see that my nick is displayed in red.

When I'm logged into the forum and enter a post, I see it like this:



When I am logged out of the forum and enter a post as a guest, I see it like this:


Diego Andrés

Quote from: jsx on December 28, 2022, 05:23:46 PM@Diego Andrés

I noticed that the color of the username of e.g. admin stops working in the post when a post is merged and the post merge information is displayed. I am using Merge double posts mod to merge posts: https://custom.simplemachines.org/index.php?mod=4286

I don't know what you mean, I tested it and the color is displayed correctly.



Quote from: jsx on December 29, 2022, 07:38:01 AMAnd I noticed one more thing that Simple Colorizer doesn't show the color of my nick in "The following users thanked this post" from the Say Thanks mod, if I'm logged in to the forum I can't see my nick color there, if I log out of the forum I see that my nick is displayed in red.

When I'm logged into the forum and enter a post, I see it like this:



When I am logged out of the forum and enter a post as a guest, I see it like this:



This is not an issue with the mod, it's because the current thanker is inside <strong>tag</strong> and it has a higher specificity in the css.
You could add this to the css to work around it.
a > strong {
  color: inherit;
}

SMF Tricks - Free & Premium Responsive Themes for SMF.

jsx

Quote from: Diego Andrés on December 29, 2022, 07:40:13 PMI don't know what you mean, I tested it and the color is displayed correctly.

@Diego Andrés please look at it.

I mentioned my second admin account:



The red color of the admin nick is displayed correctly, but after adding a second post, when "Merge double posts" mod will merge these posts, the red admin nick is no longer displayed.



Why do you think the "Merge double posts" mod affects the Simple Colorizer mod here?

Quote from: Diego Andrés on December 29, 2022, 07:40:13 PMThis is not an issue with the mod, it's because the current thanker is inside <strong>tag</strong> and it has a higher specificity in the css.
You could add this to the css to work around it.

Thank you for providing the solution, this code to which css should I add? Do you mean saythanks.css file from this mod?

Diego Andrés

Any css file, it doesn't matter.

SMF Tricks - Free & Premium Responsive Themes for SMF.

Diego Andrés

Quote from: jsx on January 01, 2023, 06:53:15 AMThank you for providing the solution, this code to which css should I add? Do you mean saythanks.css file from this mod?
Added it as a 'feature'. It's not an issue from any mod.

Quote from: jsx on January 01, 2023, 06:53:15 AMThe red color of the admin nick is displayed correctly, but after adding a second post, when "Merge double posts" mod will merge these posts, the red admin nick is no longer displayed.
Fixed the logic.

1.4 - 01 January 2023
  • Improvement Improve the logic for adding the styles.
  • New Feature Prevent specificity from overtaking the color of the link.



SMF Tricks - Free & Premium Responsive Themes for SMF.

jsx

Thank you Diego for this release. :)

Steve

Thanks from me as well, Diego.
DO NOT pm me for support!

macklij

Hi all
I just tried to install this mod and got "The package you are trying to install is either corrupt or not compatible with this version of SMF". I am on SMF 2.0.19.

I am technically competent but not overly familiar with SMF. I note the package says its compatible up to v2.1.4 so should be OK. I uploaded the package by downloading the zip locally and then used 'upload a package in SMF.

I'd be grateful for any pointers.  Thanks.

Advertisement: