Adding PHP snippet increases page query count 10 fold

[Mayhem30]

I've created a php snippet which allows me to add the 'nofollow' tag to only certain external URL's. It's works just fine, but the problem is that after I add the code, the page query count jumps up a 10 fold.

Before  : Page created in 0.11 seconds with 22 queries.
After    : Page created in 0.137 seconds with 202 queries.

Here is how I added the code : (SMF 1.1.18) - Sources/Subs.php

Find:

Code Select Expand

// Cleanup whitespace.
$message = strtr($message, array('  ' => ' &nbsp;', "\r" => '', "\n" => '<br />', '<br /> ' => '<br />&nbsp;', '&#13;' => "\n"));

Add After :

Code Select Expand

// NoFollow domains.
$nofollow_domains = array('competitor1.com', 'competitor2.com', 'competitor3.com');

preg_match_all('~<a.*>~isU',$message,$matches);
for ( $i = 0; $i <= sizeof($matches[0]); $i++)
{
if ( !preg_match( '~nofollow~is',$matches[0][$i]) && !preg_match( '~EXAMPLE.COM~',$matches[0][$i]) )
{
foreach($nofollow_domains as $a)
{
if (stripos($matches[0][$i],$a) == true)
{
$result = trim($matches[0][$i],">");
$result .= ' rel="nofollow">';
$message = str_replace($matches[0][$i], $result, $message);
}
}
}
}

The code first makes sure that a 'nofollow' tag does not already exist in the link + that it's not an internal link (EXAMPLE.COM) .. then proceeds to loop the array to see if the link is a competitors (and adds the nofollow tag when there is a match).

Any idea how I can fix this?

[emanuele]

I can't see any query in the snippet you posted.

[Mayhem30]

I can't see any query in the snippet you posted.

That's exactly my issue - there isn't any queries. However, my snippet is producing those results and I have no idea why.

[vbgamer45]

Add
$db_show_debug = true;

To your settings.php and there should be a link that will show you want the queries are at the bottom of your forum.

[Arantor]

Also check the error log...inserts to that get counted.

[Mayhem30]

Ok, the extra queries were all : INSERT INTO yabbse_log_errors

The errors I'm getting is :

Code Select Expand

Notice: Undefined offset: 3 in /www/example.com/httpdocs/forum/Sources/Subs.php on line 2421
Notice: Undefined offset: 3 in /www/example.com/httpdocs/forum/Sources/Subs.php on line 2425


Those 2 error codes point to these lines :

Code Select Expand

if ( !preg_match( '~nofollow~is',$matches[0][$i]) && !preg_match( '~EXAMPLE.COM~',$matches[0][$i]) )
if (stripos($matches[0][$i],$a) == true)

Any ideas what I did wrong?

[Arantor]

You're using sizeof with your <= loop.

Which means it's doing from 0 to 3, i.e. 4 times, across a loop of 3 items.

It should be:

Code Select Expand

for ( $i = 0; $i < sizeof($matches[0]); $i++)

Or even better:

Code Select Expand

for ( $i = 0, $len = sizeof($matches[0]); $i < $len; $i++)

to avoid recalculating it every single iteration.

[Mayhem30]

Thank you very much, that did the trick!