Simple Audio Video Embedder

[Steve]

@Melonking - when you say it made the same modification, are you saying the change Ohara made is EXACTLY the same? Character by character?

If not, then no sense in proceeding. Even if so, I'm not sure how the mods would operate with each other.

Two options:

1. Try this on a test forum if you have one (after doing backups!!). (optimal)

2. Try it on your production forum (again, after doing backups!!).

[vbgamer45]

That should be safe to processed for that one edit.

[Melonking]

Embeds are disabled from appearing in previews. Was causing issues in the past which is why it is disabled

Click to preview is interesting but the mod would have to be redone and gets complicated since it would require a request via ajax to download the embed and have it appear in the post. I don't think is something that i would do and hasn't been enough demand for it.

Embedding in links is tricky we do processing after bbc. Not sure if I can solve

It you could add a settings option to only embed links that are on their own unique line - that would be a good compromise (not perfect since it would confuse things like center-link-center - but still good!)

[Julius_2000]

Hi,
just wanted to report a minor bug that I encountered per this topic:

https://www.simplemachines.org/community/index.php?topic=585075.0

Apparently, the "Facebook video (new v5)" option caused some posts in one topic and just on one page to be not included in the forumposts div container, causing some formatting issues described in the above topic.

[lord alibaski]

Hi

I have had a few issues of late with my forum had to restore back to an older date.I don't know if this is a major problem but for some reason when the forum was restored  Simple Audio Video Embedder isn't showing up inside the browse package area but it's showing as installed in the admin area. I checked via ftp and it's not in the package folder!! I tried to install it again but it messed up my forum gave me a http 500 error so I had to restore again to get back into my forum.

[lord alibaski]

Will deleting all the tables from the database remove the package? because at the moment I can't install it unless a newer version comes out that will re-write over this one and put the package back inside the package manager.

Look this is what is happening  (see attachments)

[vbgamer45]

You can't uninstall the old version?

[lord alibaski]

You can't uninstall the old version?

No mate the package is missing from the package manager so no option to uninstall it.

I tried to install it again but soon as it installed it messed up the forum so I had to restore the database again.

[vbgamer45]

Yeah if didn't uninstall the first time trying to install again will mess it up if the mod is already installed.
You can upload the package to and do the file edits to remove.
https://www.smfhacks.com/smf-package-parser.html

[lord alibaski]

I was just going to try that but had one last go at uploading it to the directory and thank god it showed up this time in the package manager....bit happier now that's installed properly.

[vbgamer45]

Glad you have it working!

[lord alibaski]

Glad you have it working!

So am I 

[Melonking]

Is there a way to disable this mod in particular themes? I asked it not to install in one of my custom themes but the emebeds still show up anyway - id like it to do nothing on some themes.

[vbgamer45]

There is not an option for that.

[Melonking]

Is there a way to disable this mod in particular themes? I asked it not to install in one of my custom themes but the emebeds still show up anyway - id like it to do nothing on some themes.

There is not an option for that.

I did a bit of snooping and it appears I can answer my own question for anyone needing a solution!

Open Sources/AutoEmbedMediaPro2.php - search for "// Load the cache file" and add this code just above it:

Code Select Expand

if($context['user']['theme_id'] == 6) {
  return $message;
}Replace the 6 with the ID of the theme you want to disable this feature on!

----

Next question! Is there a way to make embeds appear in previews? I can see that function MediaProProcess($message) is the call that converts things into embeds; so I just that just needs to be added to the preview loader same as its added to the Subs.php - but I have no idea where that is!

[vbgamer45]

I added code to disable on the action preview as it broke some things. I forget where it was a while back...

[Melonking]

I added code to disable on the action preview as it broke some things. I forget where it was a while back...

Ah thanks for letting me know! I got it!

To enable previews - search for this bit of code in Sources/AutoEmbedMediaPro2.php and delete or comment it out!

Code Select Expand

if (isset($_REQUEST['action']))
    {
        if ($_REQUEST['action'] == 'post' || $_REQUEST['action'] == 'post2')
            return $message;
    }
I don't notice any issues right away, but I'll keep an eye out for them.