Advertisement:

Author Topic: Bugs in the IPB2 converter (with some fixes, incl login fix)  (Read 8272 times)

Offline Sarke

  • Jr. Member
  • **
  • Posts: 315
Bugs in the IPB2 converter (with some fixes, incl login fix)
« on: January 11, 2007, 06:56:57 PM »
I think we need to list the bugs so they can more easily be fixed.

1. Poll choices error. - FIXED

To fix, in the .sql file, replace

Code: [Select]
$rows[] = "$row[ID_POLL], SUBSTRING('" . implode("', 1, 255), '", $choice) . "'";
with

Code: [Select]
$rows[] = "$row[ID_POLL], SUBSTRING('" . implode("', 1, 255), SUBSTRING('", $choice) . "', 1, 255)";
From what I've read, this problem is also in the IPB 1.3 converter.

(source)


2. Size tag conversion error. - FIXED

The preg_replace in the .sql file in the members (sigs), post, and PM steps. This is incorrect

Code: [Select]
'~<span style=\'font-size:([^;]+?).+?\'>(.+?)</span>~is',
It only returns the first character of the font-size instead of the entire font-size.  For example, it turns

Code: [Select]
<span style='font-size:14pt;line-height:100%'>TEXT</span>
into

Code: [Select]
[size=1]TEXT[/size]
when it should turn it into

Code: [Select]
[size=14pt]TEXT[/size]

EDIT: To fix, in the .sql replace (three times)

Code: [Select]
'~<span style=\'font-size:([^;]+?).+?\'>(.+?)</span>~is',
with

Code: [Select]
'~<span style=\'font-size:(.+?);.+?\'>(.+?)</span>~is',
Thanks to JayBachatero for this one!  :D


3. Closing tags in the wrong order. - FIXED

In IPB it looks like this

Code: [Select]
[color=navy][font=Times]First part[/font]Second part[/color]
but after the conversion it looks like this

Code: [Select]
[color=navy][font=Times]First part[/color]Second part[/font]
I realise that both closing tags are </span> which is the cause of the problem but it also allows it to work properly.  Still, the old posts will be have the wrong order and editing/copying/quoting them will be a bit confusing as the code is misleading.

EDIT: To fix, in the .sql replace (three times)

Code: [Select]
'~<span style=\'color:([^;]+?)\'>(.+?)</span>~is',
'~<span style=\'font-size:(.+?);.+?\'>(.+?)</span>~is',
'~<span style=\'font-family:([^;]+?)\'>(.+?)</span>~is',

with

Code: [Select]
'~<span style=\'color:([^;]+?)\'>(.+)</span>~is',
'~<span style=\'font-size:(.+?);.+?\'>(.+)</span>~is',
'~<span style=\'font-family:([^;]+?)\'>(.+)</span>~is',


4. Passwords not working after conversion. - FIXED

EDIT: To fix, delete from the .sql

Code: [Select]
, '' AS passwordSalt
« Last Edit: February 21, 2007, 01:02:34 AM by Sarke »
My MODs          Please don't PM me for support, post in the appropriate topic.

Offline JayBachatero

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 19,562
  • Gender: Male
    • @jaycreations on Twitter
    • JayBachatero.com
Re: Bugs in the IPB2 converter
« Reply #1 on: January 12, 2007, 03:11:22 PM »
Thanks for the list Sarke.  I'll look into updating these converters soon.
Follow me on Twitter

"HELP!!! I've fallen and I can't get up"
This moment has been brought to you by LifeAlert

Offline Sarke

  • Jr. Member
  • **
  • Posts: 315
Re: Bugs in the IPB2 converter
« Reply #2 on: January 13, 2007, 02:17:17 PM »
Thanks, and np.


5. PMs not converted properly.

I have members who say that they see old PMs that they've deleted months ago.  Personaly my inbox grew from 163 to 204, while my outbox went from 249 to 1.
My MODs          Please don't PM me for support, post in the appropriate topic.

Offline gstone

  • Newbie
  • *
  • Posts: 4
Re: Bugs in the IPB2 converter
« Reply #3 on: January 13, 2007, 02:46:11 PM »
Do these errors occur every time someone uses this converter, or is it sometimes successful?  In other words, should I hold off on attempting conversion?

I'm currently running IPB 2.1.7, hosted at IPS.  I'd like to move it over to SMF on my own server so I can integrate it with Joomla.

Also, I've been searching for tips on how to set SMF permission to access the IPB database.

Please either explain as if to a small child (I'm a db newbie) or point me in the right direction, as my searches aren't finding the answer.

Offline Sarke

  • Jr. Member
  • **
  • Posts: 315
Re: Bugs in the IPB2 converter
« Reply #4 on: January 24, 2007, 07:34:00 AM »
As far as I know, these are there most of the time at least.  As for SMF using the IPB database, that's not possible since they have different database structures.  You have to convert it.



New issue I found:

6. Uploaded avatars aren't showing up after conversion.

The attachments are being moved, but not the avatars (they're not even being copied).
My MODs          Please don't PM me for support, post in the appropriate topic.

Offline gstone

  • Newbie
  • *
  • Posts: 4
Re: Bugs in the IPB2 converter
« Reply #5 on: January 24, 2007, 11:59:13 AM »
Quote
As for SMF using the IPB database, that's not possible since they have different database structures.  You have to convert it.
I'm sorry I wasn't more clear.  I was referring to the conversion process where  the manual says:
Quote
Note: The converter will not work unless SMF has access to the database that the forum you're converting from is on. For best results, you should install SMF on the same database as the forum you're converting from. If this is not possible, you will need to make sure that the MySQL user account being used for SMF has access to the other forum's database. If you are not sure how to do this, please ask on the forum and someone should be able to assist you.
If there's a topic discussing this, I wouldn't mind being directed to it, so as not to derail your bugs topic.  Thanks.

Offline Sarke

  • Jr. Member
  • **
  • Posts: 315
Re: Bugs in the IPB2 converter
« Reply #6 on: February 05, 2007, 02:21:43 PM »
Any news on this?

I still haven't been able to convert my forum because I'm waiting on this.  #2 and #5 are the most important ones IMO.  #4 would be very nice too.
« Last Edit: February 05, 2007, 02:40:33 PM by Sarke »
My MODs          Please don't PM me for support, post in the appropriate topic.

Offline JayBachatero

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 19,562
  • Gender: Male
    • @jaycreations on Twitter
    • JayBachatero.com
Re: Bugs in the IPB2 converter
« Reply #7 on: February 05, 2007, 03:36:14 PM »
Are you on 2.2 or 2.1?  Also can you post an example post with the the size tags and so on so that I can test the regular expression.
Follow me on Twitter

"HELP!!! I've fallen and I can't get up"
This moment has been brought to you by LifeAlert

Offline Sarke

  • Jr. Member
  • **
  • Posts: 315
Re: Bugs in the IPB2 converter
« Reply #8 on: February 05, 2007, 06:19:17 PM »
Put fixes for two more (#2 and #4) in the first post.

Thanks again JayBachatero.
My MODs          Please don't PM me for support, post in the appropriate topic.

Offline JayBachatero

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 19,562
  • Gender: Male
    • @jaycreations on Twitter
    • JayBachatero.com
Re: Bugs in the IPB2 converter (with some fixes, incl login fix)
« Reply #9 on: February 08, 2007, 11:56:08 AM »
Ok after working with Sarke on this one we managed to get most of the bugs ironed out.  Let's keep further discussion in this topic. IPB 2.0.x
Follow me on Twitter

"HELP!!! I've fallen and I can't get up"
This moment has been brought to you by LifeAlert

Offline Sarke

  • Jr. Member
  • **
  • Posts: 315
Re: Bugs in the IPB2 converter (with some fixes, incl login fix)
« Reply #10 on: February 21, 2007, 01:03:06 AM »
Put in fix for #3, which makes all of them.  
My MODs          Please don't PM me for support, post in the appropriate topic.

Offline JayBachatero

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 19,562
  • Gender: Male
    • @jaycreations on Twitter
    • JayBachatero.com
Re: Bugs in the IPB2 converter (with some fixes, incl login fix)
« Reply #11 on: February 21, 2007, 10:02:00 AM »
I'll update the converters in a few.
Follow me on Twitter

"HELP!!! I've fallen and I can't get up"
This moment has been brought to you by LifeAlert

Offline JayBachatero

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 19,562
  • Gender: Male
    • @jaycreations on Twitter
    • JayBachatero.com
Re: Bugs in the IPB2 converter (with some fixes, incl login fix)
« Reply #12 on: February 21, 2007, 06:37:19 PM »
Ok Updated the other topic.
Follow me on Twitter

"HELP!!! I've fallen and I can't get up"
This moment has been brought to you by LifeAlert