Thank-O-Matic

[enotar]

I get this in the list with texeditor:
TinyPortal|^|tp|^|bloc:tinyportal|^|1.083
s-c|^|s-c.zip|^|islam2hamy:s-c|^|1.0
SoLoSMiLeYS|^|SoLoSMiLeYS1.0.zip|^|sologhost:solosmileys|^|1.0
Your Last Visit|^|YourLastVisit_v1_1.zip|^|M-DVD:YourLastVisit|^|1.1
Linkback|^|linkback.zip|^|Arantor:Linkback|^|1.0
Sticky First Post (extends sticky topic)|^|stickyFirstPost_1.3.2.zip|^|kuklovod:extendedStickyTopic|^|1.3.2
Allow Access while in Maintenance Mode|^|allow_access_maint_mode.zip|^|Arantor:AllowAccessInMaintMode|^|1.0
Do not enter|^|guests_can_not_enter_topics.zip|^|SmokyBlue:Do_not_enter_topics|^|1.1
Unread by category|^|ubycat.zip|^|unreadbycat|^|1.0
reCAPTCHA for SMF|^|reCAPTCHAforSMF_0-9-6.tar.gz|^|motokochan:recaptchaforsmf|^|0.9.6
Board Message Icon|^|BoardMessageIcon.zip|^|cakal93:bmi|^|1.0
Copy Topics|^|copytopics_v1-5-1.zip|^|karlbenson:copytopics|^|1.5.1
Reply Button in All Posts|^|reply-in-post1-1.zip|^|KahneFan:reply_in_post|^|1.1
AvatarSelect|^|avatarselect.zip|^|vbgamer45:AvatarSelect|^|1.2.1
No More Ugly Avatar Scrollbars|^|no_more_avatar_scrollbars_1.0.zip|^|Deprecated:no_more_avatar_scrollbars|^|1.0
PageDropdown|^|page_dropdown.zip|^|Arantor:PageDropdown|^|1.1
Mark Selected Topics As Read|^|MarkSelectedAsRead.zip|^|jaybachatero:mark_selected_as_read|^|1.0
Registered Links|^|reglinks.zip|^|vbgamer45:RegLinks|^|2.0
Online status on login|^|OnlineStatusOnLogin_1-2.zip|^|Kays:OnlineStatusOnLogin|^|1.2
Reason For Editing Mod|^|Reason_for_Editing_v2.0.zip|^|winrules:EditReason|^|2.0
InfoBox|^|InfoBox.zip|^|Daydreamer:InfoBox|^|0.1
Thank You Mod|^|ThankYouMod123.zip|^|din1031:ThankYou|^|1.2.3
Signature Settings Mod|^|signaturelimits1-1.zip|^|CustomizeTeam:SignatureSettings|^|1.1
Quick Upload|^|quick_upload2.1.zip|^|Elmacik:QuickUpload|^|2.1
Enhanced Calendar|^|Calendar_1-1.zip|^|daniel15:Calendar|^|1.1
Event Registration Mod|^|ERM_0.17BETA.zip|^|kripz:EventRegistrationMod|^|0.17 BETA
TextareaResizer|^|TextareaResizer_1.1.zip|^|digger:TextareaResizer|^|1.1
Attachments Positioning|^|Attachments_Positioning_v1.2.zip|^|quake101:attachmentspositioning|^|1.2
SMF Gallery Lite|^|SMFGallery2.0.8.zip|^|vbgamer45:smfgallery|^|2.0.8
Topic Solved|^|tsolved_v1.22.tar.gz|^|grudge:topic_solved|^|1.22

Thank you but No "thank o matic"!
So I cannot continue

[V@no]

then, skip 1 and 2
try this line then:

Code Select Expand

Thank-O-Matic|^|ThankOMatic125.zip|^|din1031:ThankOMatic|^|1.2.5
(assuming you have ThankOMatic125.zip in Packages folder)

[EDIT]
you have old "Thank you mod" installed..

Code Select Expand

Thank You Mod|^|ThankYouMod123.zip|^|din1031:ThankYou|^|1.2.3

That must be the reason...

[enotar]

Nothing works
Cannot get in the setting so I cannot disable Thank you mod so I cant uninstall it!
I am screw!

[enotar]

Ok I am back but still cannot uninstall Thank o Matic
This mod is a nightmare!

I want it OUT!

tkz

[silber112]

Things that you have to fix for the next realise:


- If I delite a user, delite all his thaks TOO.
- Add a link to the profile to see where a user gived a thank you
- Add to STATS the most thanked Post and Topics.

[ディン1031]

Ok I am back but still cannot uninstall Thank o Matic
This mod is a nightmare!

I want it OUT!

tkz

It logical if you install it twice... the easiest way to solve the problem is to remove the double insert functions in the ModSettings.php.

Things that you have to fix for the next realise:


- If I delite a user, delite all his thaks TOO.
- Add a link to the profile to see where a user gived a thank you
- Add to STATS the most thanked Post and Topics.

For which Version? And this is not something to fix it would be somethings that improve it.

- Add a link to the profile to see where a user give a thank you

Normal this is possible, as far i think. Which Version did you use?

- Add to STATS the most thanked Post and Topics.

Yeah i can do that, i programed something that could do that, but it will be only in the 2.0 Version

- If I delite a user, delite all his thaks TOO.

Hmmm i recount everything that have something to do with that. But i will see normal it should be no problem because i reset anyway the counters so this should be not a problem.

[V@no]

Any plans add AJAX for SMF 1.x version?

No, i changed the complöete system in SMF 2 that this is possible. So i will never back port it .

Would you change you mind if I post the changes needed?
So far I've successfully ported your SMF2 ThankYouPost.php to work with SMF1.
I got to the point that ajax works, the only thing I'm missing is additional setting to enable/disable ajax. At this stage I just force it enable in Load.php...which pretty much is enough for my needs

[ディン1031]

I will not do it, i want make this feature only for 2.0 .

Hmmm you did bring it to work oO there should be some things missing if this really the case.

But for the Ajax Work i can give you some hints:
There is java script part in the display.template.php that needed to be insert there (i'm not sure if he variables are the same). You also need to insert a function for the template_thank_you_post inside the index.template.php. Also the button need a little tweak but you can see that in the display.template.php. Hmmm than you need to insert the ajax thank you function in the index.php so that could be used at least . (It handle my ajax stuff and make it readable for the javascript xD).

So i think i can not give more tips . But feel free to ask me about it via pm. =)

[V@no]

Thank you for the tips.

I'm having a hard time figure out how can I get proper permissions for "post a thank you", lock and delete for a specific message...

Since any actions for a single post supply topic id, msg id and thx id, based on these values what would be a routine to get new permissions?

Having that data, your AJAX function could be easily improved if supplied to javascript new permissions and possible some other additional data after the action (to show/hide/change buttons, change "thank you" numbers of the person received "thank you", etc)


Thank you.

[jeisy]

I have a problem Thanks O Matic, I put a Button in all POST Thanks Qusiera nothing more in the first message is that possible?

[ディン1031]

Thank you for the tips.

I'm having a hard time figure out how can I get proper permissions for "post a thank you", lock and delete for a specific message...

Since any actions for a single post supply topic id, msg id and thx id, based on these values what would be a routine to get new permissions?

Having that data, your AJAX function could be easily improved if supplied to javascript new permissions and possible some other additional data after the action (to show/hide/change buttons, change "thank you" numbers of the person received "thank you", etc)


Thank you.

Hmmm my ajax take the SMF Permissions so that is okay for me how it works at the moment .

I have a problem Thanks O Matic, I put a Button in all POST Thanks Qusiera nothing more in the first message is that possible?

In the new Version it's implementet but in the old Version this is not possible. You can use a trick so that user can post only to the first post a thank you. (I postet it in this thread... hope i find it *g*)

[jeisy]

   
Thanks to you when you please notify me that trick.

[V@no]

Hmmm my ajax take the SMF Permissions so that is okay for me how it works at the moment .

Yes, but it hides "thank you" button and if user has permissions to lock/delete "thank you" it doesn't show the needed buttons without page refresh - IMO it just not right
Currently TOM outputs the text and JS prints whatever was outputed. It could be expanded to output key-separated text:
buttonThankYouPermission|buttonLockPermission|buttonDeletePermission|textType 0=noError, 1=Error|text

Code Select Expand

0|1|1|0|the rest of the text with list of who said thank you, or error message
or JSON type
This way it would allow supply javascript part with additional information, make it more "friendly".

And besides, your ThankYouPostAJAX() function was already built with future expansion in mind, because it's already supports "list" and "lock" which is not used in current version
To expand it to use "delete" is piece of cake, it's just to get the permissions I got stuck at...

P.S.
Sorry for being pushy...

[ディン1031]

Yeah i know the lock is implemented in the code, i only had no time to integrate it in the script. My Problem here is the button need to be changed between close and open and each time if i change the text they are not correct formated. Possible in the new theme it could be work.

   
Thanks to you when you please notify me that trick.

Hmmm, let's see if i can find it :X.

http://www.simplemachines.org/community/index.php?topic=176565.msg2046126#msg2046126

[Kimmie]

I am ancountering a problem with a feature on this mod. The feature for:

"Add 1 Point the user Karma, if someone give a thank you to the post"

When this is turned on, and I try to "delete" someones thank you I get this error:

Wrong value type sent to the database. Integer expected. (p_karma_good)

And this error in my logs:

Wrong value type sent to the database. Integer expected. (p_karma_good)
Function: updateMemberData

File: /home/****/public_html/Sources/Subs.php
Line: 545

and then I get this in the post I tried to delete the thank you from:

I know your busy but I just wanted to see if there was any updates on this issue

thanks

[ディン1031]

Oh thank you i forgot to fix that.

The current fix is:

ThankYouPost.php (Only 2.0 Versions)

            if (!empty($modSettings['karmaMode']) && !empty($modSettings['thankYouPostIncraseKarmaGood']))
               updateMemberData($ID_MEMBER_POST, array('karma_good' => 'karma_good - '.count($poster[$id_msg])));

            updateMemberData($ID_MEMBER_POST, array('thank_you_post_became' => 'thank_you_post_became - '.count($poster[$id_msg])));
            if (!empty($modSettings['karmaMode']) && !empty($modSettings['thankYouPostIncraseKarmaGood']))
            {
               // Call his current Karma Points...
               global $user_profile;
               loadMemberData(array($ID_MEMBER_POST));
               if (!empty($user_profile[$ID_MEMBER_POST]))
               {
                  $newKarma = $user_profile[$ID_MEMBER_POST]['karma_good'] - count($poster[$id_msg]);
                  updateMemberData($ID_MEMBER_POST, array('karma_good' => (int) $newKarma));
               }
            }

Bye
DIN1031

[ExWizzard]

Hello , i get 2 errors in the log when deleting a thank you. The deleting works fine i guess , but i dont know why the errors show.

Code Select Expand

8: Undefined index: id_thx_post
File: /opt/lampp/htdocs/yforum/Sources/ThankYouPost.php
Line: 1497

Code Select Expand

8: Undefined index: thank_you_post_last_id
File: /opt/lampp/htdocs/yforum/Sources/ThankYouPost.php
Line: 1497

that line is   ==>1497:     if ($modSettings['id_thx_post'] == $values['thank_you_post_last_id'])


also is it possible to show the thank you under the post count or something like that?

Hello , still have this problem , also another problem is that in member list the received and given thank you names on top are making that line double on all pages except first

[ディン1031]

Hello , still have this problem , also another problem is that in member list the received and given thank you names on top are making that line double on all pages except first

I don't understand this oO i tested it work fine with all pages... picture? Example Link?

The other thing... Yes i've fixed the bug .

I must look how i fixed it :X

      // Reset? Nothing to do if allready set
      if ($values['id_thx_post'] == $modSettings['thank_you_post_last_id'])
         return true;

That is the new part, you need only change the one line .

Bye
DIN1031

[ExWizzard]

i have sent u the login details in pm

[ディン1031]

i have sent u the login details in pm

I sent you a possible fix, in your theme case.