News:

SMF 2.0.19 has been released! Please update. Read more.

Main Menu

Bookmarks

Started by Matthew K., July 16, 2007, 01:07:24 PM

Previous topic - Next topic

efil59

#340
Quote from: efil59 on October 17, 2008, 11:27:49 AM

QuoteGo to the admin center and click the 'permissions' link.


Can't find there.
The mod i working good but only for the admin.
maybe somthing in the installation went wrong.

Ok I found the problem.
But now it's working only for the admin.
When my users try to use the mod thay get this:
QuoteDatabase Error
Please try again. If you come back to this error screen, report the error to an administrator.
Thanks,
Efil.

bn7

Quote from: Aäron on October 17, 2008, 11:05:22 AM
Which version of SMF are you using? I tested both the version for SMF 1.1 and 2.0 from an admin perspective, and both seemed to be working alright.

First off i set permissions (flag the option for create bookmarks for the topic).
Then link in template appear but isn't usable.

I use SMF 1.1.6

With previous mod this problems wasn't present.
Only problems with board in read mode like explain in previous posts.

Nathaniel

As pointed out by Garry1953 and Frozt, there is an error with the 2.2 version of this mod for SMF 2 Beta.

Line 46 of 'bookmarks22.xml' is:
            <search position="after"><![CDATA[
It should be:
            <search position="before"><![CDATA[
SMF Friend (Former Support Specialist) | SimplePortal Developer
My SMF Mods | SimplePortal

"Quis custodiet ipsos custodes?" - Who will Guard the Guards?

Please don't send me ANY support related PMs. I will just delete them.

Frozt

Thanks LHVWB

Now work well  :) :) :)


Garry1953

LHVWB
Your change to the code fixes the problem.
Thanks :D

efil59

Quote from: efil59 on October 17, 2008, 04:48:54 PM
Quote from: efil59 on October 17, 2008, 11:27:49 AM

QuoteGo to the admin center and click the 'permissions' link.


Can't find there.
The mod i working good but only for the admin.
maybe somthing in the installation went wrong.

Ok I found the problem.
But now it's working only for the admin.
When my users try to use the mod thay get this:
QuoteDatabase Error
Please try again. If you come back to this error screen, report the error to an administrator.

Can someone help me?
Thanks,
Efil.

tk2012

#346
For those who don't know how to edit the .xml file and then zip it back up, I have attached it here.

This is the correct package for v2.0 b4.0  which makes the changes addressed above.


gexposito

Hi,

I have the same  error.   This mod work fine  only for Admin.

When my users try to use the mod thay get this:
    Database Error
    Please try again. If you come back to this error screen, report the error to an administrator.

But the data ( id_user and id post) is inserted in the sql correctly.

The user have activated the permissions.

I have 1.1.6 ver.

any idea?

trailmyx

Perhaps this will help Aaron debug this issue for those using SMF 1.1.6 and are having the:

Quote
Database Error
Please try again. If you come back to this error screen, report the error to an administrator.

Correct installation allows the admin to add bookmarks fine, but no other user to do so (yes, permissions have been granted for each group).

If you look at the forum error log, you find:

Quote
http://www.myforum.com/index.php?action=bookmarks [nofollow]
Apply Filter: Only show the errors with the same message
Database Error: Unknown column 'b.memberGroups' in 'where clause'
File: /www.myforum.com/smf/Sources/Bookmarks.php
Line: 65

This happens when you just click the "My Bookmarks" or try to add one using "Add Bookmarks"

Hope this helps.

TM

gexposito

Trailmix,  very thanks.

I solved this error ( I believe ):

Bookmarks.php

near line 65:
ORIGINAL:

   bm.ID [nofollow]_MEMBER = {$ID_MEMBER}

         AND {$user_info['query_see_board']}            <<<<<<<<<<< delete this line.

      ORDER BY t.id [nofollow]_last_msg DESC",

      __FILE__, __LINE__);



NOW:
WHERE
                        bm.ID [nofollow]_MEMBER = $ID_MEMBER

                ORDER BY t.id [nofollow]_last_msg DESC",
                __FILE__, __LINE__);


It work fine for me.

somebody can verify this and comment it?


Aaron

Thanks for the feedback everyone. The problems mentioned should be fixed in version 2.2.1. :)

trailmyx

Quote from: Aäron on October 20, 2008, 04:00:22 PM
Thanks for the feedback everyone. The problems mentioned should be fixed in version 2.2.1. :)

Beautiful!  That worked perfectly.  Now my Moderator can stop whining.  eheh.

Thank you for your effort; great mod!

TM

DocPixel

#352
I'm trying to install this mod, and I get these errors;
Execute Modification      ./Sources/ManagePermissions.php     Test failed

5.    Execute Modification    ./Themes/default/index.template.php    Test failed

I'm running SMF 1.1.6 and the mod version is the newly updated one from today; 221.


I'm not sure whether I should install it or not.  Aäron, what do you think is causing these errors?

trailmyx

One thing you have to keep in mind is that after you install a few other mods, you run the risk of breaking the installation of other packages. 

This mod didn't install for me either, but I've gotten used to  modifying installation packages to adjust for possible differences.  You really need to look at what the install package (for you would be bookmarks11.xml) is trying to change (changes to index.template.php) and be sure the item being searched for exists in your present site installation.  If not, it probably still exists, but you'll need to modify it a bit.

The problem here is that it's subjective to your installation and what packages you presently have.

DocPixel

Would it be helpful if I posted the specific list of mods I've installed?

Mainly, I want to be sure that if I go ahead, I won't break anything that's already working fine. The bookmark isn't a huge priority for me.

I can do simple edits, but I need my hand held for anything more than that.

efil59

Quote from: Aäron on October 20, 2008, 04:00:22 PM
Thanks for the feedback everyone. The problems mentioned should be fixed in version 2.2.1. :)

Working great! :)

Thanks,
Efil.

trailmyx

Quote from: DocPixel on October 21, 2008, 01:42:46 AM
Would it be helpful if I posted the specific list of mods I've installed?


That's always helpful.  But first, think about the other mods you've installed.  Judging from the error you are having, it has something to do with the modifications that are being made to your toolbar.  What other mods have you added to your site that have affected the toolbar?  For me, it was the File Download mod and a "by hand" mod to add a "New Posts" button.

hansdampf

Thanks for this mod, working great.

If I may suggest a slightly better German translation:

$txt['bookmarks'] = 'Meine Lesezeichen';
$txt['bookmark_list'] = 'Lesezeichen';
$txt['bookmark_list_empty'] = 'Du hast momentan keine Lesezeichen angelegt. Dies kannst du mit \'Lesezeichen hinzuf&uuml;gen\' in den Threads erledigen.';
$txt['bookmark_open_window'] = 'In neuem Fenster &ouml;ffnen';
$txt['bookmark_delete'] = 'Lesezeichen l&ouml;schen';
$txt['bookmark_delete_success'] = '%1$s Lesezeichen wurden erfolgreich gel&ouml;scht!';
$txt['bookmark_delete_failure'] = 'Nicht alle Lesezeichen konnten gel&ouml;scht werden.';
$txt['bookmark_add'] = 'Lesezeichen hinzuf&uuml;gen';
$txt['bookmark_add_success'] = 'Thread wurde erfolgreich zu deinen Lesezeichen hinzugef&uuml;gt!';
$txt['bookmark_add_exists'] = 'Dieser Thread befindet sich bereits in deinen Lesezeichen!';
$txt['bookmark_add_failed'] = 'Es ist ein Fehler beim Hinzuf&uuml;gen des Threads zu Deinen Lesezeichen aufgetreten!';
// Untranslated!
$txt['permissionname_make_bookmarks'] = 'Darf Bookmarks zu Themen anlegen.';
$txt['cannot_make_bookmarks'] = 'Dir fehlt leider die Berechtigung Bookmarks anzulegen!';

DocPixel

Quote from: trailmyx on October 21, 2008, 12:27:12 PM
Quote from: DocPixel on October 21, 2008, 01:42:46 AM
Would it be helpful if I posted the specific list of mods I've installed?


That's always helpful.  But first, think about the other mods you've installed.  Judging from the error you are having, it has something to do with the modifications that are being made to your toolbar.  What other mods have you added to your site that have affected the toolbar?  For me, it was the File Download mod and a "by hand" mod to add a "New Posts" button.

Trailmyx, I'll post the mod list and a screen shot of my toolbar. I installed the "draft" mod, which adds a button below. Is that considered part of the toolbar?

And I'm attaching the two files in question - I've looked, but can't seem to unravel what it's looking for. 

Mod Name     Version     
1.    SMF Gallery Lite    1.7.1    [ List Files ] [ Delete ]
2.    SMF 1.1.2 Update Package    1.1.2    [ List Files ] [ Delete ]
3.    SMF 1.0.12 / 1.1.4 / 2.0 b1.1 Update    1.0    [ List Files ] [ Delete ]
4.    SMF 1.0.11 / 1.1.3 Update    1.1    [ List Files ] [ Delete ]
5.    SMF 1.0.13 / 1.1.5 / 2.0 b3.1 Update    1.0    [ List Files ] [ Delete ]
6.    SMF 1.0.13 / 1.1.5 / 2.0 b3.1 Update    1.0    [ List Files ] [ Delete ]
7.    SMF 1.0.13 / 1.1.5 / 2.0 b3.1 Update    1.0    [ List Files ] [ Delete ]
8.    Global Headers Footers    1.3    [ Uninstall ] [ List Files ] [ Delete ]
9.    Paid Subscriptions    0.18    [ Uninstall ] [ List Files ] [ Delete ]
10.    Tagging System    1.0.5    [ Uninstall ] [ List Files ] [ Delete ]
11.    TinyPortal    1.052    [ Uninstall ] [ List Files ] [ Delete ]
12.    SMF 1.0.14 / 1.1.6 Update    1.0    [ Uninstall ] [ List Files ] [ Delete ]
13.    SMF Sitemap    1.2.2    [ Uninstall ] [ List Files ] [ Delete ]
14.    Admin Notepad    1.0    [ Uninstall ] [ List Files ] [ Delete ]
15.    SMF Gallery Pro    1.4.0.3    [ Uninstall ] [ List Files ] [ Delete ]
16.    Newsletter Pro    1.0.2    [ Uninstall ] [ List Files ] [ Delete ]
17.    Drafts (for 1.1.x)    1.08    [ Uninstall ] [ List Files ] [ Delete ]
18.    Bookmarks    2.2.1    [ Apply Mod ] [ List Files ] [ Delete ]

And thanks.  :)

trailmyx

Hmm, well my theory was wrong in your case.  For the index.template.php section of the bookmarks11.xml file of the mod package it looks for two changes, and both of the places in your index.template.php have not been corrupted by another package.  So I don't see a reason why this section would fail for you.  You seem to have a different problem than I did.

Thanks for posting your index.template.php file, that helped me check that for you easily.

Unfortunately, I'm pretty new to this and have already spent all my silver bullets... :)  It's time for a PRO to help ya.  heh


Advertisement: