News:

SMF 2.0.19 has been released! Please update. Read more.

Main Menu

Bookmarks

Started by Matthew K., July 16, 2007, 01:07:24 PM

Previous topic - Next topic

DocPixel

I appreciate your time and effort, Trailmyx, and learned some stuff too. You obviously know a lot!

I hope Aäron will have time soon to take a look.  ;)

Forte

There's a problem with mine for some reason. No one is able to access it, and it gives the error message that they're not allowed to have bookmarks, but there's no permissions for it in either the database or on the forums. Is something supposed to be changed somewhere else?

Frozt

Quote from: Forte on October 22, 2008, 03:45:25 PM
There's a problem with mine for some reason. No one is able to access it, and it gives the error message that they're not allowed to have bookmarks, but there's no permissions for it in either the database or on the forums. Is something supposed to be changed somewhere else?

see this for see if why show that error:

http://www.simplemachines.org/community/index.php?topic=182923.msg1757032#msg1757032

Forte

Must not be the problem, it's correct in mine.

Armin2008

#364
I got a problem with this mod. The problem is it wont show the link for the bookmark. Is there a settings option that i have to enable? if so where is it. I looked everywhere for it.

I am using SMF 1.7, and these mods:

Quote1.     Bookmarks      2.2.1       [ Uninstall ]  [ List Files ]  [ Delete ]
2.    SMFShop    3.0    [ Uninstall ] [ List Files ] [ Delete ]
3.    nneonneo's AJAX ShoutBox    1.21    [ Uninstall ] [ List Files ] [ Delete ]
4.    Limit A Guests Daily PageViews Mod    1.0    [ Uninstall ] [ List Files ] [ Delete ]
5.    Member Color Link    3.0.5a    [ Uninstall ] [ List Files ] [ Delete ]
6.    Auto Embed Video/Audio Clips    4.0.2    [ Uninstall ] [ List Files ] [ Delete ]

efil59

Hi,
After I upgrade to 1.1.7 the mod is not working.
Thanks,
Efil.

Sudhakar Arjunan

As i could see many reported here,

Error Log, No one could use bookmark.

http://sitename.com/index.php?action=bookmarks
Apply Filter: Only show the errors with the same message
Database Error: Unknown column 'b.member_groups' in 'where clause'
Apply Filter: Only show the errors from this file
File: /home/sitename/public_html/forum/Sources/Bookmarks.php
Line: 70

I have compared with this post http://www.simplemachines.org/community/index.php?topic=182923.msg1760818#msg1760818 ,

And found the codes are different in our 2.0. beta 4 .

here the sample line which is there in our file.


Line 62 to 70 :

bm.id_member = {int:current_member}' . (!$modSettings['postmod_active'] || allowedTo('approve_posts') ? '' : '
AND (t.approved = {int:is_approved} OR t.id_member_started = {int:current_member})') . '
AND {query_see_board}
ORDER BY t.id_last_msg DESC',
array(
'current_member' => $user_info['id'],
'is_approved' => 1,
)
);


Any suggestions for it.
Working on New Mods & Themes for SMF... Will update soon... My Blog page
My Smf forum : Discuss ITAcumens :: My SMF Forum

Carlos Gandra

Hi,

Can someone help me with this?
http://www.simplemachines.org/community/index.php?topic=274716.0

That's a conflict between Pretty URLs and Bookmarks :)

Thanks
Carlos Gandra
Mundo dos Animais

tk2012

Quote from: A.SK on November 15, 2008, 11:50:42 PM
As i could see many reported here,

Error Log, No one could use bookmark.

http://sitename.com/index.php?action=bookmarks
Apply Filter: Only show the errors with the same message
Database Error: Unknown column 'b.member_groups' in 'where clause'
Apply Filter: Only show the errors from this file
File: /home/sitename/public_html/forum/Sources/Bookmarks.php
Line: 70

I have compared with this post http://www.simplemachines.org/community/index.php?topic=182923.msg1760818#msg1760818 ,

And found the codes are different in our 2.0. beta 4 .

here the sample line which is there in our file.


Line 62 to 70 :

bm.id_member = {int:current_member}' . (!$modSettings['postmod_active'] || allowedTo('approve_posts') ? '' : '
AND (t.approved = {int:is_approved} OR t.id_member_started = {int:current_member})') . '
AND {query_see_board}
ORDER BY t.id_last_msg DESC',
array(
'current_member' => $user_info['id'],
'is_approved' => 1,
)
);


Any suggestions for it.

I just got this same error on my forum as well.  I'm not sure how to correct.

tk2012

@ A.SK

Are you still getting the database errors for this modification that you posted?  I'm getting at least 3 or 4 a week with the same info posted above.

Sudhakar Arjunan

Quote from: tk2012 on November 28, 2008, 12:47:37 PM
@ A.SK

Are you still getting the database errors for this modification that you posted?  I'm getting at least 3 or 4 a week with the same info posted above.

Yes i am still getting. Even permission were there, all users were getting this issue on clicking the My Bookmarks from menu.
Working on New Mods & Themes for SMF... Will update soon... My Blog page
My Smf forum : Discuss ITAcumens :: My SMF Forum

netoya

I use a modified theme based on a classic theme, so i cant manualy modify files index.template.php and Display.template.php becouse they dont contain code to find.  :(
Quoteindex.template.php
    Find:



       if (in_array($context['current_action'], array('search',
    Add After:


    'bookmarks',

    Find:



       // The [calendar]!
    Add Before:


        // The [bookmarks] button
       if (allowedTo('make_bookmarks'))
          echo ($current_action == 'bookmarks' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
                <td valign="top" class="maintab_' , $current_action == 'bookmarks' ? 'active_back' : 'back' , '">
                   <a href="', $scripturl, '?action=bookmarks">' , $txt['bookmarks'] , '</a>
                </td>' , $current_action == 'bookmarks' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';


    Display.template.php
    Find:


          'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
    Add After:


          'bookmark' => array('test' => 'can_make_bookmarks', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),

my files attached

tripl3r

I can only seem to view the bookmark section on my admin account no other, why is this?

AlenNS

You need to add permissions for other membergroups.

tripl3r

Thank you buddy i couldnt seem to find it in there before but have now, cheers for your time

AlenNS


willerby

I installed this mod on v2.0 b4 today and struggled as to why the 'Add Bookmark' link did not appear in the topic menu. As admin the permissions were automatically set so nothing to do with them.

It turns out that I use the default and custom themes with images instead of text links and the Display.Template.php changes crucially have a missing image tag as follows:

'bookmark' => array('test' => 'can_make_bookmarks', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),

should read...

'bookmark' => array('test' => 'can_make_bookmarks', 'text' => 'bookmark_add', , 'image' => 'add_bookmark.gif',  'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),


You will also need to add a suitble image gif file named 'add_bookmark.gif' into ...Themes/<Theme Name>/images/english folder (or other language as appropriate)


Then it works!!!   :)
What type of washing machine is September?

An autumnatic. :)

Whimsical

Have just installed this on v1.1.7 and works great

Thank you! :)

Dr Web

I've tried to install this MOD on a 1.1.5 SMF forum and I've got this error below.

3.     Execute Modification     ./Sources/ManagePermissions.php     Test failed

All the rest was successful, what can I do to install this successfully?

Thanks for any help.
Never approach a bull from the front, a horse from the rear, or an idiot from any direction ;D

Jackson Cage

Quote from: AlenNS on December 11, 2008, 11:09:37 AM
You need to add permissions for other membergroups.

Where is that option. I can't seem to find it in the permissions.

Advertisement: