• Welcome to Simple Machines Community Forum. Please login or sign up.
January 16, 2022, 05:35:03 PM

News:

SMF 2.0.19 has been released! Please update. Read more.


Bookmarks

Started by Matthew K., July 16, 2007, 01:07:24 PM

Previous topic - Next topic

floridaflatlander

I installed this mod today on my forum and it works like a charm for me.

However when I log in as a test member I don't see the add bookmark link beside the reply link. I've looked to see if there is a setting somewhere that I need to click and can't find one.

Can someone point me in the right direction?

Thanks

Kindred

smf admin > members > permissions
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

floridaflatlander

Duh! I swear I looked there.

Thanks

abugbeary

How do you install this on your forum? Like Create a Forum?

Kindred

if you have access to the package manager, you install it there.

If you are using a free-forum-host, they probably have disabled the package manager and you will not be able to install ANY mods.
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

floridaflatlander

When checking that everything is up todate today I noticed on my package manager that the version says 2.5. But my zip file down load dated 8/20/12 says 2.5.1. Does the mod list as 2.5 in the package manager or am I doing something wrong?

Love this mod, thanks for it, I wish it was standard.

Matthew K.

2.5.1 is a newer version than 2.5, the zero is assumed (2.5.0)

I still have to completely rewrite this at some point, it has a lot of potential for sure.

Nvb

January 02, 2013, 06:00:17 PM #787 Last Edit: January 02, 2013, 06:13:15 PM by Yoshi2889
Quote from: cloksin on November 18, 2011, 07:04:36 AM
This is a link to the latest version, version 2.4

http://custom.simplemachines.org/mods/index.php?mod=864

I looked at the package-info.xml file which lists the versions of smf it is compatible with, here is what it has.

<install for="2.0 Beta 3, 2.0 Beta 3 Public, 2.0 Beta 3.1, 2.0 Beta 3.1 Public, 2.0 Beta 4, 2.0 Beta 4 Public, 2.0 RC1, 2.0 RC2, 2.0 RC3, 2.0 - 2.0.99">

so you have three options, the more advanced option is to extract that file from the zip file, add 2.0 RC5 to that list, then zip it back into the package, you would then be able to install the package without using the emulator.

Option 2 is to emulate any of the versions listed there, I would go with RC3, so type "SMF 2.0 RC3" without the quotes into the emulator text box,

and the third option, which you'll hear a lot around here (but never really answers any questions) is to upgrade to 2.0.1.

I know from personal experience that this is not always an option, and can be an arduous task in and of itself (although it is a more stable version and lots of things were fixed in it) so I suggest option two.  Don't forget to set the emulator back to default when you are done.

I unzipped and added "2.0 RC 5" to line 9 and line 25 (install & uninstall) in the package-info.xml file.
Works like a charm on RC5 now!!

I attached the modified install file.
;)

Arantor

I'm sorry, you can't distribute that file. The mod does not have a licence permitting you to do so.
No good deed goes unpunished
All helpful urges should be circumvented

Nvb

Ok, i understand, no problem.
But it's easy enough to change it yourself.

Arantor

Or use emulation to avoid having to edit anything...
No good deed goes unpunished
All helpful urges should be circumvented

Chas Large

Excellent mod thanks, can't believe it's not a part of SMF already as standard. Sooooo useful. Thanks.
My Modifications :)  My Forum

Please DO NOT PM me with support requests. Post the problem in the appropriate Support Board so everyone can benefit from the advice given.

Matthew K.

Thanks Chas, nice to see you. If it was to be part of SMF it'd have to be rewritten for sure.

HunterP

Thanks for this mod, I'm using it for over a year now. I didn't really see the need of displaying the "Bookmarks" menu button when no bookmarks are made (the majority of my members don't use this option) so I modded it to display the button only when the member has made any bookmarks. Maybe an idea for next release? :)

Arantor

How are you tracking that the user has bookmarks, exactly? You're not querying that every single page, are you?
No good deed goes unpunished
All helpful urges should be circumvented

Matthew K.

I didn't write this, Arantor. I took it over and haven't had time to rewrite it.

HunterP

Quote from: Arantor on February 03, 2013, 04:53:20 PM
How are you tracking that the user has bookmarks, exactly? You're not querying that every single page, are you?

In fact, I am...

Just before the buttons are loaded, in Subs.php :

// Let's check if this member has bookmarked any topics
$request = $smcFunc['db_query']('', '
SELECT COUNT(*)
FROM {db_prefix}bookmarks
WHERE id_member = {int:member}',
array(
'member' => $user_info['id'],
)
);
list ($bookmarks) = $smcFunc['db_fetch_row']($request);
$smcFunc['db_free_result']($request);


Button is shown on $bookmarks

I'm guessing you're seeing any disadvantages on this approach?

Arantor

Quote from: Labradoodle-360 on February 03, 2013, 04:56:55 PM
I didn't write this, Arantor. I took it over and haven't had time to rewrite it.

Um, I was asking Hunter how he did what he did... This wasn't any kind of dig at you, implied or otherwise, deserved or otherwise. I'm well aware that it wasn't originally yours.

I guess next time I need to quote what I'm replying to, eh.


QuoteI'm guessing you're seeing any disadvantages on this approach?

Performance. It hurts to have an extra query every page, often unnecessarily.

Better solution, add a column to smf_members containing the number of bookmarks, update it when the number of bookmarks changes, and as a free bonus, it'll be in $user_settings because the entire members table is loaded for the current user.
No good deed goes unpunished
All helpful urges should be circumvented

HunterP

Quote from: Arantor on February 03, 2013, 05:04:27 PM
Better solution, add a column to smf_members containing the number of bookmarks, update it when the number of bookmarks changes, and as a free bonus, it'll be in $user_settings because the entire members table is loaded for the current user.

Ok, thanks for the advice!

HunterP

Would it make any sense to put this into the $user_info array? How often does this get updated?

Advertisement: