• Welcome to Simple Machines Community Forum. Please login or sign up.
October 24, 2021, 07:59:39 PM

News:

SMF 2.1 RC4 has been released! Try it out and help us test! :) Read more.


Bookmarks

Started by Matthew K., July 16, 2007, 01:07:24 PM

Previous topic - Next topic

Ninja ZX-10RR

What was the 2.5.1 update about? I am running the 2.5 version but if I try to uninstall it it fails hard (had done many manual edits to make it compatible)... Can you tell me what strings were edited so that I can update them manually rather than spending about an hour to do so? Thanks in advance also for the mod :)
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.

♥ Jess ♥

STOP EDITING MY PROFILE

br360

I like this mod and it works great; but like a few others that mentioned it before, I wasn't a fan of having the "My Bookmarks" tab in the main menu either. I was playing around a bit, and was able to remove it from the menu, and place the link into the drop down menu in the profile link instead (see below image)

I got the idea from this mod, and just changed it up slightly- http://custom.simplemachines.org/mods/index.php?mod=3809

To remove the My Bookmarks tab from the main menu-

In sources/subs.php-

Find-                 'bookmarks' => array(
'title' => $txt['bookmarks'],
'href' => $scripturl . '?action=bookmarks',
'show' => allowedTo('make_bookmarks'),
'sub_buttons' => array(
),
),
'calendar' => array(
'title' => $txt['calendar'],
'href' => $scripturl . '?action=calendar',
'show' => $context['allow_calendar'],


Replace with: 'calendar' => array(
'title' => $txt['calendar'],
'href' => $scripturl . '?action=calendar',
'show' => $context['allow_calendar'],


To place the My Bookmarks tab into the profile drop down menu-

Also in sources/subs.php-

Find:
'profile' => array(
'title' => $txt['forumprofile'],
'href' => $scripturl . '?action=profile;area=forumprofile',
'show' => allowedTo(array('profile_extra_any', 'profile_extra_own')),
'is_last' => true,
),


Replace:
profile' => array(
'title' => $txt['forumprofile'],
'href' => $scripturl . '?action=profile;area=forumprofile',
'show' => allowedTo(array('profile_extra_any', 'profile_extra_own')),
// moved down to next sub button:'is_last' => true,
),
// [Bookmarks] button
'bookmarks' => array(
                 'title' => $txt['bookmarks'],
                 'href' => $scripturl . '?action=bookmarks',
                 'show' => allowedTo('make_bookmarks'),


Result-


Ninja ZX-10RR

You know what? Thanks! I had never thought about it before but it looks better to me, I'll do that later :D good job!
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.

♥ Jess ♥

STOP EDITING MY PROFILE

br360

Thanks man. You're welcome. :)

Kindred

I usually drop the link as an icon into the usercp mod...
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

br360

It was actually your comments on this topic that got me interested in trying to move the link into the profile section. I originally looked at the usercp mod, but I had to emulate to 2.0 beta 4 to get it to install, and that just seemed way too old for me to want to mess with. ;)

Ninja ZX-10RR

Quote from: br360 on October 01, 2014, 05:33:32 PM
Replace:
profile' => array(
'title' => $txt['forumprofile'],
'href' => $scripturl . '?action=profile;area=forumprofile',
'show' => allowedTo(array('profile_extra_any', 'profile_extra_own')),
// moved down to next sub button:'is_last' => true,
),
// [Bookmarks] button
'bookmarks' => array(
                 'title' => $txt['bookmarks'],
                 'href' => $scripturl . '?action=bookmarks',
                 'show' => allowedTo('make_bookmarks'),

You missed an " ' " at the very beginning ;) should have been 'profile' => array(
'title' => $txt['forumprofile'],
'href' => $scripturl . '?action=profile;area=forumprofile',
'show' => allowedTo(array('profile_extra_any', 'profile_extra_own')),
// moved down to next sub button:'is_last' => true,
),
// [Bookmarks] button
'bookmarks' => array(
                 'title' => $txt['bookmarks'],
                 'href' => $scripturl . '?action=bookmarks',
                 'show' => allowedTo('make_bookmarks'),
:)

Messing around a little bit more I managed to get it to work even with the "Better profile menu" mod by Dougiefresh :) still thank you again for this, it looks faraway better now.
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.

♥ Jess ♥

STOP EDITING MY PROFILE

Livaco

Hi, i saw the bookmarks addon yesterday and decided to download it. i did everything and now ive got errors for dayz. First is their is no "add bookmark" button at the bottom of eatch page like theirs ment to be and after that i goto the "My bookmarks" tab and get this Table 'a4956603_smf.smf_bookmarks' doesn't exist
File: /home/a4956603/public_html/Sources/Bookmarks.php
Line: 88

Also ive got all of this in my errors list Apply Filter: Only show the error messages of this member Livaco
Apply Filter: Only show the error messages of this IP address 81.147.189.4 
  Reverse chronological order of list Today at 10:09:08 PM
Apply Filter: Only show the error messages of this session 6a74a9aa0d397e98efa010036b2dcb3c
Apply Filter: Only show the errors of this type Type of error: Database
Apply Filter: Only show the error messages of this URL
http://forums-advancedgmod.net84.net/index.php?action=bookmarks
Apply Filter: Only show the errors with the same message
Database Error: Table 'a4956603_smf.smf_bookmarks' doesn't exist


SELECT
t.id_topic, t.num_replies, t.locked, t.num_views, t.id_board, b.name AS board_name,
IFNULL(lt.id_msg, IFNULL(lmr.id_msg, -1)) + 1 AS new_from,
t.id_last_msg, ml.poster_time AS last_poster_time,
ml.id_msg_modified, ml.subject AS last_subject, ml.icon AS last_icon,
ml.poster_name AS last_member_name, ml.id_member AS last_id_member,
IFNULL(meml.real_name, ml.poster_name) AS last_display_name, t.id_first_msg,
mf.poster_time AS first_poster_time, mf.subject AS first_subject, mf.icon AS first_icon,
mf.poster_name AS first_member_name, mf.id_member AS first_id_member,
IFNULL(memf.real_name, mf.poster_name) AS first_display_name
FROM smf_bookmarks AS bm
INNER JOIN smf_topics AS t ON (bm.id_topic = t.id_topic)
INNER JOIN smf_boards AS b ON (t.id_board = b.id_board)
INNER JOIN smf_messages AS ml ON (ml.id_msg = t.id_last_msg)
INNER JOIN smf_messages AS mf ON (mf.id_msg = t.id_first_msg)
LEFT JOIN smf_members AS meml ON (meml.id_member = ml.id_member)
LEFT JOIN smf_members AS memf ON (memf.id_member = mf.id_member)
LEFT JOIN smf_log_topics AS lt ON (lt.id_topic = t.id_topic AND lt.id_member = 1)
LEFT JOIN smf_log_mark_read AS lmr ON (lmr.id_board = t.id_board AND lmr.id_member = 1)
WHERE
bm.id_member = 1
AND 1=1
ORDER BY t.id_last_msg DESC
Apply Filter: Only show the errors from this file
File: /home/a4956603/public_html/Sources/Bookmarks.php
Line: 88
Apply Filter: Only show the error messages of this member Livaco
Apply Filter: Only show the error messages of this IP address 81.147.189.4 
  Reverse chronological order of list Today at 09:56:47 PM
Apply Filter: Only show the error messages of this session 6a74a9aa0d397e98efa010036b2dcb3c
Apply Filter: Only show the errors of this type Type of error: Database
Apply Filter: Only show the error messages of this URL
http://forums-advancedgmod.net84.net/index.php?action=bookmarks
Apply Filter: Only show the errors with the same message
Database Error: Table 'a4956603_smf.smf_bookmarks' doesn't exist


SELECT
t.id_topic, t.num_replies, t.locked, t.num_views, t.id_board, b.name AS board_name,
IFNULL(lt.id_msg, IFNULL(lmr.id_msg, -1)) + 1 AS new_from,
t.id_last_msg, ml.poster_time AS last_poster_time,
ml.id_msg_modified, ml.subject AS last_subject, ml.icon AS last_icon,
ml.poster_name AS last_member_name, ml.id_member AS last_id_member,
IFNULL(meml.real_name, ml.poster_name) AS last_display_name, t.id_first_msg,
mf.poster_time AS first_poster_time, mf.subject AS first_subject, mf.icon AS first_icon,
mf.poster_name AS first_member_name, mf.id_member AS first_id_member,
IFNULL(memf.real_name, mf.poster_name) AS first_display_name
FROM smf_bookmarks AS bm
INNER JOIN smf_topics AS t ON (bm.id_topic = t.id_topic)
INNER JOIN smf_boards AS b ON (t.id_board = b.id_board)
INNER JOIN smf_messages AS ml ON (ml.id_msg = t.id_last_msg)
INNER JOIN smf_messages AS mf ON (mf.id_msg = t.id_first_msg)
LEFT JOIN smf_members AS meml ON (meml.id_member = ml.id_member)
LEFT JOIN smf_members AS memf ON (memf.id_member = mf.id_member)
LEFT JOIN smf_log_topics AS lt ON (lt.id_topic = t.id_topic AND lt.id_member = 1)
LEFT JOIN smf_log_mark_read AS lmr ON (lmr.id_board = t.id_board AND lmr.id_member = 1)
WHERE
bm.id_member = 1
AND 1=1
ORDER BY t.id_last_msg DESC
Apply Filter: Only show the errors from this file
File: /home/a4956603/public_html/Sources/Bookmarks.php
Line: 88
Apply Filter: Only show the error messages of this member Guest
Apply Filter: Only show the error messages of this IP address 77.247.94.130 
  Reverse chronological order of list Today at 09:49:20 PM
Apply Filter: Only show the error messages of this session db908b323a60857b4cd2dc405e3ff783
Apply Filter: Only show the errors of this type Type of error: Undefined
Apply Filter: Only show the error messages of this URL
http://forums-advancedgmod.net84.net/index.php?http://forums-advancedgmod.net84.net/
Apply Filter: Only show the errors with the same message
8: Undefined index: bookmarks
Apply Filter: Only show the errors from this file
File: /home/a4956603/public_html/Sources/Subs.php
Line: 4039
Apply Filter: Only show the error messages of this member Guest
Apply Filter: Only show the error messages of this IP address 104.43.11.145 
  Reverse chronological order of list Today at 09:47:13 PM
Apply Filter: Only show the error messages of this session 44145d485370548794461ec96b7b8c2d
Apply Filter: Only show the errors of this type Type of error: Undefined
Apply Filter: Only show the error messages of this URL
http://forums-advancedgmod.net84.net/index.php?http://forums-advancedgmod.net84.net/
Apply Filter: Only show the errors with the same message
8: Undefined index: bookmarks
Apply Filter: Only show the errors from this file
File: /home/a4956603/public_html/Sources/Subs.php
Line: 4039
Apply Filter: Only show the error messages of this member Guest
Apply Filter: Only show the error messages of this IP address 52.7.135.25 
  Reverse chronological order of list Today at 09:42:27 PM
Apply Filter: Only show the error messages of this session 65588f7e2f79a3a26004479854561e95
Apply Filter: Only show the errors of this type Type of error: Undefined
Apply Filter: Only show the error messages of this URL
http://forums-advancedgmod.net84.net/index.php?http://forums-advancedgmod.net84.net/
Apply Filter: Only show the errors with the same message
8: Undefined index: bookmarks
Apply Filter: Only show the errors from this file
File: /home/a4956603/public_html/Sources/Subs.php
Line: 4039
Apply Filter: Only show the error messages of this member Guest
Apply Filter: Only show the error messages of this IP address 54.85.207.253 
  Reverse chronological order of list Today at 09:41:34 PM
Apply Filter: Only show the error messages of this session 6ae1bf28ff778e318f4412e9fae91582
Apply Filter: Only show the errors of this type Type of error: Undefined
Apply Filter: Only show the error messages of this URL
http://forums-advancedgmod.net84.net/index.php?http://forums-advancedgmod.net84.net/
Apply Filter: Only show the errors with the same message
8: Undefined index: bookmarks
Apply Filter: Only show the errors from this file
File: /home/a4956603/public_html/Sources/Subs.php
Line: 4039
Apply Filter: Only show the error messages of this member Guest
Apply Filter: Only show the error messages of this IP address 104.197.69.104 
  Reverse chronological order of list Today at 09:40:13 PM
Apply Filter: Only show the error messages of this session 1ef8ee04891fcfcef3a02661677e0f0e
Apply Filter: Only show the errors of this type Type of error: Undefined
Apply Filter: Only show the error messages of this URL
http://forums-advancedgmod.net84.net/index.php?http://forums-advancedgmod.net84.net/
Apply Filter: Only show the errors with the same message
8: Undefined index: bookmarks
Apply Filter: Only show the errors from this file
File: /home/a4956603/public_html/Sources/Subs.php
Line: 4039
Apply Filter: Only show the error messages of this member Livaco
Apply Filter: Only show the error messages of this IP address 81.147.189.4 
  Reverse chronological order of list Today at 09:38:50 PM
Apply Filter: Only show the error messages of this session 6a74a9aa0d397e98efa010036b2dcb3c
Apply Filter: Only show the errors of this type Type of error: Undefined
Apply Filter: Only show the error messages of this URL
http://forums-advancedgmod.net84.net/index.php?
Apply Filter: Only show the errors with the same message
8: Undefined index: bookmarks
Apply Filter: Only show the errors from this file
File: /home/a4956603/public_html/Sources/Subs.php
Line: 4039
Apply Filter: Only show the error messages of this member Livaco
Apply Filter: Only show the error messages of this IP address 81.147.189.4 
  Reverse chronological order of list Today at 09:38:39 PM
Apply Filter: Only show the error messages of this session 6a74a9aa0d397e98efa010036b2dcb3c
Apply Filter: Only show the errors of this type Type of error: General
Apply Filter: Only show the error messages of this URL
http://forums-advancedgmod.net84.net/index.php?action=bookmarks
Apply Filter: Only show the errors with the same message
2: require_once(/home/a4956603/public_html/Sources/Bookmarks.php) [<a href='function.require-once'>function.require-once</a>]: failed to open stream: No such file or directory
Apply Filter: Only show the errors from this file
File: /home/a4956603/public_html/index.php
Line: 360
Apply Filter: Only show the error messages of this member Livaco
Apply Filter: Only show the error messages of this IP address 81.147.189.4 
  Reverse chronological order of list Today at 09:38:26 PM
Apply Filter: Only show the error messages of this session 6a74a9aa0d397e98efa010036b2dcb3c
Apply Filter: Only show the errors of this type Type of error: Undefined
Apply Filter: Only show the error messages of this URL
http://forums-advancedgmod.net84.net/index.php?/board,2.0.html
Apply Filter: Only show the errors with the same message
8: Undefined index: bookmarks
Apply Filter: Only show the errors from this file
File: /home/a4956603/public_html/Sources/Subs.php
Line: 4039


Help please

Kindred

it would seem that the mod was not fully installed.

did you have errors during the installation?   Did you ignore those errors? (if so, naughty)

did you attempt to manually install the mod? If so, I suspect that you did not complete the installation of code in all your themes and you almost certainly did not complete the database portion.
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Livaco

I had a install.php but didint know what do to with it as i allredy installed all the other files, plus when i added it and typed in "http://forums-advancedgmod.net84.net/install.php" it came up with agein another error. plus the codes where theirs "this code is not vital to the installation"

Kindred

Why did you manually install the mod?   You should have used the package manager...

basically, you appear to have made only some of the code changes *AND* you have not created the database tables.
if you READ the manual parse information
Quote
smf20/install.php
This file should not be able to execute standalone. You may have to run the following queries manually.
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Livaco

May 26, 2015, 04:24:38 PM #891 Last Edit: May 26, 2015, 04:37:31 PM by Livaco
how do i use pagage maniger? i have no idea what to do with the "install.php"

EDIT: If You Need What Im Getting Im Image Forum Here:





Kindred

Well,  why did you attempt to manually install the mod?   That's what the package manager is for... Autoinstalling modsread the manual/wiki to learn about what the package manager is... It's a standard part of th smf admin tools.

You should restore the backup that you took before you attempted to install the mod and then use the package manager toninstall the mod correctly.

As for running install.php, as the quote I posted says, it probably won't run.. You have to MANUALLY apply the SQL statements.
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Livaco

Quote from: Kindred on May 26, 2015, 06:54:14 PM
Well,  why did you attempt to manually install the mod?   That's what the package manager is for... Autoinstalling modsread the manual/wiki to learn about what the package manager is... It's a standard part of th smf admin tools.

You should restore the backup that you took before you attempted to install the mod and then use the package manager toninstall the mod correctly.

As for running install.php, as the quote I posted says, it probably won't run.. You have to MANUALLY apply the SQL statements.
Il do that twomorro, its past midnight at my time and im currentley reinstalling my backup thx!

shawnb61

One observation & one question...

Observation...
This mod will not deinstall cleanly, even on a new 2.0.10 install.  In my test vanilla forum, this mod works perfectly, it just shows the error upon deinstall.  See screenshot below. 

Question...   
I also have the problem where the "Add Bookmark" link does not show up.  If anyone else has found a solution to this, I'd appreciate it.   Forum users have recently asked for a bookmark feature, so I'd like to get this working.

Lots of history...  I recently started helping out my forum...   It has had Bookmarks. 2.3 installed, but non-operational.  Same thing, the "Add Bookmarks" link does not show up.  In my local test copy of the forum, I have deinstalled 2.3 and installed 2.5 cleanly, hoping to get it working, but the same problem appears.   The code looks like it was applied properly, the permissions look like they've been applied properly.   

Any input on where to look would be appreciated.

(The Bookmarks 2.3 de-install required some manual effort due to a conflict with Global Headers and Footers mod, which used the same line of code as Bookmarks for its search & replace...)

I admit my forum's code base is far from perfect.  It has been patched since SMF 1.1 all the way thru 2.0.10.  I see signs of old mods not fully de-installed here & there.  But the forum functions very cleanly. 
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

shawnb61

Here's a big clue...   

The 'Add Bookmark' button is only available if you use the default theme.  If you've changed the theme at all, e.g., to 'core', it goes away. 

I can make it fail in my vanilla environment by changing from 'curve' to 'core'.  My forum uses 'core'. 

Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

shawnb61

July 28, 2015, 01:10:15 AM #896 Last Edit: July 28, 2015, 01:21:36 AM by shawnb61
And yes... 

If you make the 'Build the Normal Button Array' in core\Display.Template.php
match the same section in  default\Display.Template.php
it appears to work. 

You have to add the 'bookmark' line between 'reply' and 'add_poll'.
I copied the line from default\ to core\.

The next question is whether this is safe practice or not. Is this what the mod's install package should have done?

This appears to make this mod work.   I'll leave it in test for a while & let you know how it goes.

Shawn

Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

shawnb61

Also, FYI, after reading it a few times...   

The de-install failure in my screenshot above should be ignored.   

For some reason, the install package tries 4 different slight variations on that particular search & replace.  It only needs one of the 4 to work.  It marks all 4 as optional.   As long as one of the 4 works, you're good.  You'll see in my screenshot that one of the 4 substitutions works.   
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

Kindred

90% of the mods will not install cleanly on core ...   mods only need to install on the default (Curve) theme to be accepted on the mod site -- any custom (non-default/curve) themes then become the responsibility of the site admin to make mods work into...

and yes... any modification to the default theme files must also be done to custom theme files (if they exist)
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Gryzor

Hello!

Been using this mod for ages now and users (some of them at least) love it... I would like to ask if it'd be possible to bookmark *posts* instead of topics/threads? This would be more useful when a discussion is long...

Advertisement: