News:

SMF 2.1.2 has been released! Take it for a spin! Read more.

Main Menu

Bookmarks

Started by Matthew K., July 16, 2007, 01:07:24 PM

Previous topic - Next topic

tk2012

I have read all 13 pages and especially read the last two pages here about 2.0 3.1.  I'm at a loss.  Does this work with 2.0 3.1 or does it not?

I got the following errors.. even when trying to get the manual edits from this site...


ccbtimewiz

It doesn't work with SMF 2.0.

tk2012

Thanks for the info.  I was just going on what was posted on the mod site saying it was compatible.  Too bad, I wanted this one.  It is a great feature which I thought would have been standard for a forum.

Oh well  :(

Aaron

Quote from: ccbtimewiz on August 12, 2008, 05:07:20 PM
It doesn't work with SMF 2.0.

It does work with SMF 2.0, actually.

tk2012, what's the exact version of SMF you're using?

ccbtimewiz

Quote from: Aäron on August 13, 2008, 12:11:30 PM
Quote from: ccbtimewiz on August 12, 2008, 05:07:20 PM
It doesn't work with SMF 2.0.

It does work with SMF 2.0, actually. What's the exact version of SMF you're using?

o_O

Then why do I keep getting a "this mod will not work for your SMF version" when I install it to a 2.0 test forum?

Aaron

#265
Quote from: ccbtimewiz on August 13, 2008, 12:13:13 PM
Then why do I keep getting a "this mod will not work for your SMF version" when I install it to a 2.0 test forum?

'Cause it wasn't compatible with 2.0 Beta 3.1 Public. Darn suffix. :P

Edit: I just uploaded a package that fixes this version number problem. :)

tk2012

Well, I'm sure it is totally unrelated, but yesterday after trying to install the package for this mod, my forum has some kind of database error.  I had just finished trying to upload when I got the error message I attached in a previous post.  Then, I went to go back to my "HOME" tab wo take me to the Index and booom.. can't get into it.  I'm sure it was just coincidence since the package never got installed.  (Can see what I'm talking about here: http://www.simplemachines.org/community/index.php?topic=255196.msg1657908#msg1657908 )

To answer your question, I'm using v2.0 b3.1 Public.  I guess they don't have an area for you guys to post your modifications if they aren't public versions, yet.  That may have helped if they did.  This way things that aren't released to the public aren't mixed with those which are.

Aaron

Totally unrelated indeed. Looks like it's your custom forms mod that's causing you those problems. Try removing it via the package manager.

justy_

Hi aaron.

i've installed the mod on our site. we have 1.1.5. Says installation was successful etc., but its not showing up on the forum. Any idea why?  We dont have any old one in....

Aaron

Yes, I have. It's been said at least ten times already, but if you're using a custom theme, you need to add the button to the bookmarks page manually. You can find instructions on how to do this on the mod's page - look for manual installation instructions. :)

justy_

okay. thank you. i apologize for a repeated question.

Aaron

No problem at all. It's my own fault, really, as I should write a FAQ where I can point people to. :)

tk2012

I decided to give it a go.  It said that it was successfully installed.  When I went to hit My Bookmarks, I got an error saying tha tthe table was not found.

I went into MyPHPadmin and sure enough, no table.   

I used the query that you posted somewhere around page 6 or so and got the following error that I am attaching:

the query was
        CREATE TABLE motorstorm-rpms_org_community_bookmarks
   (
      `ID_MEMBER` mediumint(8) unsigned NOT NULL,
      `ID_TOPIC` mediumint(8) unsigned NOT NULL,
      UNIQUE KEY `ID_MEMBER` (`ID_MEMBER`,`ID_TOPIC`)
   );


the error is below

tk2012

AHHHH!! Nevermind.. I see what I did.. I forgot to take out the dash!!!! 

ccbtimewiz

Quote from: tk2012 on August 15, 2008, 02:00:26 AM
AHHHH!! Nevermind.. I see what I did.. I forgot to take out the dash!!!! 

About to say. :P

tk2012

Hey.. go make fun of me in another thread entitled "Parse Error -- Yippee" in support for 2.0  ;)

tk2012

#276
@aaron

I did get the table created and everything was working, but when I went to try it out I got a parse error.  The error is attached in case anyone else gets this before it is fixed.

With help from someone, I was instructed to do the following which corrected the error:

Find:
// Build the normal button array.
      'bookmark' => array('test' => 'can_reply', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),
   $normal_buttons = array(
      'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),


Replace:
// Build the normal button array.
   $normal_buttons = array(
      'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
                'bookmark' => array('test' => 'can_reply', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),


Now, everything is working from what I can tell.  My forum isn't live, yet.  I'm just doing the build, so once I have people posting I'll be able to fully see the effects.  Great mod.  Been wanting this for a long time, but haven't been installing anything on my 1.1.5 site since I've been creating a new one with 2.0 3.1.

Thanks everyone!

-TK

Kimmie

#277
I got that same parse error.. so when I went and checked the display file, that code is already like that, so I am confused as to how replacing it with the same exact thing will fix it


actually, that first code isnt even in there so the initial find part doesnt do any good  (??)

this part :  'bookmark' => array('test' => 'can_reply', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']), doesnt get put in the file.


Edit: Thats not the same parse error I get. I attached the one I get. Its weird tho because when I go to look up the line of code mine shows in the error, its not even in the file..lol

Aaron

#278
Version 2.1.2 fixes the parse error problem. If you're experiencing parse errors after installing version 2.1.1, uninstall it and install 2.1.2 instead. That should fix it.

LinK187

Hi, I hope my question(s) hasn't/haven't already been answered. If they have pls just link me to the post(s). I didn't have the time to read all the pages in this thread.

I was confused by this: http://docs.simplemachines.org/index.php?topic=402.msg531#msg531

I was wondering if someone could just straight up post the exact modifications I need to put into the themes:

AA_A_New_Damage: http://custom.simplemachines.org/themes/?lemma=107

and

FanTheme: http://custom.simplemachines.org/themes/index.php?lemma=875

To make the bookmark functionality visible. I'm using SMF 1.1.5

Thx  8)

Advertisement: