1.1.4 MOVED topic broken

[Owdy]

When you move some topic, SMF cerates that 'MOVED' topic. There are 2 links, first is to board, second to topic. After upgrading 1.1.4, that feature is broken. That second link brakes.

this

Code Select Expand


[LINKKI AIHEESEEN] turns to this

Code Select Expand


[liNKKI AIHEESEEN]

Normally it turns to link.

[codenaught]

That's odd. So $txt['movetopic_auto_topic'] is set to the proper one for your language? When the text is first inserted into the textbox it is right but when it is submitted it is breaks and does not get changed into a link?

[Owdy]

When the text is first inserted into the textbox it is right but when it is submitted it is breaks and does not get changed into a link?

Yes. This happens in 2 sites.

[Owdy]

Hmmm, it doesnt do that with English... Has something changed?

Finnish

Code Select Expand

$txt['movetopic_auto_board'] = '[ALUE]';
$txt['movetopic_auto_topic'] = '[LINKKI AIHEESEEN]';
$txt['movetopic_default'] = 'Tämä aihe on siirretty alueelle ' . $txt['movetopic_auto_board'] . ".\n\n" . $txt['movetopic_auto_topic'];


English

Code Select Expand

$txt['movetopic_auto_board'] = '[BOARD]';
$txt['movetopic_auto_topic'] = '[TOPIC LINK]';
$txt['movetopic_default'] = 'This topic has been moved to ' .$txt['movetopic_auto_board'] . ".\n\n" . $txt['movetopic_auto_topic'];

[Tonilind]

Is this issue still unsolved? It's very frustrating to modify each "moved topic" manually. :-( There must be several Finnish SMF 1.1.4 admins already wondering what is causing the problem and how to fix it.

I can confirm that this problem appeared after upgrading to v1.1.4 (and only with Finnish language pack, not with English).

Hopefully this can be solved soon (thanks in advance!).

[Owdy]

Is this issue still unsolved?

Yes its seems. Have any other language have this problem? That lang string is fine, it cant be that. Its been working fine untill now (1.1.4).

[SleePy]

Owdy, does it work if you use the english versions only for this:

Code Select Expand

$txt['movetopic_auto_board'] = '[BOARD]';
$txt['movetopic_auto_topic'] = '[TOPIC LINK]';

I would have to peak tomorrow or sometime, I don't know how the replacement is done but I wonder if its messing up.

[Owdy]

If i change only this, it works

Code Select Expand

$txt['movetopic_auto_topic'] = '[TOPIC LINK]';

[SleePy]

So even the board link is correct and works?

I just opened the MoveTopic.php file quickly and that wouldn't make sense

Code Select Expand

// Should be in the boardwide language.
if ($user_info['language'] != $language)
loadLanguage('index', $language);

$_POST['reason'] = $func['htmlspecialchars']($_POST['reason'], ENT_QUOTES);
preparsecode($_POST['reason']);

// Add a URL onto the message.
$_POST['reason'] = strtr($_POST['reason'], array(
$txt['movetopic_auto_board'] => '[url=' . $scripturl . '?board=' . $_POST['toboard'] . ']' . addslashes($board_name) . '[/url]',
$txt['movetopic_auto_topic'] => '[iurl]' . $scripturl . '?topic=' . $topic . '.0[/iurl]'
));

I wonder if preparsecode is causing this..
Try to edit the code and comment it out.

[Owdy]

So even the board link is correct and works?

Board link is fine, only topic link is broken.

If i comment this out, it brakes it same way

Code Select Expand

$txt['movetopic_auto_topic'] => '[iurl]' . $scripturl . '?topic=' . $topic . '.0[/iurl]'

[SleePy]

Well of course it will break That part should be translating it..

I can try to figure this out tomorrow (but I should be getting my new computer so most likely will forget).
But what we can attempt to do is either comment out the redirectexits, then have it echo that text string (to see if its in english or not) or have it log an error quickly with that error string to see what language it is in.
I am thinking its in English for some reason.

[Owdy]

log an error quickly with that error string to see what language it is in.
I am thinking its in English for some reason.

Finnish is unchanged.

[SleePy]

Owdy,
Are you able to reproduce this, with newer versions?

[Owdy]

1.1.4 is latest version

[SleePy]

I meant latest version of 2.0

[Owdy]

I meant latest version of 2.0

Is there Finnish lang files for 2.0? I dont translate those anymore, its Niko's job now.

This is weird, because 1.1.3 worked, 1.1.4 dont.

[SleePy]

Does it work in the test board here?
I wonder.

If you open the MoveTopic.php

Find:

Code Select Expand

preparsecode($_POST['reason']);

And add after:

Code Select Expand

exit $_POST['reason'];

Then submit this. What does the code look like? I am thinking that the clean up is doing this.

[Owdy]

Code Select Expand

Parse error: syntax error, unexpected T_VARIABLE in /var/www/public_html/foorumi/Sources/MoveTopic.php on line 232

[SleePy]

Code Select Expand

exit ($_POST['reason']);


I swear exit was a language construct.. But this should just be dumping what the output is before it gets replaced.. Which seems to be the issue.

[Owdy]

Tämä aihe on siirretty alueelle [ALUE].

[liNKKI AIHEESEEN]

That is wrong. Those first 2 letters in that topic string are wrong. It should be 'LINKKI AIHEESEEN'.