News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

Post and PM Inline Attachments

Started by dougiefresh, July 26, 2014, 09:14:08 PM

Previous topic - Next topic

Sebastiii

Quote from: GL700Wing on May 08, 2022, 07:13:55 AMThat looks like a PrettyURLs issue to me ...
Maybe, but I don't think so, I will disable it and see if the error is present.
In fact, after disabling the eval settings from @Arantor advice, I'm getting the error about "Custom fields and filters of post" mod, line 3942 :

3922:                    {
3923:                        case 'chart_average':
3924:                        {
3925:                            echo '
3926:        ', $txt['cffp_show_stats_summary_min'], ': ', comma_format($stats['min_num'], $stats['min_num'] == (int) $stats['min_num'] ? 0 : 1), '<br />
3927:        ', $txt['cffp_show_stats_summary_average'], ': ', comma_format($stats['average'], 1), '<br />
3928:        ', $txt['cffp_show_stats_summary_max'], ': ', comma_format($stats['max_num'], $stats['max_num'] == (int) $stats['max_num'] ? 0 : 1), '<br />';
3929:   
3930:                            if (!empty($stats['options_text']) && $stats['chart_average']['options_text'])
3931:                                echo implode('
3932:        <br />', $stats['options_text']), '<br />';
3933:   
3934:                            echo '
3935:        <br />';
3936:                            break;
3937:                        }
3938:                        case 'chart_hbars':
3939:                        case 'chart_vbars':
3940:                        {
3941:                            if ($chart_hvbars)
==>3942:                                continue;
3943:   
3944:                            foreach ($stats['data'] as $value_data)
3945:                                echo '
3946:        ', $value_data['text'], ': ', comma_format($value_data['num']), ' (', comma_format($value_data['percent'], 1), '%)<br />';
3947:   
3948:                            echo '
3949:        <br />';
3950:   
3951:                            $chart_hvbars = true;
3952:                            break;
3953:                        }
3954:                        case 'summary':
3955:                        {
3956:                            foreach ($stats['summary'] as $k => $summary)
3957:                            {
3958:                                if (in_array($k, array('average', 'sum')))
3959:                                    $summary[1] = comma_format($summary[1], 1);
3960:                                elseif ('total' == $k)
3961:                                    $summary[1] = comma_format($summary[1]);
3962:   

https://www.****.com/forum/index.php?action=unread
2: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?
Fichier: /home/attrapes/public_html/forum/Themes/default/CustomFieldFilterPost.template.php
Ligne: 3942

As we can see, no PrettyURL is involved for "?action" but the mod is enabled.

QuoteWhat is the conflict/issue?
Only on one file in : ".\Themes\default\Printpage.template.php", the installation can't apply change.

QuoteYou need to install Tapatalk before this mod so if you've already installed Tapatalk you'll need to uninstall this mod and then reinstall it ...
Yes, the Tapatalk plugin is already installed and working, with the PPIA installed, it works, but image are duplicate on Tapatalk app.
In the body, message image are placed correctly but are also present at the bottom of the post, so it acts like duplicate images.

Arantor

Eval is a technique for catching certain kinds of errors without blowing up the forum - but it makes error logs misleading as you can now see.

That continue; on line 3942 really should be continue 2; as it suggests, and it would be worth telling the mod author about it so he can fix it in future.

Sebastiii

@Arantor :)
Thanks again for your help, effectively, changing it to continue 2; and no more error :D
I will post the issue into topic mod for "Custom fields and filters of post" 8)

GL700Wing

Quote from: Sebastiii on May 08, 2022, 11:00:32 AM
QuoteWhat is the conflict/issue?
Only on one file in : ".\Themes\default\Printpage.template.php", the installation can't apply change.
In this case you need to work out what code change is required and manually apply it - this is simply one of the occasional challenges that occur when installing multiple mods that update the same block of code.

Quote
QuoteYou need to install Tapatalk before this mod so if you've already installed Tapatalk you'll need to uninstall this mod and then reinstall it ...
Yes, the Tapatalk plugin is already installed and working, with the PPIA installed, it works, but image are duplicate on Tapatalk app.
In the body, message image are placed correctly but are also present at the bottom of the post, so it acts like duplicate images.
Ok - if you let me know which version of Tapatalk you're using I'll check the installation code ...
Life doesn't have to be perfect to be wonderful ...

Sebastiii

Quote from: GL700Wing on May 08, 2022, 05:56:46 PMIn this case, you need to work out what code change is required and manually apply it - this is simply one of the occasional challenges that occur when installing multiple mods that update the same block of code.
I did try, but I don't succeed, sometimes, I can rule out but here, it removed code that "CustomField" use, so not sure what to do !

QuoteOk - if you let me know which version of Tapatalk you're using, I'll check the installation code ...
Thanks, I'm using the latest for SMF 2.0.19, i.e 4.5.8 :)

GL700Wing

#985
Quote from: Sebastiii on May 09, 2022, 04:08:54 AMI did try, but I don't succeed, sometimes, I can rule out but here, it removed code that "CustomField" use, so not sure what to do !
OK - I'm working on an update that will (hopefully) support the CustomFieldFilterPost mod ...

QuoteThanks, I'm using the latest for SMF 2.0.19, i.e 4.5.8 :)
I think I have the Tapatalk issue sorted ...

I'll send you a PM when I have a new version ready for you to test  ...
Life doesn't have to be perfect to be wonderful ...

Sebastiii


GL700Wing

Version v7.07 - May 13, 2022
o SMF 2.1: Per FrizzleFried - fixed 'Undefined index: attachment' issue when viewing attachments via profile.

o As per Sebastiii and Arantor - Re-added support for PHP 5.6.

o As per Sebastiii - Point 2: Added support for printing with CustomFieldFilterPost mod.

o As per Sebastiii - Point 3: Fixed Tapatalk issue where inline attachments are also displayed below the message.

o Re-added support for the 'attachimg' ILA tag for displaying inline attachments that used this particular tag which was only included in some very early versions of the mod.

o Added option to enable suppression of the [ Invalid Attachment ] warning for missing attachments in a message (particularly useful when large numbers of attachments have gone missing from a forum). This doesn't modify the body of the message - just what is displayed when an attachment is missing: which is nothing for a missing attachment if this option is enabled!!

o Added French language support - thanks to Sebastiii.

o Other minor bug fixes.


Notes
For SMF 2.0 forums using versions 7.04, 7.05 or 7.06 there are upgrade options to version 7.07 - it is not necessary to uninstall 7.04, 7.05, or 7.06 beforehand.

For SMF 2.1 forums using version 7.06 there is an upgrade option to version 7.07 - it is not necessary to uninstall 7.06 beforehand.
Life doesn't have to be perfect to be wonderful ...

FrizzleFried

Thank you @GL700Wing for going WAAAAY beyond the call of duty in helping to get the In Line Attachments to work on my 2.0.x to 2.1.x forum!  I didn't think i'd ever get those early ILA tags to work again...

My users and I appreciate it VERY much!  You rock!

Sebastiii

Quote from: FrizzleFried on May 12, 2022, 07:06:42 PMThank you @GL700Wing for going WAAAAY beyond the call of duty in helping to get the In Line Attachments to work on my 2.0.x to 2.1.x forum!  I didn't think i'd ever get those early ILA tags to work again...

My users and I appreciate it VERY much!  You rock!
Yes, I'm totally agreed too @GL700Wing ! You rock !

GL700Wing

Version v7.08 - May 26, 2022
o Bug fix for 'Undefined index: ila_no_invalid_attachment_warning' error message.


Notes
For SMF 2.0 forums using versions 7.04, 7.05, 7.06 or 7.07 there are upgrade options to version 7.08 - it is not necessary to uninstall version 7.04, 7.05, 7.06 or 7.07 beforehand.

For SMF 2.1 forums using version 7.06 or 7.07 there is an upgrade option to version 7.08 - it is not necessary to uninstall version 7.06 or 7.07 beforehand.
Life doesn't have to be perfect to be wonderful ...

Ravey76

#991
Hello all
maybe someone here can help me:
I have installed SMF version 2.1.2 and would like to insert file attachments/images inline in an article.

When I click on "Insert" for a file attachment/image, the desired image appears within the text in the article preview. However, as soon as I click on "save", the image is no longer displayed inline - it is gone. What could be the reason for this?

Also the option "Embed SVG files within the post?" is deactivated in Admin Area (cannot be selecetd)

Thank you for your support

Karl

FrizzleFried

This is the support thread for the INLINE ATTACHMENTS MOD that originated in 2.0.x...

You are going to want to ask your question in the general SMF 2.1.x Support sub-forum... located HERE.

Ravey76

Thank you for pointing this out.
After it didn't work with the original feature, I installed this MOD - but it has the same result.

Advertisement: