SimplePortal

[aegersz]

Oh, i forgot to add this:

I can use another block to produce the right results so it's not critical - I was just curious if anyone has any thoughts on this bizarre error.

[Dave J]

It's worth noting that Simple Portal has been superseded by Eh Portal (it's basically the same thing) you can find it here and get support for it too

https://web-develop.ca/index.php?action=downloads;area=stable_eh_portal

[aegersz]

Thanks

[Sir Osis of Liver]

Should remember this, but I don't.   Has SP been updated to support php 8.0?  Getting create_function() and other mysql errors in 2.3.7.
 

[Chen Zhen]

No it hasn't..  if you're still using the SMF 2.0 branch then you can use version 2.3.8 from the beta/rc download section of SP.

If you're using SMF 2.1 branch then use EhPortal which is a ported version.

[Sir Osis of Liver]

It's a 2.0.19 forum.  I've downgraded php to 7.4, but thst's not a long term solution. 

Does EH Portal work in 2.0?  Does it inherit SP content?  Link to 2.3.8?

[Chen Zhen]

EhPortal inherits everything from SP but it's strictly for the SMF 2.1 branch.

SP 2.3.8 should work for PHP 8.3

SP 2.3.8 Link

[Sir Osis of Liver]

Don't think this guy will upgrade to 2.1, will try 2.3.8.  Thanks, Chen.

[Chen Zhen]

If you have any problems with it just report them here and I'll make adjustments to SP. Include errors from the PHP error log if it's relevant.

[Sir Osis of Liver]

Will do.  I'll try 2.3.8 tonight.

We're getting this error in 2.3.7 when adding block -

Code Select Expand


Database Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'row = row + 1
WHERE col = 1
AND row >= 5' at line 2
Apply Filter: Only show the errors from this file
File: /home/wpsvetsc/public_html/Sources/PortalAdminBlocks.php
Line: 662



Code Select Expand


                $smcFunc['db_query']('', '
                    UPDATE {db_prefix}sp_blocks
                    SET row = row + 1
                    WHERE col = {int:col}
                        AND row >= {int:start}' . (!empty($current_row) ? '
                        AND row < {int:end}' : ''),
                    array(
                        'col' => (int) $_POST['block_column'],
                        'start' => $row,
                        'end' => !empty($current_row) ? $current_row : 0,
                    )
                );



[Chen Zhen]

That is fixed in 2.3.8 ..
Sinan used "row" as a db column name which became a reserved word in MySQL.
There are a few instances of reserved words that were patched in 2.3.8.

[Sir Osis of Liver]

2.3.8 doesn't work in php 8.0.  Uninstalled 2.3.7, couple of manual edits in Load.php.  Installed 2.3.8, same edits in Load.php.  Portal crashes with this -

Code Select Expand


Fatal error: Uncaught Error: Call to undefined function create_function() in /home/wpsvetsc/public_html/Sources/PortalBlocks.php:2029 Stack trace: #0 /home/wpsvetsc/public_html/Sources/Load.php(1652) : eval()'d code(234): sp_rssFeed() #1 /home/wpsvetsc/public_html/Sources/Load.php(1652) : eval()'d code(148): template_block_curve() #2 /home/wpsvetsc/public_html/Sources/Load.php(1652) : eval()'d code(56): template_block() #3 /home/wpsvetsc/public_html/Sources/Load.php(1439): template_portal_above() #4 /home/wpsvetsc/public_html/Sources/Subs.php(3450): loadSubTemplate() #5 /home/wpsvetsc/public_html/Sources/Subs.php(2895): template_header() #6 /home/wpsvetsc/public_html/Sources/Errors.php(337): obExit() #7 /home/wpsvetsc/public_html/Sources/Errors.php(161): setup_fatal_error_context() #8 /home/wpsvetsc/public_html/index.php(131): fatal_error() #9 [internal function]: {closure}() #10 {main} thrown in /home/wpsvetsc/public_html/Sources/PortalBlocks.php on line 2029


Works in php 7.4.

[Tyrsson]

Might be because of:

https://www.php.net/manual/en/function.create-function.php

[Sir Osis of Liver]

Yes, it is, but 2.3.8 is supposed to support up to php 8.3.

SP 2.3.8 should work for PHP 8.3

[Chen Zhen]

I thought I remembered replacing those with anonymous functions already.
Anyhow, there is a newer amended file available for you at the same link.

[Sir Osis of Liver]

Installed BETA8, running fine so far in php 8.0.  Thanks again.

[Sir Osis of Liver]

Getting this error in SP 2.3.7 when clicking on block edit button -

 Call to undefined function sportal_admin_block_edit()

Wasn't happening previously.  2.0.19 in php 8.0.

[dodos26]

To fix use `row` instead row . You will need to do this with many other parts of the code where be db_query request in PortalAdminBlocks.

Code Select Expand

                $smcFunc['db_query']('', '
                    UPDATE {db_prefix}sp_blocks
                    SET row = row + 1
                    WHERE col = {int:col}
                        AND row >= {int:start}' . (!empty($current_row) ? '
                        AND row < {int:end}' : ''),
                    array(
                        'col' => (int) $_POST['block_column'],
                        'start' => $row,
                        'end' => !empty($current_row) ? $current_row : 0,
                    )
                );
You cannot view this attachment.

[Sir Osis of Liver]

Shouldn't be necessary, it was working when first installed.  Will uninstall/reinstall, see if it goes away.

[dodos26]

"ROW" is a reserved word in MySQL starting from version 8.0.3
Change row to `row`