SMF & RSS problem

[Angelotus]

Hi,

I use smf 2.0 and have search engine friendly urls enabled.

I use this script to fetch feed from the boards for another site of mine (www.klifix.eu).

The feed is fetched correctly only the link to the original post is not correct. It is always:
http://forum.weeklyfun.nl/index.php/$1.html$2

I have tried it with other scripts as well and still the same link appears.

What is the problem and how to solve this???

[Rumbaar]

If you turn off search engine friendly URLs does it change the output?

How does the 'bridge' php file extract the RSS feed?  Can it handle the type of RSS feed and links SMF outputs?

[Angelotus]

If SEF turned of the links are correct, but turned on not.

[Rumbaar]

Well you've got a choice then   Either turn off SEF (which when on doesn't really help Search Engines anyways) or fix the script you are using.

[Angelotus]

I found out it doesn't have to do anything with the script I am using, but with a bug in SMF.
http://dev.simplemachines.org/mantis/view.php?id=1790

[Rumbaar]

Ha, nice. That'll learn me not to search, but the bugtracker has always been hard for me search   You might still have to turn off SEF until the public next release.

[Angelotus]

Thanks, done that! It works fine now, so I keep it this way untill next release..

[Rumbaar]

If I knew the fix I'd post it here and the SVN has always been in the too hard basket for me to look at or learn   Hopefully the next release will be soon.

[I]

If I knew the fix I'd post it here and the SVN has always been in the too hard basket for me to look at or learn   Hopefully the next release will be soon.

I did NOT want to wait for beta 4 when it should be fixed...
AND I did NOT want to turn off search engine friendly urls...
So here is what I did...

WARNING, try this at your own risk!

Since this is only a problem with my RSS news feeds, I took a look at:

Sources/News.php
function fix_possible_url
(Line 355) I found this...

Code Select Expand

$val = preg_replace('/^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+)(#[^"]*)?$/e', '\'\' . \$scripturl . \'/\' . strtr(\'\$1\', \'&;=\', \'//,\') . \'.html\$2\'', $val);



I compared this with the same code from the SMF 1-1-4 load (line 330):

Code Select Expand

$val = preg_replace('/^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+)(#[^"]*)?$/e', "'' . \$scripturl . '/' . strtr('\$1', '&;=', '//,') . '.html\$2'", $val);


The main difference is the 1-1-4 code uses double quotes which allows $1 and $2 to be considered as variables instead of literals.  Hence $1.html$2 is replaced with the content of $1 and $2

I replaced the one line in the 2.0b3 code with the one line from the 1-1-4 code and it works!

USE AT YOUR OWN RISK!

[Angelotus]

I'll try that out! Thanks for sharing your thoughts with us!

[I]

I'll try that out! Thanks for sharing your thoughts with us!

No problem!  This works fine with my site, but I am not using your ticker.  If you have any problems, let me know cause I have a site coming up and I am thinking of using the ticker you are using to promote the SMF links - looks interesting!

[metallica48423]

the fix that was done between revisions 7041 and 7042 to fix this error is as follows

Code (Find in /Sources/News.php) Select Expand

$val = preg_replace('/^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+)(#[^"]*)?$/e', '\'\' . \$scripturl . \'/\' . strtr(\'\$1\', \'&;=\', \'//,\') . \'.html\$2\'', $val);

Code (Replace with) Select Expand

$val = preg_replace('/^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+)(#[^"]*)?$/e', '\'\' . $scripturl . \'/\' . strtr(\'$1\', \'&;=\', \'//,\') . \'.html$2\'', $val);

And...

Code (Find in /Sources/Themes.php) Select Expand

$old_template = preg_replace('~\<\?php(.*)\?\>~es', 'phpcodefix(\'\$1\')', $old_template);

Code (Replace With) Select Expand

$old_template = preg_replace('~\<\?php(.*)\?\>~es', 'phpcodefix(\'$1\')', $old_template);

[I]

Thanks metallica,

I made the changes and it works great!  Solved another problem I was working!

Again, thanks!

[metallica48423]

Good to hear

Angelotus: any luck?

[Angelotus]

Have had no time to try it out yet, but will do it further this week and will tell if it worked

[metallica48423]

ok.  let us know

[Angelotus]

Well, I made the fixes, turned on SEF and it works perfect now! Metallica and others, thanks for helping me out with this!
It didn't had anything to do with the DDscript by the way

[metallica48423]

Good to know!

Enjoy

[I]

Well, I made the fixes, turned on SEF and it works perfect now! Metallica and others, thanks for helping me out with this!
It didn't had anything to do with the DDscript by the way

Yes, thanks again to Metallica for posting this fix.

Angelotus:  Thanks for the info on the DDscript [nofollow] - my wife really likes this script and we are adding it to my High School Alumni Association page!  This will allow the Class sites (some sub-domains and others with their own domains) to incorporate their latest news from our SMF pages on their sites also!

Of course anything my wife likes, I like!  It is always a pleasant surprise to be working on a problem and come up with something new that actually works - thanks!

[Angelotus]

Your Welcome! There can be found a lot of interesting scripts on Dynamic Drive!