Topic View Log

Started by vbgamer45, July 25, 2008, 02:30:24 PM

Previous topic - Next topic

Kimmie

#20
ok just tested it like that.. it didnt show the test account as having read the topic in that manner but it shows "me" reading it twice (and I never left the topic under my account - didnt refresh it either)

Also, when I marked the topic as read using the test account, I didnt use the "mark selected as read mod", I just marked them all as being read - so I think the mark selected as read mod is what is causing the additional read.


Migraine

Love this mod Sinan!  Thank you so much!!  Great job!!! 

~M

[SiNaN]

#22
Kimmie:

I just remembered the issue. In the createPost() function, there should be a code which logs the poster as read the post that he sent. It logs you even if you do not view the topic or post. If you are the poster, then you are logged. Can find and show you the codes too. Do not try to find bugs, you cannot. :P I've found one, but will not say until fixing. LOL

Migraine:

Thanks for you too Migraine, for using my mod.
Former SMF Core Developer | My Mods | SimplePortal

Eliana Tamerin

Great mod, SiNaN, as always.

A few suggestions (also as always):
-Show linktree so that users can get back to the topic if they want
-Page title should include topic name as well
-Include total number of guest views?
-Alter $topic['views'] on the MessageIndex to link to the topic log
Do NOT PM me for support.

SimplePortal 2.3.6 is OUT!
SimplePortal Project Manager
Download | Docs
SimplePortal: Power of Simplicity!

[SiNaN]

Eliana Tamerin:

Great suggestions, as always. :) I'll do them all.
Former SMF Core Developer | My Mods | SimplePortal

Kimmie

#25
Quote from: [SiNaN] on July 28, 2008, 02:48:25 AM
Kimmie:

I just remembered the issue. In the createPost() function, there should be a code which logs the poster as read the post that he sent. It logs you even if you do not view the topic or post. If you are the poster, then you are logged. Can find and show you the codes too. Do not try to find bugs, you cannot. :P I've found one, but will not say until fixing. LOL


lol sorry.. I dont purposely try and find bugs in mods.. its quite the opposite actually..when I install them I hope and pray that they work like they are supposed to...lol. (then, from experience, and since I am anal about testing out "every single part of it", I find that most generally dont - theres usually something little that was overlooked, etc and I just happen to be one to find it).  :P

I understand that when someone creates a topic it will automatically log them as viewing it "once" because when it posts, they will be inside the topic. My only concern is/was where is the
2nd viewing coming from. Its really not a big deal as it doesnt render any errors. I am just extremely observant when it comes to stuff like this which allows me to find the little things. lol.




[SiNaN]

Kimmie:

I understand Kimmie, just joking. :) Thanks, because we need people bugging out the bugs.

Okay, I mean this: when a user creates a topic, even if he do not view what he has posted means even if he don't view the topic the createPost() function logs him as he read the topic.

So I post the topic, but didn't view that. It is still showing as unread. But techically I've read that, while posting and SMF is clever enough to understand that and logged me as read. So now my view count is 1, the topic is still unread.

I go inside the topic to click to the topic log. Now, I've entered to the topic, so I'm logged again, it has been 2. Is it clear?
Former SMF Core Developer | My Mods | SimplePortal

stevebob

Quote from: [SiNaN] on July 27, 2008, 06:57:14 AM
stevebob:

Probably you've installed the mod manually. Check the modifications.english.php. The codes must be before ?> code. If there are any after ?> code, cut them and paste before.

I installed with the package installer.

I will try manually, though. Thanks.

[SiNaN]

stevebob:

Check that language file, sometimes that happens.
Former SMF Core Developer | My Mods | SimplePortal

Kimmie

Quote from: [SiNaN] on July 29, 2008, 07:32:15 AM
Kimmie:

I understand Kimmie, just joking. :) Thanks, because we need people bugging out the bugs.

Okay, I mean this: when a user creates a topic, even if he do not view what he has posted means even if he don't view the topic the createPost() function logs him as he read the topic.

So I post the topic, but didn't view that. It is still showing as unread. But techically I've read that, while posting and SMF is clever enough to understand that and logged me as read. So now my view count is 1, the topic is still unread.

I go inside the topic to click to the topic log. Now, I've entered to the topic, so I'm logged again, it has been 2. Is it clear?

Actually. on my site, when I create a topic, it will not show up on my unread posts because "I" am the one that created it so its not new to "me" - but its new to everyone else. I am considered as reading it at that point because as soon as I click "Post" I am taken to the topic I just made because I have it set to take you to the topic instead of taking you back to Topic View (which is accounting for 1 of the reads). 

What I was saying was, when I make a topic, and it directs me to inside the topic I just made as soon as I click on Post, If I click on Topic Log straight from there, its logging "2" views instead of just the 1.


Its really not that big of a deal though.  8)

[SiNaN]

Kimmie:

One of them is added as Subs-Post function does it automatically and the other one is because being redirected also counts as a view. :P
Former SMF Core Developer | My Mods | SimplePortal

jikoyster

This Mod is awesome but why cant i view the mod on other themes???
It does appear on the default theme though...

I installed "insidebb-v1"
http://custom.simplemachines.org/themes/index.php?lemma=392

ccbtimewiz

Quote from: jikoyster on August 01, 2008, 03:05:30 AM
This Mod is awesome but why cant i view the mod on other themes???
It does appear on the default theme though...

I installed "insidebb-v1"
http://custom.simplemachines.org/themes/index.php?lemma=392

In order to get this working on other themes, you know to manually edit the files of that theme via an FTP protocol.

How do I use FTP? / What is FTP?

[SiNaN]

Use the manual installation of the mod and make the theme file edits for your theme too.
Former SMF Core Developer | My Mods | SimplePortal

Kimmie

#34
Found something else..hehehe (sorry)

When you try to view the topic log on a topic that the members account who made it has been deleted, you get this: (see image)

Atleast thats the only reason I can think of that I would be getting that error - the members account  that made this topic was deleted and I get this error on all his topics.

[SiNaN]

Kimmie:

Congrats, you've found it. :P

It is the bug, I said above. It doesn't display guests' topic log. Fix is simple but I'll include that in the update.

For now you can do this:

../Sources/TopicLog.php

Find:

if(empty($member))

Replace:

if(empty($board))
Former SMF Core Developer | My Mods | SimplePortal

Kimmie

hehehe works like a charm. Thanks  :P

Low

This mod has messed my 1.1.5 forum. I have text/Jargon above the header EVEN after UN installing.

ccbtimewiz

Quote from: roulettered56 on August 05, 2008, 09:54:33 PM
This mod has messed my 1.1.5 forum. I have text/Jargon above the header EVEN after UN installing.

Open modifications.english.php from your /languages directory in the default theme.

Find:
?>

Make sure all text is above that.

Shepx83

#39
First off just wanted to let you know that this is a great mod and we find it very useful for running a Gaming Guild. Make it nice to see what members view the topics of our applying members, and for running polls for guild events/ideas.

Now just wanted to post to say that it dont appear to work 100%. I couldn't verify anything before not knowing really who is viewing and what not, but now I found one.

My one officer replied to one of our topic regarding an issue. So knowing he viewed it since he replied, he dont dont appear in the topic log.

Any way I can try to help figure this out, Just let me know. If this is a known issue, then im sorry for posting it again.

Thanks.

edit: Update: Our same officer posted again in the topic, and now it shows him viewing 1 time.

edit: Update2: Checked a few hours later and again, and now his name isnt on the Topiclog.

Advertisement: