• Welcome to Simple Machines Community Forum. Please login or sign up.

Highslide Image Viewer

Started by digger, October 07, 2008, 09:37:35 PM

Previous topic - Next topic

kerbob

NEED this for RC3.  Does anyone know if this is being worked on and what the ETA is?  Many thanks for this wonderful mod.

Nao 尚

Could you use the opportunity to make it compatible with Aeva Media 1.1, too?
I've upgraded my Highslide version to the latest, and apparently now they're conflicting. :-\
Willing to discuss any changes I could make to AeMe to help compatibility, too.

(And yes, I tried using a full HS 4.0.6 (7?) instead, and it didn't work so I had to rely on the latest version.)
I will not make any deals with you. I've resigned. I will not be pushed, filed, stamped, indexed, briefed, debriefed or numbered.

Aeva Media rocks your life.

okae


Nimnix

Been looking for this, thanks :)

digger

Quote from: Nao on March 11, 2010, 06:37:26 AM
Could you use the opportunity to make it compatible with Aeva Media 1.1, too?
I've upgraded my Highslide version to the latest, and apparently now they're conflicting. :-\
Willing to discuss any changes I could make to AeMe to help compatibility, too.

(And yes, I tried using a full HS 4.0.6 (7?) instead, and it didn't work so I had to rely on the latest version.)

I will take a look at Aeva Media 1.1 and update mod for the latest version of Highslide JS.

kerbob


~DS~

Doesn't AeMe already support Highslide in the newest version?
"There is no god, and that's the simple truth. If every trace of any single religion were wiped out and nothing were passed on, it would never be created exactly that way again. There might be some other nonsense in its place, but not that exact nonsense. If all of science were wiped out, it would still be true and someone would find a way to figure it all out again."
~Penn Jillette – God, NO! – 2011

MultiformeIngegno

of course but the 2 mods conflict..
RockCiclopedia (wiki - forum), Tutta la storia del rock, scritta da voi ...
Rimanere aggiornati sul mondo della musica grazie al nuovo feed "RockCiclopedia Music News"!

aw06

when will this be updated to rc3 ? or can the current one be emulated on rc3 ?
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Jesus Friends

Quote from: aw06 on March 21, 2010, 01:51:48 PM
when will this be updated to rc3 ? or can the current one be emulated on rc3 ?

I tried it with the emulation and succeed :)
My SMF version is 2.0 RC3
the link is: www.Jesus-friends.com/forum
The default language is Arabic

I LOVE SMF!

aw06

Quote from: Jesus Friends on March 21, 2010, 04:32:50 PM
Quote from: aw06 on March 21, 2010, 01:51:48 PM
when will this be updated to rc3 ? or can the current one be emulated on rc3 ?

I tried it with the emulation and succeed :)

Wonderful  8)
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Eddy Matthews

Emulation?

Can someone please explain how to get this mod to work with RC3? I tried installing it and it won't work for me :(

Regards
Eddy

Spuds

I noticed on RC3 (probably on RC2 as well) that the mod wants to run when you go to modify a message. 

The problem is that if the user creates a message, obviously with with an img tag, and saves it, all is fine.  However when they go to modify that message what they will get in the WYSIWYG (or non) is all of the extra highslide html that the mod creates for the img tags. 

So that simple img tag gets wrapped in an url tag plus each img will also have the post subject appended (left over from the div class=highslide-heading) .... when they then save the message that url and post subject are now part of the message instead of being quietly added in by the mod, in essence the message is permanently modified or corrupted, depending on your POV.

I did a quick update to the highslide image function in subs.php to see if it was being called from post, and if so to just return the message and not try to highslide the img tags in the post editor .. probably not the best way but needed something, so right after the global statement I added this

// If they are in the post view just return
if ($context['current_action'] == 'post')
return $message;



kosaic

So does this work on 2.0 RC3 ?

kosaic

ok, I just changed the install xml file to include 2.0 RC3, installed fine, but when I click on an image, I get full screen in IE (like a link to the image)

So, guess it does not work in RC3 :(

Spuds

Are you using the default theme?

kosaic

Using "Thing" , but based largely on the default theme.

Spuds

You will need to update your Thing to get the mod to work ....

The easiest way, although not always successful, is to use the package manager when you install the mod.  For you uninstall the mod, and then go and reinstall it, look at the bottom of the install actions screen where it says "Install in Other Themes" .. expand that section and select your theme and see if the package manager can successfully install it in that theme, if it can you are good to go.  If not then you will need to manually update your themes index.template.php file and possibly its Display.template.php depending on how custom a theme it is. 

So first try the package manager and see if that works.

kosaic

Eureka !

I'm such an idiot .... "Install in Other Themes" and chose my theme ... all is fine and it works like a charm in 2.0 RC3.

Just a slight edit in the xml files to include 2.0 RC3 , and all is good.

A tad more testing to do, but my quick test says it works just fine :)

THANKS !
K

kosaic

Ok, tested multiple images and posts ... works perfectly on 2.0 RC3 (albeit it is slow in IE8, Firefox is perfect as is Chrome)

The only thing I noticed is that if a post already exists prior to install, with "oversized" pictures in it, they end up being fullsize and stretch themselves beyond the width of the forum itself. (if that makes sense)

I modify the posts as admin, by cutting the entire post, save it with only a "." in it, then modify it again and paste the original contents back in and highslide apply's itself and all is fine.

Luckily I only had one post out of 100+ that had images in it that this affected.

Cheers,
K

Advertisement: