Topic: TinyPortal

[IchBin™]

Thanks for reporting the bug.

In Sources/TPmodules.php find:

Code: [Select]

            // insert the comment
            tp_query("INSERT INTO " . $tp_prefix . "variables (value1,value2,value3,type,value4,value5)
                            VALUES('". $title. "','". $comment. "','$ID_MEMBER','article_comment','$time',$article)", __FILE__, __LINE__);

Replace with this:

Code: [Select]

            // insert the comment
            tp_query("INSERT INTO " . $tp_prefix . "variables (value1,value2,value3,type,value4,value5)
                            VALUES('". mysql_real_escape_string($title). "','". mysql_real_escape_string($comment). "','$ID_MEMBER','article_comment','$time',$article)", __FILE__, __LINE__);


[Average Mom]

That fixed it! Thank you very much!

[Average Mom]

Got another one for ya LOL

...forum/index.php?/page,12.html
8: Undefined variable: avatar_height
File: /..../forum/Sources/TPortal.php
Line: 742

I get it only when someone views an article, though I'm not sure if it's the article itself or viewing it on the frontpage or both, I get the same error for avatar width also. I didn't realize I was getting that error also because there were so many errors from the other bug.

[IchBin™]

What are your frontpage settings and what are your category settings? I need to try the same setup as you so I can figure it out.

[Average Mom]

This is what you are asking to see right?

[IchBin™]

Ah thank you. That helps. It would appear it only errors like this if someone is using an external avatar and it tries to load that avatar as the author of an article. Let me take a look and see what the proper fix would be here in a bit.

[Average Mom]

Thanks, I appreciate it

[IchBin™]

In TPortal.php find this code about line #725

Code: [Select]

$ccount=0; $newcount=0;
if(tpdb_num_rows($request)>0)
{
Add this code before it.

Code: [Select]

// setup the avatar code
if ($modSettings['avatar_action_too_large'] == 'option_html_resize' || $modSettings['avatar_action_too_large'] == 'option_js_resize')
{
$avatar_width = !empty($modSettings['avatar_max_width_external']) ? ' width="' . $modSettings['avatar_max_width_external'] . '"' : '';
$avatar_height = !empty($modSettings['avatar_max_height_external']) ? ' height="' . $modSettings['avatar_max_height_external'] . '"' : '';
}
else
{
$avatar_width = '';
$avatar_height = '';
}

[Average Mom]

Thanks so much! That fixed it!  I appreciate the help and all the work you put into this. 

[anomaly]

FYI I found the bug with the online box only showing avatars instead of names.  On line 2407 of Sources/TPortal.php, change

                               if($block['var1']=='')
                                        $context['TPortal']['useavataronline'] = 0;
                                else
                                        $context['TPortal']['useavataronline'] = 1;

To:


                               if($block['var1']=='0')
                                        $context['TPortal']['useavataronline'] = 0;
                                else
                                        $context['TPortal']['useavataronline'] = 1;


(note, only the first line is changed, I provided the rest for context)

Cheers,

Anomaly

[IchBin™]

Thank you! I'll add this in for the next release.

[TeaTephi]

I upgraded successfully to smf 2.0 and tp 1.0.    However my shoutbox and other panels are visible to guests,  I don't have them checked off for access.  What am I missing?   


The screen shot shows that guests are unchecked yet they still see the shoutbox

[Touti]

Is there a known issue that would prevent the Rhino theme to work properly with TP RC1 ?  I just upgraded to RC1 from 1.0 Beta4 and now my site is all messed up.

The Front Page and Forum




Strangely, if I disable support for TP in the theme the front page looks better, although the line spacing in the top blocks are wrong, and the forum looks ok but I loose the "Forum" button in my menu.

[IchBin™]

I upgraded successfully to smf 2.0 and tp 1.0.    However my shoutbox and other panels are visible to guests,  I don't have them checked off for access.  What am I missing?   


The screen shot shows that guests are unchecked yet they still see the shoutbox

Yep that is a bug in TP1rc1. It's fixed in the next version of TP yet to be released.
http://www.tinyportal.co.uk/index.php?issue=42.0

[IchBin™]

Touti,

I don't remember which version it happened in, but Bloc made changes to TP quite some time ago so that it didn't require custom template options for TP to work. There should be no reason to turn the option on for TP to work properly. Make sure TP works in the default theme properly. If it does, then you know it's a theme issue.

[Touti]

Thanks Ichbin.  I do have the small "line spacing" issue in the default theme as well but that's something I can fix easily in the style sheets.

Besides that, the only problem I can see so far when disabling TP support in the theme is that I lose the "Forum" button that's no big deal either, I'll just edit the code and fix that.

Thanks again.

[IchBin™]

Yes, that is pretty much the only template edit that has to be done in SMF1.x.

[Touti]

I'm afraid I'm gonna help with this.  I've spent the last few hours looking at code and stylesheets but I just can find where the styles for this are.  What I'm trying to do is reduce the spacing between the lines in the Recent Topics block.  I know it's currently at 1.5em but I just can't find where that is in the code and change it to a lower value.

Any help would be appreciated.

[IchBin™]

Need to see a link to your site. If you don't want it public feel free to PM it to me.

[Touti]

I should have thought of that.

http://www.totalexpedition.com