Advertisement:

Author Topic: Auto Merge Double Post  (Read 266210 times)

Offline NanoSector

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 10,500
  • Gender: Male
  • VC321xb47@aperture:~#
    • Yoshi2889 on GitHub
Re: Auto Merge Double Post
« Reply #400 on: January 15, 2011, 02:50:01 PM »
still i don't have manual merge button and got this error:
Code: [Select]
8: Undefined index: double_post
File: /home/usename/public_html/example.com/Sources/Display.php
Line: 1379
:(
Weird?

I'll look into it.
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Offline NanoSector

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 10,500
  • Gender: Male
  • VC321xb47@aperture:~#
    • Yoshi2889 on GitHub
Re: Auto Merge Double Post
« Reply #401 on: January 15, 2011, 02:56:08 PM »
In ./Souces/Display.php, Find:
Code: [Select]
&& $context['double_post'][$message['id_msg']]
& remove it. Should work since I see no point in having it.

EDIT: Yes the merge button shows...but with a little space. I'll release an updated package with all three fixes later.

Updated package:
« Last Edit: January 15, 2011, 03:05:43 PM by Simple Series team »
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Offline phantomm

  • Sophist Member
  • *****
  • Posts: 1,064
  • Gender: Male
    • pages/smfpl/171860759503032 on Facebook
    • Polish ElkArte community
Re: Auto Merge Double Post
« Reply #402 on: January 15, 2011, 03:14:29 PM »
merge button shows when i removed && $context['double_post'][$message['id_msg']]

But, i don't know if that's how this mod works - i got Merge button on every post [screen] - even if there is not "double post", and when i try to merge posts it redirect me to ?action=post;topic

i hope you understand... :E
Polskie wsparcie SMF na simplemachines.org

My mods

Offline NanoSector

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 10,500
  • Gender: Male
  • VC321xb47@aperture:~#
    • Yoshi2889 on GitHub
Re: Auto Merge Double Post
« Reply #403 on: January 15, 2011, 03:19:46 PM »
That you get it on every post is normal.

I will recheck the link issue.
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Offline phantomm

  • Sophist Member
  • *****
  • Posts: 1,064
  • Gender: Male
    • pages/smfpl/171860759503032 on Facebook
    • Polish ElkArte community
Re: Auto Merge Double Post
« Reply #404 on: January 15, 2011, 03:51:47 PM »
Polskie wsparcie SMF na simplemachines.org

My mods

Offline NanoSector

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 10,500
  • Gender: Male
  • VC321xb47@aperture:~#
    • Yoshi2889 on GitHub
Re: Auto Merge Double Post
« Reply #405 on: January 15, 2011, 03:54:00 PM »
That you get it on every post is normal.

because on mod site this button isn't on every post
http://custom.simplemachines.org/mods/index.php?action=download;mod=1523;id=117210;image
That's because the first post you see is the first post in the topic.
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,664
    • StoryBB/StoryBB on GitHub
Re: Auto Merge Double Post
« Reply #406 on: January 15, 2011, 08:01:24 PM »
Quote
That you get it on every post is normal.

No it isn't... it should be related to whether the posts are from the same author!
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Jeet Chowdhury

  • Jr. Member
  • **
  • Posts: 239
  • Gender: Male
  • Running SMF 2.0.2
    • MuSKiL AShaN
Re: Auto Merge Double Post
« Reply #407 on: January 16, 2011, 03:17:53 AM »
how to add this mod in 2.0 rc4???

Offline NanoSector

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 10,500
  • Gender: Male
  • VC321xb47@aperture:~#
    • Yoshi2889 on GitHub
Re: Auto Merge Double Post
« Reply #408 on: January 16, 2011, 04:00:05 AM »
Quote
That you get it on every post is normal.

No it isn't... it should be related to whether the posts are from the same author!
That is false.

@ latest post: use my package on this page.
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,664
    • StoryBB/StoryBB on GitHub
Re: Auto Merge Double Post
« Reply #409 on: January 16, 2011, 04:37:13 AM »
Funny, that's how the mod's code is geared to be.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline phantomm

  • Sophist Member
  • *****
  • Posts: 1,064
  • Gender: Male
    • pages/smfpl/171860759503032 on Facebook
    • Polish ElkArte community
Re: Auto Merge Double Post
« Reply #410 on: January 16, 2011, 06:20:58 AM »
That's because the first post you see is the first post in the topic.

hmm... that's only one post in topic and still got the button...
http://img703.imageshack.us/img703/1466/000g.png
Polskie wsparcie SMF na simplemachines.org

My mods

Offline NanoSector

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 10,500
  • Gender: Male
  • VC321xb47@aperture:~#
    • Yoshi2889 on GitHub
Re: Auto Merge Double Post
« Reply #411 on: January 16, 2011, 06:26:43 AM »
That's because the first post you see is the first post in the topic.

hmm... that's only one post in topic and still got the button...
http://img703.imageshack.us/img703/1466/000g.png
At least the button shows.

I'll try to fix it in the next release.
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,664
    • StoryBB/StoryBB on GitHub
Re: Auto Merge Double Post
« Reply #412 on: January 16, 2011, 06:29:53 AM »
I wonder if instead of blindly removing $context['double_post']'s check, you reinstate it and fix where it's generated...
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline NanoSector

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 10,500
  • Gender: Male
  • VC321xb47@aperture:~#
    • Yoshi2889 on GitHub
Re: Auto Merge Double Post
« Reply #413 on: January 16, 2011, 07:18:05 AM »
I wonder if instead of blindly removing $context['double_post']'s check, you reinstate it and fix where it's generated...
I wonder what you are doing with correcting me when I told you not to do that earlier our fight with my mod.
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Offline Dzonny

  • Localizer
  • SMF Super Hero
  • *
  • Posts: 11,950
  • Gender: Male
  • No sleep...
    • dzontra.nikola on Facebook
    • Dzonny on GitHub
    • dzontranikola on LinkedIn
    • @opusteniforum on Twitter
    • Samo opusteno
Re: Auto Merge Double Post
« Reply #414 on: January 16, 2011, 10:30:59 AM »
Simple Series team, thanks for 2.0 RC4 version, works perfectly :D

Offline NanoSector

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 10,500
  • Gender: Male
  • VC321xb47@aperture:~#
    • Yoshi2889 on GitHub
Re: Auto Merge Double Post
« Reply #415 on: January 16, 2011, 10:34:26 AM »
Simple Series team, thanks for 2.0 RC4 version, works perfectly :D
Except for that little manual post merge bug :(

Thanks anyway :)
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,664
    • StoryBB/StoryBB on GitHub
Re: Auto Merge Double Post
« Reply #416 on: January 16, 2011, 10:35:23 AM »
I wonder what you are doing with correcting me when I told you not to do that earlier our fight with my mod.

You tell people to make changes that you don't think have any issues and when one is presented to you, you seem to ignore it. $context['double_post'] is, funnily enough, there for a REASON. Just because you don't understand that reason doesn't mean there isn't one.

And it's the cause of the displaying the manual merge button on every page because you're now not testing whether it should be displayed on a given post but displaying it all the time...
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline NanoSector

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 10,500
  • Gender: Male
  • VC321xb47@aperture:~#
    • Yoshi2889 on GitHub
Re: Auto Merge Double Post
« Reply #417 on: January 16, 2011, 10:39:00 AM »
I wonder what you are doing with correcting me when I told you not to do that earlier our fight with my mod.

You tell people to make changes that you don't think have any issues and when one is presented to you, you seem to ignore it. $context['double_post'] is, funnily enough, there for a REASON. Just because you don't understand that reason doesn't mean there isn't one.

And it's the cause of the displaying the manual merge button on every page because you're now not testing whether it should be displayed on a given post but displaying it all the time...
You DO NOT seem to get the words "I'll fix it LATER ON".

You know I'm truly OVER with you, Arantor?
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Offline Makar

  • Semi-Newbie
  • *
  • Posts: 75
    • Портал у Завгара
Re: Auto Merge Double Post
« Reply #418 on: January 16, 2011, 05:20:30 PM »
I have a board in which permission to write guests
all posts must be pre-approved by moderators.
before sending the visitor must solve a captcha, and answer any additional questions.
so here.
if I put this mod, the introduction of answering questions and solving a captcha is not mandatory
Guests can enter into the fields to answer anything you like and send a message
message is sent and there is no warning that the answers to the captcha entered non correctly!
« Last Edit: January 16, 2011, 05:47:36 PM by Makar »

Sorry for my english

Offline NanoSector

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 10,500
  • Gender: Male
  • VC321xb47@aperture:~#
    • Yoshi2889 on GitHub
Re: Auto Merge Double Post
« Reply #419 on: January 17, 2011, 09:36:42 AM »
I have a board in which permission to write guests
all posts must be pre-approved by moderators.
before sending the visitor must solve a captcha, and answer any additional questions.
so here.
if I put this mod, the introduction of answering questions and solving a captcha is not mandatory
Guests can enter into the fields to answer anything you like and send a message
message is sent and there is no warning that the answers to the captcha entered non correctly!
That is pretty weird.

Try uninstalling this mod, then the captcha software.
Then reinstall this mod, then the captcha software.

That should put the captcha software on top of this software ;)
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."