Auto Merge Double Post

[Pablo25]

M-DVD, I've got a problem. After editing user's posts, info about merging posts changes. For example:

After writing second post:

Code Select Expand

Post Merge: 11-01-2009, 14:32

After editing post:

Code Select Expand

Post Merge: [time]sun 11 jan 2009 14:32:22 GMT-1[/time]

Do you have any idea? Thanks in advance.

[mark7144]

I had the above problem when merging more than 2 posts.

[M-DVD]

M-DVD, ок i ll wait.
Updated my version to 1.2, i allways install and uninstall mods manualy.
Posts don't mergerd if not checked Ignore Double Post Permission.
In version 1.0 and 1.1 I used this one to ignore memberships premission

Search:

if (allowedTo('doublePost') || isset($_REQUEST['msg']))

Replace:

if (isset($_REQUEST['msg']))

And now I want to use this function to manage premissions for groupes on my forum, but it dont work

You have reviewed all your changes?

Check this: Admin.template.php (only SMF 1.1.X), ManagePosts.php, Subs-Post.php.

M-DVD, I'm not asking you release a mod for my suggestion, I'm asking you to simply include an extra option in your Merge Post mod. The functionality was in Nao's mod so why not include it in yours as clearly it is not just a request from an individual, it is something many users want.

Ok, I understand, but look this.

Imagine: "I added this feature"
Person A: wants bump topic with merge post, and enable this feature.
Person B: not wants bump topic with merge post, and disable this feature.
Person C: wants notification with new information (not only with merge), then this feature isn't helpful. Then install the "second MOD" and... -> problems + error + inefficiency.

So I have to choose, and choose the most logical.

Your solution: (I think so)

1 .- Install Auto Merge Double Post.
2 .- Install Notify Modification Last Post and...
3 .- Disable his functions (because you don't want this)
4 .- Edit the file Subs-Post.php and search:

$_REQUEST['msg'] = $_GET['msg'] = $row['id_last_msg'];

Add (before or after):

$modSettings['ModifyLastPostBump'] = true;  // If you like bump

or

$modSettings['ModifyLastPostMail'] = true;  // If you like mail

etc

I think that you should serve.

M-DVD, I've got a problem. After editing user's posts, info about merging posts changes. For example:

After writing second post:

Code Select Expand

Post Merge: 11-01-2009, 14:32

After editing post:

Code Select Expand

Post Merge: [time]sun 11 jan 2009 14:32:22 GMT-1[/time]

Do you have any idea? Thanks in advance.

I had the above problem when merging more than 2 posts.

Time BBCode, is a BBCode native of SMF. Should work fine.

I couldn't reproduce this error. I have done many many mergers, many editions, and without issues. Any idea? Anything else that may help? Any link where I can see it?

[mark7144]

M-DVD: If you are not going to make the most logical choice, which is doing what I suggest and what Nao did with his mod, then I'm now giving up with trying to persuade you. Eventually you'll probably realise how much your lack of action on this issue held back your mod, it's quite sad that you are stopping it reach its full potential.

Nao: Any chance you could get your mod to work for 1.1.7? I tried the attached and it said it was corrupt.

[Nao 尚]

Nao: Any chance you could get your mod to work for 1.1.7?

Of course. I'll be transitioning this week from a fulltime work on Aeva, to a part-time work between Aeva, SMG and other things. Hopefully.

Maybe I can find some time to do a correct version of the DoublePost merge thingie for both SMF 1 and SMF 2. And publish it as an actual mod etc.

[mark7144]

Maybe I can find some time to do a correct version of the DoublePost merge thingie for both SMF 1 and SMF 2. And publish it as an actual mod etc.

That would be awesome, thanks

[M-DVD]

M-DVD: If you are not going to make the most logical choice, which is doing what I suggest and what Nao did with his mod, then I'm now giving up with trying to persuade you. Eventually you'll probably realise how much your lack of action on this issue held back your mod, it's quite sad that you are stopping it reach its full potential.

Nao: Any chance you could get your mod to work for 1.1.7? I tried the attached and it said it was corrupt.

I'm already making the most logical option. In the prev message (I guess you don't read) explain why. Otherwise I will profit is to you, but I damage to others. In this way (the most logical option), I profit to others, but don't damage to you.

First 1) You said want to have notice of new information, and this mod gives you what you want. Then you don't agree, 2) And you say want to have notice "only with Merge Post"; and I give you a solution on this issue and also rejected it.

Please be honest in this topic, the Truth is, you don't like anything I have offered, not because they don't serves, but simply because they don't want.

I hope you have luck on their way, and please, don't waste me time with lies, I cannot follow their game.

[mark7144]

I am being honest, I did read your post and appreciate the effort you made, thanks.

However, your solution is far from ideal as it involves installing 2 mods and hacking one of them when instead I should be able to download 1 mod with no hacking. Tell me this, are you saying Nao made an illogical choice when he implemented the feature in his mod?

[M-DVD]

I am being honest and I did read your post and appreciate the effort you made, thanks.

However, your solution is far from ideal as it involves installing 2 mods and hacking one of them when instead I should be able to download 1 mod with no hacking. Tell me this, are you saying Nao made an illogical choice when he implemented the feature we are all asking for?

First: Yes, are two MODs, but you shouldn't see the number, you should see the code. Both MOD are much less code and more efficient than the other (yes, two MOD, more efficient and light than one MOD).

Second: "we are all asking for", I don't know how true it is. "Only you" just want notice to "Merge Post" and not for all cases (ok, is your decision, and also I have solution for you).

And as I said before, in the other MOD is a collateral effect. And I have no need to intentionally add this feature, because there is already a MOD that makes the role and more comprehensive. If I add this funcition in this MOD, then caused many problems for those who want the two functions of both MODs (If I will profit to you, then I damage to others. In this way, I profit to others, but don't damage to you;... and also is it the logical way).


A personal example:

I recently did a MOD, I needed to read a page remotely. Not all host have turned fsockopen function, then I went to add a function that uses cURL to make this work. This was a mistake. Then I decided to do what was correct, and don't add this.

Later, aldo did something to solve "the real problem with a real solution," and did this MOD. I am happy and I congratulate him because that was what I had to do, he has given the nail on the head.

Now, I and everyone, need to add anything, because the aldo's MOD makes the work, and work for all, without cause problems or duplicating code.

[Nao 尚]

@mark> I didn't choose anything... As a reminder: I am not the author of Merge Double Posts. I merely "got the job" without asking for anything, after I wrote a SMF2 version and submitted it to the original author (Din). But even though these aren't my choices, I stand by them. I've been living with the MDP mod for 4 years on my websites, and I wouldn't go back for anything in the world. (Especially with my 2007 additions.)

First: Yes, are two MODs, but you shouldn't see the number, you should see the code. Both MOD are much less code and more efficient than the other (yes, two MOD, more efficient and light than one MOD).

I'm not sure I like the idea of bumping/notifying a topic for a simple edit. Although I would like to see the "New" icon to show up again when a post has been edited. But it requires modifying everyone's topicseen/boardseen logs. Which is complicated.

Second: "we are all asking for", I don't know how true it is. "Only you" just want notice to "Merge Post" and not for all cases (ok, is your decision, and also I have solution for you).

Yes, I have to admit Mark is very vocal about what he wants
But one also has to admit that his website is nicely done (the kind that would actually make me like Andy Murray... Okay maybe not ), and he does have some good ideas.

Later, aldo did something to solve "the real problem with a real solution," and did this MOD. I am happy and I congratulate him because that was what I had to do, he has given the nail on the head.

Hmm yeah it's a good thing he made that mod, but most of the SMF community doesn't seem to care. As I mentioned to him in his topic, he needs to evangelize the community about what the point is. Also, he should add even more capability to his mod. If you look into Aeva, you'll see that my own implementation of fetch_web_data() (called aeva_fetch()) also "tries" two other retrieval methods before calling it quits. I don't remember ever seeing someone tell me the lookup feature didn't work, actually.

[netoya]

M-DVD,

You have reviewed all your changes?

Check this: Admin.template.php (only SMF 1.1.X), ManagePosts.php, Subs-Post.php.

yes, I have checked it many times but merging works only then "Ignore Double Post Permission" is on.
I attached my files, waiting for your help.

[mark7144]

I'm not sure I like the idea of bumping/notifying a topic for a simple edit. Although I would like to see the "New" icon to show up again when a post has been edited. But it requires modifying everyone's topicseen/boardseen logs. Which is complicated.

Can you remind me, what exactly does your mod do in regards to this?

But one also has to admit that his website is nicely done (the kind that would actually make me like Andy Murray... Okay maybe not ), and he does have some good ideas.

Thanks, bro!

[Nao 尚]

I'm not sure I like the idea of bumping/notifying a topic for a simple edit. Although I would like to see the "New" icon to show up again when a post has been edited. But it requires modifying everyone's topicseen/boardseen logs. Which is complicated.

Can you remind me, what exactly does your mod do in regards to this?

Nothing. It acts just like there was no merging in the first place. The last post is "silently edited" to insert the previous post at the beginning of it. Then the previous post is deleted.
Any notification related feature will do the same as if no merge operation had taken place.

[mark7144]

Nothing. It acts just like there was no merging in the first place. The last post is "silently edited" to insert the previous post at the beginning of it. Then the previous post is deleted.
Any notification related feature will do the same as if no merge operation had taken place.

Perfect! That's exactly what I want and it is far the most logical method for a double post mod.

[Nao 尚]

So...?

[mark7144]

Are you asking me a question?

[Nao 尚]

I'm not sure what you want me, or M-DVD, to do?

[mark7144]

How was I suggesting that either one of you should do anything? I just asked you a question about of curiosity

[M-DVD]

yes, I have checked it many times but merging works only then "Ignore Double Post Permission" is on.
I attached my files, waiting for your help.

Ok, i will check.

First: Yes, are two MODs, but you shouldn't see the number, you should see the code. Both MOD are much less code and more efficient than the other (yes, two MOD, more efficient and light than one MOD).

1) I'm not sure I like the idea of bumping/notifying a topic for a simple edit. Although I would like to see the "New" icon to show up again when a post has been edited. 2) But it requires modifying everyone's topicseen/boardseen logs. Which is complicated.

I don't understand the relationship of the quote with the answer ({*} my paranoia makes me think ¿fallacies in a support forum?, sorry), but:

1.- With the second MOD if only you want to see the "New Icon", then only active this option, and disable the other. Because this MOD is specialist for this task.

PD: Then, What you think of MOD MDP?, because this MOD always bumping the topic and send mail with "a simple edition" (Post Merge)

2.- ? The MOD do this work... with two updates.

Yes, I have to admit Mark is very vocal about what he wants
But one also has to admit that his website is nicely done (the kind that would actually make me like Andy Murray... Okay maybe not ), and he does have some good ideas.

({*} déjà vu?)

Okay, but, that you say doesn't change what happened. All his requests have been accepted and solved, then has rejected the solution, and has changed the history.

Hmm yeah it's a good thing he made that mod, but most of the SMF community doesn't seem to care. As I mentioned to him in his topic, he needs to evangelize the community about what the point is. Also, he should add even more capability to his mod...

Yes, it is very good, pity that great things generally tend to go unnoticed for the people.

Nothing. It acts just like there was no merging in the first place. The last post is "silently edited" to insert the previous post at the beginning of it. Then the previous post is deleted.
Any notification related feature will do the same as if no merge operation had taken place.

Perfect! That's exactly what I want and it is far the most logical method for a double post mod.

don't bet your salary XD

Comparison:

- The reply is sent. - Checked if is Double Post. (Yes) - Then "silently" is change the "Form REQUEST", and... - Now the reply isn't released "new", but modify the previous one. - End.

- The reply has sent - The new reply is released (Increases the number of user posts, the number replies in the topics, the number replies in the board, send notifications, missing something?) - The last post is "silently edited", ie... - Read the last two post - Move attachments from another post, to the new reply. - It decreases the number of posts topic's - And the number of replies from the board - And the number of posts member's. - The post is updated with new information from the previous one. - Now remove the prev post. - End.

[mark7144]

All his requests have been accepted and solved, then has rejected the solution, and has changed the history.

What are you on about? My request has always been for you to include the functionality I want into your existing Double Post mod but you have rejected my request. Instead, you have given me a solution that requires too much effort - I don't want to install 2 mods and hack one of them just so that I can get something that should logically be included in 1 mod.