News:

SMF 2.1.4 has been released! Take it for a spin! Read more.

Main Menu

Auto Merge Double Post

Started by M-DVD, December 03, 2008, 10:18:25 AM

Previous topic - Next topic

NanoSector

Quote from: adi1166 on January 15, 2011, 02:49:11 PM
still i don't have manual merge button and got this error:
8: Undefined index: double_post
File: /home/usename/public_html/example.com/Sources/Display.php
Line: 1379

:(
Weird?

I'll look into it.
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

NanoSector

#401
In ./Souces/Display.php, Find:
&& $context['double_post'][$message['id_msg']]

& remove it. Should work since I see no point in having it.

EDIT: Yes the merge button shows...but with a little space. I'll release an updated package with all three fixes later.

Updated package:
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Adrek

merge button shows when i removed && $context['double_post'][$message['id_msg']]

But, i don't know if that's how this mod works - i got Merge button on every post [screen] - even if there is not "double post", and when i try to merge posts it redirect me to ?action=post;topic

i hope you understand... :E
Polskie wsparcie SMF na simplemachines.org

the simplest solution is most likely the right one

NanoSector

That you get it on every post is normal.

I will recheck the link issue.
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Adrek

Polskie wsparcie SMF na simplemachines.org

the simplest solution is most likely the right one

NanoSector

My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Arantor

QuoteThat you get it on every post is normal.

No it isn't... it should be related to whether the posts are from the same author!

Jeet Chowdhury

how to add this mod in 2.0 rc4???

NanoSector

Quote from: Arantor on January 15, 2011, 08:01:24 PM
QuoteThat you get it on every post is normal.

No it isn't... it should be related to whether the posts are from the same author!
That is false.

@ latest post: use my package on this page.
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Arantor

Funny, that's how the mod's code is geared to be.

Adrek

Quote from: Simple Series team on January 15, 2011, 03:54:00 PM
That's because the first post you see is the first post in the topic.

hmm... that's only one post in topic and still got the button...
http://img703.imageshack.us/img703/1466/000g.png
Polskie wsparcie SMF na simplemachines.org

the simplest solution is most likely the right one

NanoSector

Quote from: adi1166 on January 16, 2011, 06:20:58 AM
Quote from: Simple Series team on January 15, 2011, 03:54:00 PM
That's because the first post you see is the first post in the topic.

hmm... that's only one post in topic and still got the button...
http://img703.imageshack.us/img703/1466/000g.png
At least the button shows.

I'll try to fix it in the next release.
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Arantor

I wonder if instead of blindly removing $context['double_post']'s check, you reinstate it and fix where it's generated...

NanoSector

Quote from: Arantor on January 16, 2011, 06:29:53 AM
I wonder if instead of blindly removing $context['double_post']'s check, you reinstate it and fix where it's generated...
I wonder what you are doing with correcting me when I told you not to do that earlier our fight with my mod.
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Dzonny

Simple Series team, thanks for 2.0 RC4 version, works perfectly :D

NanoSector

Quote from: Dzonny on January 16, 2011, 10:30:59 AM
Simple Series team, thanks for 2.0 RC4 version, works perfectly :D
Except for that little manual post merge bug :(

Thanks anyway :)
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Arantor

Quote from: Simple Series team on January 16, 2011, 07:18:05 AM
I wonder what you are doing with correcting me when I told you not to do that earlier our fight with my mod.

You tell people to make changes that you don't think have any issues and when one is presented to you, you seem to ignore it. $context['double_post'] is, funnily enough, there for a REASON. Just because you don't understand that reason doesn't mean there isn't one.

And it's the cause of the displaying the manual merge button on every page because you're now not testing whether it should be displayed on a given post but displaying it all the time...

NanoSector

Quote from: Arantor on January 16, 2011, 10:35:23 AM
Quote from: Simple Series team on January 16, 2011, 07:18:05 AM
I wonder what you are doing with correcting me when I told you not to do that earlier our fight with my mod.

You tell people to make changes that you don't think have any issues and when one is presented to you, you seem to ignore it. $context['double_post'] is, funnily enough, there for a REASON. Just because you don't understand that reason doesn't mean there isn't one.

And it's the cause of the displaying the manual merge button on every page because you're now not testing whether it should be displayed on a given post but displaying it all the time...
You DO NOT seem to get the words "I'll fix it LATER ON".

You know I'm truly OVER with you, Arantor?
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Makar

#418
I have a board in which permission to write guests
all posts must be pre-approved by moderators.
before sending the visitor must solve a captcha, and answer any additional questions.
so here.
if I put this mod, the introduction of answering questions and solving a captcha is not mandatory
Guests can enter into the fields to answer anything you like and send a message
message is sent and there is no warning that the answers to the captcha entered non correctly!

Sorry for my english

NanoSector

Quote from: Makar on January 16, 2011, 05:20:30 PM
I have a board in which permission to write guests
all posts must be pre-approved by moderators.
before sending the visitor must solve a captcha, and answer any additional questions.
so here.
if I put this mod, the introduction of answering questions and solving a captcha is not mandatory
Guests can enter into the fields to answer anything you like and send a message
message is sent and there is no warning that the answers to the captcha entered non correctly!
That is pretty weird.

Try uninstalling this mod, then the captcha software.
Then reinstall this mod, then the captcha software.

That should put the captcha software on top of this software ;)
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."

Advertisement: