Additional Polls

[Windy]

So it's probably not an issue with the version.

[Rafferty]

Well I dont know, it worked fine before but wont install after rc4

[Windy]

Well I dont know, it worked fine before but wont install after rc4

It worked fine before because you never had to reinstall it, hence it's never had to deal with the column already existing.  For whatever reason, either the method that checks if the column exists has been modified, or mysql isn't returning the correct column names or is returning them in an alternative format so its not being detected as already being there.

[Rafferty]

Hmmm Norv from smf was in there a week ago tinkering, dont know if he changed anything though

[Windy]

if you want you could try posting your DbPackages-mysql.php in the sources directory and i can tell you if there's been any changes.

[Rafferty]

my backup?, what do you mean?

[Windy]

Go to your smf installation directory, then go to the sources directory, download the DbPackages-mysql.php file and attach it to your post.

[Assault]

When installing to the core theme this happens
   4.   Replace   ./Themes/core/Display.template.php   Test failed
Find[Select]
<div class="content" id="poll_options">
Replace[Select]
<div class="content poll_options">


Shouldn't it remain <div class="content" id="poll_options">

[Windy]

no. I would imagine it's different to core which is why it fails.

[Assault]

Okay, and another thing, in core you need to use this snippet of code in the core/Display.Template.php

Code Select Expand

// They are allowed to vote! Go to it!
else
{
echo '
<form action="', $scripturl, '?action=vote;topic=', $context['current_topic'], '.', $context['start'], ';poll=', $context['poll']['id'], '" method="post" accept-charset="', $context['character_set'], '" style="margin: 0px;">
<table>
<tr>
<td colspan="2">';

// Show a warning if they are allowed more than one option.
if ($context['poll']['allowed_warning'])
echo '
', $context['poll']['allowed_warning'], '
</td>
</tr><tr>
<td>';

It gives you a syntax error shouldn't there be a } at the end like this

Code Select Expand

// They are allowed to vote! Go to it!
else
{
echo '
<form action="', $scripturl, '?action=vote;topic=', $context['current_topic'], '.', $context['start'], ';poll=', $context['poll']['id'], '" method="post" accept-charset="', $context['character_set'], '" style="margin: 0px;">
<table>
<tr>
<td colspan="2">';

// Show a warning if they are allowed more than one option.
if ($context['poll']['allowed_warning'])
echo '
', $context['poll']['allowed_warning'], '
</td>
</tr><tr>
<td>';}

[Windy]

I wouldn't know, it was built for Curve, for the tests that failed, if you look at the changes it made to curve, it should give you a decent idea as to where it should go, offhand that doesn't look right to me, although keep in mind its been ages since I've gone over the code.

[dry3210]

I get this when trying to install now after upgrading

Duplicate column name 'id_topic'
File: /public_html/Packages/temp/install2.php
Line: 43

[chinaren]

Yah, I'm also getting...

Duplicate column name 'id_topic'
File: .../Packages/temp/install2.php
Line: 43

Any ideas?  I'd really like to put this one back in!

[Rafferty]

Yah, I'm also getting...

Duplicate column name 'id_topic'
File: .../Packages/temp/install2.php
Line: 43

Any ideas?  I'd really like to put this one back in!

Ive had this error now on 3 mods so far when trying to reinstall in RC4

[Windy]

yeah, it's really an SMF issue, one that I imagine is somewhat unique to your configuration as I can't reproduce it.

[chinaren]

yeah, it's really an SMF issue, one that I imagine is somewhat unique to your configuration as I can't reproduce it.

Do you know where we should start looking to try and fix this?  There are three of us with this, in this thread, so it's obviously not all that unique! 


Is it a database error?  I had additional polls installed before, and it 'fell out' when I upgraded to SMF C2.4, so obviously all the tables are still there, maybe some code too.

[Windy]

yeah, it's really an SMF issue, one that I imagine is somewhat unique to your configuration as I can't reproduce it.

Do you know where we should start looking to try and fix this?  There are three of us with this, in this thread, so it's obviously not all that unique! 


Is it a database error?  I had additional polls installed before, and it 'fell out' when I upgraded to SMF C2.4, so obviously all the tables are still there, maybe some code too.

It is a database error, caused by the code not being able to detect the column for some unknown reason.

The key thing to find out would be to find out why it can't detect that the column exists. If you open up DbPackages-mysql.php from the Sources directory and look for the function smf_db_add_column and then log the contents into a file or something of both the $columns and $column_info variables right before the first foreach loop. You may also want to log whether it made it into the if statement in that first foreach loop, that way we can also tell if it was able to find the column and the issue is elsewhere.

Then you can run it again after and post the contents of the logs so I can see what's going on.

[katb]

Getting  above error on SMF 2.0 RC4

Duplicate column name 'id_topic'
File: /home/newthat/public_html/New/Packages/temp/install2.php
Line: 43

Look like a know issue in this version SMF 2.0 RC4

[drvanitus]

OMG thank you so much, didn't know such mod existed, this is priceless.  Now we can vote on all new applicants in the same thread with ease.  Thanks!

[Teerapat]

Cannot install on 2.0 RC5