News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

Yet Another Global Announcements Mod (YAGAM)

Started by Nibogo, February 11, 2009, 12:47:15 AM

Previous topic - Next topic

Hot Rides

can not see any announcements at all!

checked all my files to make sure they were modified properly; yes
checked with default theme; yes

this is driving me crazy!
i made to test announcements and changed every setting possible and nothing

any ideas?

not that it will do much good, but

username- testuser
password- testpassword
site- http://hot-rides.net/index.php

Xepernas

Any idea how to make it display the announcements on the SFM2RC1 versions of the default YABB and Babylon themes ? It works perfectly fine on Core theme and most other 2RC1 custom ones.

Nibogo

@edi67: I make the mod for separate Sticky and Normal Topics , I just have to uploaded to the mod site , I will add support for the YAGAM Mod

Quote from: PerryM on February 18, 2009, 12:53:09 AM
Using newest module - however, when I try to add a new announcement I get the following error:
 
An Error Has Occurred!
[/t]

The installation have any error??

U have all the files mod uploaded??

Quote from: edi67 on February 18, 2009, 07:49:50 AM
Quote from: NIBOGO on February 17, 2009, 05:53:52 PM
292 Bug Fixed :) (I hope)

Bug with the delete comment string fixed :)


NIBOGOOOOOOOOOOOOOO great now work ;) finally the more useful mod for SMF working thx again bro, i will attach italian translation immediately :)

Thanks for your comment and I will be happy if you help with the italian language

Quote from: mattchewone on February 18, 2009, 08:15:58 AM
Just re-installed this mod and it works fine no more errors! There is one thing though, would it be possible to have the avatar under the member group rank in the announcement to make it the same layout as the rest of the forum?

The avatar is already a feature of this mods

Quote from: Xepernas on February 18, 2009, 04:10:00 PMake
Any idea how to make it display the announcements on the SFM2RC1 versions of the default YABB and Babylon themes ? It works perfectly fine on Core theme and most other 2RC1 custom ones.

Make the manual edit to the MessageIndex Files on that themes

Xepernas

Quote from: NIBOGO on February 18, 2009, 04:26:26 PM
Make the manual edit to the MessageIndex Files on that themes

I'd adore to. Unfortunately I can't find, in these themes' MessageIndex.template.php, the quotes that would allow me to locate where to add the YAGAM code, or what to replace with it. There is no "no topic, sorry bub" comment, I couldn't find any "if (empty($context['topics']))", and I'm not knowledgable enough to recognise the equivalents.

When you'll have some time, would it be complicated to have a quick look at these themes templates (or just babylon), and give me a few indications on what parts to change ? If you haven't erased them, you should have both Babylon and YABB by default on SMF.


willerby

Congrats NIBOGO, 1.4 works great. fantastic mod...thanks for fixing that 292 error
What type of washing machine is September?

An autumnatic. :)

Nibogo

Quote from: Xepernas on February 18, 2009, 05:19:51 PM
Quote from: NIBOGO on February 18, 2009, 04:26:26 PM
Make the manual edit to the MessageIndex Files on that themes

I'd adore to. Unfortunately I can't find, in these themes' MessageIndex.template.php, the quotes that would allow me to locate where to add the YAGAM code, or what to replace with it. There is no "no topic, sorry bub" comment, I couldn't find any "if (empty($context['topics']))", and I'm not knowledgable enough to recognise the equivalents.

When you'll have some time, would it be complicated to have a quick look at these themes templates (or just babylon), and give me a few indications on what parts to change ? If you haven't erased them, you should have both Babylon and YABB by default on SMF.



YAGAM v1.5 will have Babylon and Classic theme support ;)

Also spellchecker and announcement preview.

Any idea is more than welcome ;)

Xepernas

Quote from: NIBOGO on February 18, 2009, 09:03:42 PMAny idea is more than welcome ;)

Well, I'm not sure how it can be ameliorated further, then. :)

Say, for the ideal usage I'd make of it, I'd need the announcement itself to be displayed directly on the "topicsllist"  page. That is :

Board name
---------
Announcement title.

Whole announ-
cement con-
tent (aka post
body) displayed
there.
---------
Topic title
---------
Topic title
---------
Topic title
---------
etc

Is that feasible, or already planned, or already available ?

drhamad

NIGOBO: you might want to change the title of the FIRST post in this thread, as it still says 1.1.4 in the overall header.
FMVperformance:  3.51m posts, 63k members, 11 boards, 1 database

Mazda3Forums - SmallVolvos - MazdaSpeeders Mazda Club - FordFusionClubMazda CX-7 Club - MyMazda6
Now introducing: MKSdrivers.com - FocusDrivers - TaurusDrivers

edi67

NIBOGO: one little bug, permission for manage announcements NOT work for me, membergroups enabled to MANAGE them cannot create new announcements can ONLE edit one existent announcement, only admin can create new, others view only grey title not clickable, is possible give permission to create new to others usergroups ?
CrazyZone - My SMF Forum


From the difficult the hardening of the man you can see

Nibogo

Quote from: drhamad on February 20, 2009, 05:10:09 PM
NIGOBO: you might want to change the title of the FIRST post in this thread, as it still says 1.1.4 in the overall header.

I am NIBOGO not NIGOBO :P

I change the versions in this way:

1.2 = 1.1.2
1.3 = 1.1.3
1.4 = 1.1.4


So the current version is 1.1.4 and the next release will be 1.1.5

Quote from: edi67 on February 23, 2009, 05:24:00 AM
NIBOGO: one little bug, permission for manage announcements NOT work for me, membergroups enabled to MANAGE them cannot create new announcements can ONLE edit one existent announcement, only admin can create new, others view only grey title not clickable, is possible give permission to create new to others usergroups ?

I will check that , thanks for report


drhamad

Does any editing need to be done for updating from 1.1.4?  (other than uploading the announcements.php/template/lang)
FMVperformance:  3.51m posts, 63k members, 11 boards, 1 database

Mazda3Forums - SmallVolvos - MazdaSpeeders Mazda Club - FordFusionClubMazda CX-7 Club - MyMazda6
Now introducing: MKSdrivers.com - FocusDrivers - TaurusDrivers

Özgür

Linktree not correctly work.
Announcements.php 299-303
        //Add the Linktree      
        $context['linktree'][] = array(
      'url' => $scripturl.'?action=announcements;sa=view;id=' . $announcementID,
      'name' => $context['announcement_edit_info']['title'],
        );     


507-511

   // Add the Linktree      
   $context['linktree'][] = array(
      'url' => $scripturl.'?action=announcements;sa=view;id=' . $announcementID,
      'name' => $context['announcement_title'],
   );

623-627

    // Add the Linktree      
   $context['linktree'][] = array(
      'url' => $scripturl.'?action=announcements;sa=view;id=' . $announcementID,
      'name' => $txt['yagam_editing_comment'],
   );   


sa=view;id= should be aid=

redirectexit not work correctly
Announcements.php 380

redirectexit('action=announcements;sa=view;id='.$_REQUEST['id'].'');

575

redirectexit('action=announcements;sa=view;id=' . $announcement_id);

678
redirectexit('action=announcements;sa=view;id=' . $announcement);
716
redirectexit('action=announcements;sa=view;id=' . $announcement);


Edit : And permission problem is here..
I want to ; Guest can see announcement body but cannot comment. But Guest can see comment area and try commenting get this "You can`t comment this announcement".
So Long

Nibogo

Version 1.1.6 - Feb 23, 2009
- Fixed the Linktree and Redirect Bugs with the new URL Style
- Changed all the ManagePermissions Edit , Now the guest can comment too (with the permission of course) and the Manage YAGAM is an Administrative Permission

I hope of this new version is stable , Don't worry about the bugs actually I don't think in add more features so I hope of YAGAM will not have any additional bug  :)

edi67

Installed the last version 1.1.6 and well i have some problem too,

1° for make view and manage announcements to others usergroups i must move to part of mod in Admin.php and put in there:
<search position="before"><![CDATA[ 'postsettings' => array(
'label' => $txt['manageposts'],
'file' => 'ManagePosts.php',
'function' => 'ManagePostSettings',
'permission' => array('admin_forum', 'moderate_forum'),
'icon' => 'posts.gif',
'subsections' => array(
'posts' => array($txt['manageposts_settings'], 'admin_forum'),
'hidetagspecial' => array($txt['manageposts_hidetagspecial_settings'], 'admin_forum'),
'bbc' => array($txt['manageposts_bbc_settings'], 'admin_forum'),
'censor' => array($txt['admin_censored_words'], 'moderate_forum'),
'topics' => array($txt['manageposts_topic_settings'], 'admin_forum'),
// Add the tab for the Highlight Message Backgrounds Mod Sub Action .
'highlightmessagebackgrounds' => array($txt['HighlightMessageBackgrounds_tab_heading'], 'admin_forum'),
),
),]]></search>
<add><![CDATA[
        'announcements' => array(
'label' => $txt['yagam_admin'],
'file' => 'Announcements.php',
'function' => 'AnnouncementsAdmin',
'custom_url' => $scripturl . '?action=announcements;sa=admin',
'icon' => 'yagam.gif',
),]]></add>


in this part work the manage announcements for others  users

2° i have same problem too with comments, users cannot comments announcements , appear error ( you not have permission to comment )

and also i want ask nibogo if is possible divide to the sticky topic from normal topic as announcements are divided from others
Thx nibogo i hope you solve these problem ;)

These are 2 errors in log:

When i try to edit one announcementes
http://crazyzone.biz/index.php?action=announcements;sa=edit;id=11
8: Undefined index: announcement_no_selected


When i try to comment:
http://crazyzone.biz/index.php?action=announcements;sa=commentverify;id=11
8: Undefined index: aid
CrazyZone - My SMF Forum


From the difficult the hardening of the man you can see

fords8

I installed 1.1.6 also and can't edit or delete announcements. Can't add comments either.

All of these give a:

QuoteAn Error Has Occurred!

100th post! Sweet!

drhamad

Yeah there's definitely a problem going on here.  Existing announcements work, but can't edit or create new ones.
FMVperformance:  3.51m posts, 63k members, 11 boards, 1 database

Mazda3Forums - SmallVolvos - MazdaSpeeders Mazda Club - FordFusionClubMazda CX-7 Club - MyMazda6
Now introducing: MKSdrivers.com - FocusDrivers - TaurusDrivers

fords8


Nibogo

Version 1.1.6.2 - Feb 23, 2009
- Fixed more bugs with the new URL Style
- Changed the admin.php editing with a new position of the YAGAM Panel and Add Global Announcement subsection
- More, more and yet more bug fixing

I really need a bug tracker for YAGAM

fords8

Quote from: NIBOGO on February 23, 2009, 07:31:24 PM
Version 1.1.6.2 - Feb 23, 2009
- Fixed more bugs with the new URL Style
- Changed the admin.php editing with a new position of the YAGAM Panel and Add Global Announcement subsection
- More, more and yet more bug fixing

I really need a bug tracker for YAGAM

All fixed for me! Nice work!

Advertisement: