Reply Button In Every Post

[sombra]

thanks for this great mod i think smf need more of this

[KahneFan]

...well. I looked, and I don't know how to change that

I'm open to suggestions.

[Chas Large]

...well. I looked, and I don't know how to change that

I'm open to suggestions.

Thanks for looking into it. I suppose the code for the ordinary REPLY button that is provided by SMF, that changes when a topic is locked, would be of help? I'll look into it myself.

[KahneFan]

I looked at that, but it's built different than the buttons on the top of each message. Let me know if you see how it can be applied though, and I'll be happy to add it in.

[Joe N]

Hey KahneFan

Very nice mod. One problem, one of my boards. I made it so the users couldn't reply. It still shows the reply button. It also shows it for guests as well and they can't post. 

[KahneFan]

In regards to guests, if you see above, it's by design that guests can see the button. This is left so that it may push guests to register. As for locked boards, if you look a couple of posts up, I don't know how to change that.

However, per my "Want My Mod?" thread, if anyone would like to take this over, just let me know. Please see the restrictions listed in the WMM thread as to what I ask in order to take a mod over.

[Joe N]

In regards to guests, if you see above, it's by design that guests can see the button. This is left so that it may push guests to register. As for locked boards, if you look a couple of posts up, I don't know how to change that.

However, per my "Want My Mod?" thread, if anyone would like to take this over, just let me know. Please see the restrictions listed in the WMM thread as to what I ask in order to take a mod over.

I did a topic on your over post

I would like to take over the reply button

[N3RVE]

As per the request here.

Code (Find) Select Expand


// These are some cache image buttons we may want.
$respond_button = create_button('reply.gif', 146, 146, 'align="middle"');

Code (Replace with) Select Expand


// These are some cache image buttons we may want.
if (!$context['is_locked'])
         echo
$respond_button = create_button('reply.gif', 146, 146, 'align="middle"');

-[n3rve]

[Antechinus]

Are you sure that will work? Usually the buttons are called inside other code, so if the code only calls $respond_button the  conditional statement wont be called with it, unless I'm missing something.

[Chas Large]

As per the request here.

Code (Find) Select Expand


// These are some cache image buttons we may want.
$respond_button = create_button('reply.gif', 146, 146, 'align="middle"');

Code (Replace with) Select Expand


// These are some cache image buttons we may want.
if (!$context['is_locked'])
echo
$respond_button = create_button('reply.gif', 146, 146, 'align="middle"');

-[n3rve]

Thank you [n3rve]. Editing Display.template.php worked fine and removed the REPLY button on all locked topics in all themes as required. I have learned something new today. Thanks again.
Chas.

[Chas Large]

OK Whilst the fix to remove the REPLY (RESPOND) Button in a locked topic works fine, anyone viewing a locked topic now generates the following error in the log:

8: Undefined variable: respond_button
File: /home/......./......./user/htdocs/forum/Themes/default/Display.template.php (main sub template - eval?)
Line: 394

Any way to quell this error? (Apart from removing the fix)

Chas

[Joe N]

For a member?

Forum URL please

Or screenshot?

Thanks

[Chas Large]

For a member?

Forum URL please

Or screenshot?

Thanks

For me?

Here's the complete error message.

Apply Filter: Only show the error messages of this member  Hal9000       Today at 11:52:56 AM
Apply Filter: Only show the error messages of this IP address ***.***.***.***      Apply Filter: Only show the error messages of this session 17e275d32a8b8f217878876f649e4fef
Apply Filter: Only show the error messages of this URL http://www.fiftyplusforum.co.uk/forum/index.php?topic=1009.0
Apply Filter: Only show the errors with the same message
8: Undefined variable: respond_button
File: /home/..../..../user/htdocs/forum/Themes/default/Display.template.php (main sub template - eval?)
Line: 394

Forum is included in the error

How does this help?

[Joe N]

What did you edit?

[Chas Large]

What did you edit?

As Per [Nerve]'s post http://www.simplemachines.org/community/index.php?topic=303592.msg2137888#msg2137888 I editied the display.template.php file. See above.
Chas.

PS See you registered to post. You'll have got the Joining e-mail automatically.

Have locked that post now so you can see the reply button has now gone.

[Joe N]

You will have to ask [n3rve] that as he did that code

Sorry 

[N3RVE]

Silly mistake, reverse the code changes you made and do this:

Code (Find) Select Expand


      if ($context['can_reply'] && !empty($options['display_quick_reply']))
      echo '<a href="#quickreply">', $respond_button, '</a>';
      else
      echo '<a href="', $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'], '">', $respond_button, '</a>';


Code (Replace) Select Expand


      if ($context['can_reply'] && !empty($options['display_quick_reply']))
      echo '<a href="#quickreply">', $respond_button, '</a>';
      elseif ($context['can_reply'])
      echo '<a href="', $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'], '">', $respond_button, '</a>';


-[n3rve]

[Chas Large]

Silly mistake, reverse the code changes you made and do this:

Code (Find) Select Expand


      if ($context['can_reply'] && !empty($options['display_quick_reply']))
      echo '<a href="#quickreply">', $respond_button, '</a>';
      else
      echo '<a href="', $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'], '">', $respond_button, '</a>';


Code (Replace) Select Expand


      if ($context['can_reply'] && !empty($options['display_quick_reply']))
      echo '<a href="#quickreply">', $respond_button, '</a>';
      elseif ($context['can_reply'])
      echo '<a href="', $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'], '">', $respond_button, '</a>';


-[n3rve]

Thanks again [n3rve], that fixed the issue and no errors in the list.
Cheers
Chas

[Grinch843]

Hi,

Is there anyway to force this to use the normal reply box no matter what the quick reply settings are? 

Thanks,
Grinch843.

[Joe N]

Hi,

Is there anyway to force this to use the normal reply box no matter what the quick reply settings are? 

Thanks,
Grinch843.

Just disable the quick reply