• Welcome to Simple Machines Community Forum. Please login or sign up.
December 02, 2021, 05:29:35 AM

News:

Want to get involved in developing SMF, then why not lend a hand on our github!


Post History

Started by niko, May 23, 2009, 01:02:36 AM

Previous topic - Next topic

Garou

A user mentioned to me that the "Last Edit: {date/time} by {name}"  displays the users login name rather then the display name. Two issues with this comes to mind.

First, if someone edits their own post, if their display name is different then their login name, it looks kind of weird since its showing one name in the poster information and then their login name with the edit information.

Second, while there are many reasons that the two names may be different, some users use the difference as a form of security. It makes it a little harder for someone to guess your password and log in as you when you log in with a different name then what is displayed everywhere else in the forum.

I had a user mention this to me and I feel it valid enough that I'm editing the function on the sites I work on. Soon as I figure it out ;)

I also though that Id mention it here because I do think its a valid point and you might want to change this in the mod.

niko

1.0 released for SMF 2.0 RC5. Mainly same as before except that it uses hooks when possible.
Websites: Madjoki || (2 links retracted by team, links out of date and taken over.)
Mods: SMF Arcade, Related topics, SMF Project Tools, Post History

WIP Mods: Bittorrent Tracker || SMF Wiki

Spoogs

Thanks for the update

ScottyTooHotty

May 17, 2011, 10:06:59 AM #103 Last Edit: May 17, 2011, 10:11:01 AM by ScottyTooHotty
Very nice mod, thanks. Installed this yesterday but found when I went to set up the permissions I got a syntax error on line 44 of PostHistory.php. There seemed to be an extra '+' infront of the '=' so I removed it and it seems to work fine now, except for the fact that I can't find the permission to enable or disable for certain member groups.

EDIT: Forgot to mention that I got this error in the error log when I tried to assign the permissions

2: in_array() [<a href='function.in-array'>function.in-array</a>]: Wrong datatype for second argument
File: /home/thelas13/public_html/Forum/Sources/ManagePermissions.php
Line: 869

niko

Line 44 was supposed to be: $permissionList['board'] += array( not $permissionList['post'] += array(

Change it and it should work. (Package is also fixed).
Websites: Madjoki || (2 links retracted by team, links out of date and taken over.)
Mods: SMF Arcade, Related topics, SMF Project Tools, Post History

WIP Mods: Bittorrent Tracker || SMF Wiki

ScottyTooHotty

Nice one Niko, all fixed now thanks :D

Spoogs

Cant uninstall 'Modification parse error'
package-info.xml
Code (find on line 50) Select
<modification format="xml" type="file" reverse="true">install-rc2.xml</modification>
Code (replace with) Select
<modification format="xml" type="file" reverse="true">install.xml</modification>

MordyT

Does this work with 2.0 Gold?
Want to see SMF in action? Head over to RvOClan.info

Illori

yes it does with the use of version emulation to install it.

niko

1.0.2 updated for SMF 2.0.1 (no code changes).
Source code is now available at https://github.com/nikop/PostHistory
Websites: Madjoki || (2 links retracted by team, links out of date and taken over.)
Mods: SMF Arcade, Related topics, SMF Project Tools, Post History

WIP Mods: Bittorrent Tracker || SMF Wiki

Kolya

Still throws white pages on many comparisons.

danielwmoore

Quote from: Kolya on March 17, 2010, 07:00:22 PM
Here's one more suggestion for Post History:
When writing a post I would like to be able to set a bit in the [Additional Options...] that makes the history of this post visible for everyone.

That way I could show the history eg of a FAQ, to users who generally aren't allowed to see post histories.
And a user who gets accused of having edited out some important part of his post (it happens) could then retroactively set this bit and show the history of his post to anyone.

I would like to see this as well.  I haven't downloaded yet, but it sounds like something I definitely want.  I would like to see the [Additional Options...] have a selection to decide whether the history is visible only to poster & moderators, or to everyone.  That would be invaluable, especially with our "Site Rules" topic, our FAQ, and in certain forum games where people may accuse others of changing a post after other gameplay has progressed.

niko

Released updated version for SMF 2.0.2 :)
Websites: Madjoki || (2 links retracted by team, links out of date and taken over.)
Mods: SMF Arcade, Related topics, SMF Project Tools, Post History

WIP Mods: Bittorrent Tracker || SMF Wiki

Kolya

What was changed? Is there a changelog anywhere?

MaXiForum.cz

Nice!
I love this mod ;-)

dvk01

it is a great mod but where can I get the image for the post history that should show in core features
all I get < forum name>/Themes/default/images/admin/feature_posthistory.png  (this file doesn't exist )

TheListener

Quote from: dvk01 on April 21, 2012, 12:37:27 PM
it is a great mod but where can I get the image for the post history that should show in core features
all I get < forum name>/Themes/default/images/admin/feature_posthistory.png  (this file doesn't exist )

Have you checked the default theme to see if it shows there?

dvk01

Quote from: Old Fossil on April 21, 2012, 12:38:19 PM


Have you checked the default theme to see if it shows there?

it doesn't show in any theme
I only have core & curve installed
I have installed it on 2 different forums & the image is missing in both

bugstomper

Niko, I've been looking for a way to have a permissions setting that would allow a user to edit their posts but hold the edits for moderation before making them visible. The part that I thought would be hard about it is that it would require multiple versions of a post to exist in the database, a current post and a draft that is being held for approval.

It occurs to me that your mod has solved the multiple version problem. Do you think it would be possible to add a feature that when someone edits a post they might have a permission setting that makes the latest version that they have edited not visible, and have that show up in the version history and a moderator having the ability to make the latest version visible?

The purpose of this is to have a way to prevent spammers who sign up for a new account, post normal looking messages, then come back to edit them to add spam to their messages. Holding the edits for approval is sometimes better than completely blocking the ability to edit posts.

niko

Quote from: bugstomper on June 11, 2012, 06:03:09 PM
Niko, I've been looking for a way to have a permissions setting that would allow a user to edit their posts but hold the edits for moderation before making them visible. The part that I thought would be hard about it is that it would require multiple versions of a post to exist in the database, a current post and a draft that is being held for approval.

It occurs to me that your mod has solved the multiple version problem. Do you think it would be possible to add a feature that when someone edits a post they might have a permission setting that makes the latest version that they have edited not visible, and have that show up in the version history and a moderator having the ability to make the latest version visible?

The purpose of this is to have a way to prevent spammers who sign up for a new account, post normal looking messages, then come back to edit them to add spam to their messages. Holding the edits for approval is sometimes better than completely blocking the ability to edit posts.

Sorry for late reply, but I think this is good idea and possible to do.
Websites: Madjoki || (2 links retracted by team, links out of date and taken over.)
Mods: SMF Arcade, Related topics, SMF Project Tools, Post History

WIP Mods: Bittorrent Tracker || SMF Wiki

Advertisement: