• Welcome to Simple Machines Community Forum. Please login or sign up.
January 28, 2022, 04:04:17 PM

News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord


Post History

Started by niko, May 23, 2009, 01:02:36 AM

Previous topic - Next topic

Groundhog

Hi Niko

The mod installed without any errors but after editing a message no edits were recorded. I checked and the post_history folder hadn't been installed. I uploaded it manually and the ran the install.php file but it returned this error message:

Fatal error: Function name must be a string in /home/******/public_html/home/post_history/Subs-Install.php on line 11

I am running v2.0 RC1 and I installed the Post_History_0.1.zip

Did I do something wrong?

Thanks for the help.

Eliana Tamerin

Congrats for a new release, Niko! Good work on incorporating my feature request, and a few other good new features. I can't wait to try it out.

If I were to upgrade from 1.0, would 2.0 b1 detect the has_history property on posts already made, or can that only be on posts made after upgrading to 2.0 b1?
Do NOT PM me for support.

SimplePortal 2.3.6 is OUT!
SimplePortal Project Manager
Download | Docs
SimplePortal: Power of Simplicity!

niko

Quote from: Eliana Tamerin on September 12, 2009, 10:19:53 PM
Congrats for a new release, Niko! Good work on incorporating my feature request, and a few other good new features. I can't wait to try it out.

If I were to upgrade from 1.0, would 2.0 b1 detect the has_history property on posts already made, or can that only be on posts made after upgrading to 2.0 b1?

It does work on old posts too.
Websites: Madjoki || (2 links retracted by team, links out of date and taken over.)
Mods: SMF Arcade, Related topics, SMF Project Tools, Post History

WIP Mods: Bittorrent Tracker || SMF Wiki

dakpluto

All I can say is THANK YOU THANK YOU THANK YOU THANK YOU THANK YOU.

Been wanting this on SMF for ages.

ttuu

Quote from: Eliana Tamerin on May 23, 2009, 01:57:35 AM
Oh wow, Niko, you are amazing. This is exactly the kind of useful mod that we need more of for SMF 2, just simple little mods that add uniquely useful features that SMF would never natively include.

Oh, and Blinker, if you need this feature on SMF 1.1.x, then use this mod instead: http://custom.simplemachines.org/mods/index.php?mod=1007. It adds a 'delete spam post' feature as well, which overwrites the message's content with the spam message, but has the optional side effect of recording all edits of posts in the Recycle Bin.

its good idea for deleted post but not for edit post.

Eliana Tamerin

Quote from: ttuu on September 13, 2009, 09:38:12 AM
Quote from: Eliana Tamerin on May 23, 2009, 01:57:35 AM
Oh wow, Niko, you are amazing. This is exactly the kind of useful mod that we need more of for SMF 2, just simple little mods that add uniquely useful features that SMF would never natively include.

Oh, and Blinker, if you need this feature on SMF 1.1.x, then use this mod instead: http://custom.simplemachines.org/mods/index.php?mod=1007. It adds a 'delete spam post' feature as well, which overwrites the message's content with the spam message, but has the optional side effect of recording all edits of posts in the Recycle Bin.

its good idea for deleted post but not for edit post.

Well, it's a solution, regardless of the lack of polish like this mod has, that works unless/until a mod like this is backported.
Do NOT PM me for support.

SimplePortal 2.3.6 is OUT!
SimplePortal Project Manager
Download | Docs
SimplePortal: Power of Simplicity!

Shark-Time

nice mod ...can you make one for 1.1.x version..


Providing Cheapest Offshore Hosting as low as 5$/year.
MoneyBookers | AlertPay
Pm Me

niko

Quote from: Shark-Time on September 13, 2009, 10:35:53 AM
nice mod ...can you make one for 1.1.x version..

No. I don't have time to do.
Websites: Madjoki || (2 links retracted by team, links out of date and taken over.)
Mods: SMF Arcade, Related topics, SMF Project Tools, Post History

WIP Mods: Bittorrent Tracker || SMF Wiki

Özgür

Great mod Niko.
I guess Alpay don't have time for update his translate.
This is 2.0 turkish translate.
<?xml version="1.0"?>
<?xml-stylesheet href="modification.xsl" type="text/xsl"?>
<!DOCTYPE modification SYSTEM "http://www.simplemachines.org/xml/modification">
<!-- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

ATTENTION: If you are trying to install this manually, you should try
the package manager.  If it will not work for you, please take a look
at the following for information on this format:
http://mods.simplemachines.org/docs/manual-install.php

================================================================================

Modification files can be used to modify files so that they do what
your package needs them to do to work properly.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -->

<modification xmlns="http://www.simplemachines.org/xml/modification" xmlns:smf="http://www.simplemachines.org/">
<!-- This information needs to be the same as that in the package-info.xml. -->
<id>Niko:PostHistory</id>
<version>{version}</version>

<file name="$languagedir/Modifications.turkish.php" error="ignore">
<operation>
<search position="end" />
<add><![CDATA[// Post History Start
$txt['core_settings_item_posthistory'] = 'İleti Geçmişi';
$txt['core_settings_item_posthistory_desc'] = 'Veritabanında ki İleti geçmişleri.';

$txt['view_post_history'] = 'İleti Geçmişini Görüntüle';
$txt['title_view_post_history'] = 'İleti Geçmişi Görüntüleniyor - %1$s';

$txt['ph_last_edit'] = 'Son Düzenleme';
$txt['ph_last_time'] = 'Düzenleme Zamanı';
$txt['ph_view_edit'] = 'İletiyi Görüntüle';

// Untranslated
$txt['ph_original_edit'] = 'Orjinal';
// Untranslated
$txt['ph_current_edit'] = 'Şuanki';
// Untranslated
$txt['ph_current_original_edit'] = 'şuanki, original';

$txt['ph_no_edits'] = 'Konuda henüz bir düzenleme yok';

$txt['permissionname_posthistory_view'] = 'İleti düzenleme geçmişini görüntüle';
$txt['permissionhelp_posthistory_view'] = 'Eski İleti geçmişini görüntüle';
$txt['permissionname_posthistory_view_own'] = 'Kendi Konusunu';
$txt['permissionname_posthistory_view_any'] = 'Herhangibir Konuyu';
$txt['permissionname_simple_posthistory_view_own'] = 'Kendi İletilerinin geçmişini düzenleme';
$txt['permissionname_simple_posthistory_view_any'] = 'Herhangibir İletinin geçmişini düzenleme';

$txt['cannot_posthistory_view_any'] = 'Bu yazının ileti geçmişi görünmesin!';
// Post History END]]></add>
</operation>
</file>
</modification>

So Long

Alpay

Thanks, [Daydreamer] =)

I guess I can not catch up with translations :(

Joe N

Quote from: [Daydreamer] on September 14, 2009, 05:38:33 AM
Great mod Niko.
I guess Alpay don't have time for update his translate.
This is 2.0 turkish translate.
<?xml version="1.0"?>
<?xml-stylesheet href="modification.xsl" type="text/xsl"?>
<!DOCTYPE modification SYSTEM "http://www.simplemachines.org/xml/modification">
<!-- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

ATTENTION: If you are trying to install this manually, you should try
the package manager.  If it will not work for you, please take a look
at the following for information on this format:
http://mods.simplemachines.org/docs/manual-install.php

================================================================================

Modification files can be used to modify files so that they do what
your package needs them to do to work properly.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -->

<modification xmlns="http://www.simplemachines.org/xml/modification" xmlns:smf="http://www.simplemachines.org/">
<!-- This information needs to be the same as that in the package-info.xml. -->
<id>Niko:PostHistory</id>
<version>{version}</version>

<file name="$languagedir/Modifications.turkish.php" error="ignore">
<operation>
<search position="end" />
<add><![CDATA[// Post History Start
$txt['core_settings_item_posthistory'] = 'İleti Geçmişi';
$txt['core_settings_item_posthistory_desc'] = 'Veritabanında ki İleti geçmişleri.';

$txt['view_post_history'] = 'İleti Geçmişini Görüntüle';
$txt['title_view_post_history'] = 'İleti Geçmişi Görüntüleniyor - %1$s';

$txt['ph_last_edit'] = 'Son Düzenleme';
$txt['ph_last_time'] = 'Düzenleme Zamanı';
$txt['ph_view_edit'] = 'İletiyi Görüntüle';

// Untranslated
$txt['ph_original_edit'] = 'Orjinal';
// Untranslated
$txt['ph_current_edit'] = 'Şuanki';
// Untranslated
$txt['ph_current_original_edit'] = 'şuanki, original';

$txt['ph_no_edits'] = 'Konuda henüz bir düzenleme yok';

$txt['permissionname_posthistory_view'] = 'İleti düzenleme geçmişini görüntüle';
$txt['permissionhelp_posthistory_view'] = 'Eski İleti geçmişini görüntüle';
$txt['permissionname_posthistory_view_own'] = 'Kendi Konusunu';
$txt['permissionname_posthistory_view_any'] = 'Herhangibir Konuyu';
$txt['permissionname_simple_posthistory_view_own'] = 'Kendi İletilerinin geçmişini düzenleme';
$txt['permissionname_simple_posthistory_view_any'] = 'Herhangibir İletinin geçmişini düzenleme';

$txt['cannot_posthistory_view_any'] = 'Bu yazının ileti geçmişi görünmesin!';
// Post History END]]></add>
</operation>
</file>
</modification>



Nice
Microsoft: "We Need to Imagine Life Without Walls."
I Say: "If There are No Walls Who needs Windows."



My Mods (6) All My Mods Updated To SMF 2.0 RC2 and SMF 1.1.10!


Groundhog

Quote from: Groundhog on September 12, 2009, 06:17:01 PM
Hi Niko

The mod installed without any errors but after editing a message no edits were recorded. I checked and the post_history folder hadn't been installed. I uploaded it manually and the ran the install.php file but it returned this error message:

Fatal error: Function name must be a string in /home/******/public_html/home/post_history/Subs-Install.php on line 11

I am running v2.0 RC1 and I installed the Post_History_0.1.zip

Did I do something wrong?

Thanks for the help.

Just wondering if you had any idea   :-\

dakpluto

Hoping this comes to RC2 soon.  This is a valuable plugin for my forum.

niko

Uploaded version with RC2.0 support. (0.2 Beta 2)
Websites: Madjoki || (2 links retracted by team, links out of date and taken over.)
Mods: SMF Arcade, Related topics, SMF Project Tools, Post History

WIP Mods: Bittorrent Tracker || SMF Wiki

Eliana Tamerin

Suggestion, Niko. I've modded my own version to put the link before the Report to moderator link, since I think that makes more sense for the action. It's not modifying the post at all (which the buttons in that strip, aside from Quote, all do in some way), it's just accessing minor information. Which is similar to the IP that's logged for each post.

Plus, with smaller screens and fixed width themes, and even with Curve's new fixed proportions display template (which is a godsend), the buttons generally wind up dropping down to a new line. This isn't an ideal situation, and so I think putting the link down near the Report to moderator link would make more sense and prevent the template from looking cluttered.

Besides, when someone sees the  « Last Edit: Month Day, Year, HH:MM:SS PM by displayname », the link to viewing edits of the post will be right below it and users would connect the two thoughts much easier than if the button were at the top.
Do NOT PM me for support.

SimplePortal 2.3.6 is OUT!
SimplePortal Project Manager
Download | Docs
SimplePortal: Power of Simplicity!

niko

Quote from: Eliana Tamerin on November 13, 2009, 06:29:23 PM
Suggestion, Niko. I've modded my own version to put the link before the Report to moderator link, since I think that makes more sense for the action. It's not modifying the post at all (which the buttons in that strip, aside from Quote, all do in some way), it's just accessing minor information. Which is similar to the IP that's logged for each post.

Plus, with smaller screens and fixed width themes, and even with Curve's new fixed proportions display template (which is a godsend), the buttons generally wind up dropping down to a new line. This isn't an ideal situation, and so I think putting the link down near the Report to moderator link would make more sense and prevent the template from looking cluttered.

Besides, when someone sees the  « Last Edit: Month Day, Year, HH:MM:SS PM by displayname », the link to viewing edits of the post will be right below it and users would connect the two thoughts much easier than if the button were at the top.

Good idea.
Websites: Madjoki || (2 links retracted by team, links out of date and taken over.)
Mods: SMF Arcade, Related topics, SMF Project Tools, Post History

WIP Mods: Bittorrent Tracker || SMF Wiki

dakpluto

Thank you so much for the update!

And I agree with above on the location.  And the most ideal would be like Vbullitien and make the "last edit by" line clickable to the post history.

Oh, and I am have a little history with the current Beta 2.  The link to the post history is there, but there is no visible button.  I can hover my mouse where it should be and find it though.

Eliana Tamerin

Quote from: dakpluto on November 15, 2009, 08:29:54 AM
And I agree with above on the location.  And the most ideal would be like Vbullitien and make the "last edit by" line clickable to the post history.

Except SMF has a courtesy time (by default, 90 seconds) to edit before its logged on the post. The View Edits button will show up even if the Last Edit By... line isn't there. So you would miss out on all the edits that took place within 90 seconds.
Do NOT PM me for support.

SimplePortal 2.3.6 is OUT!
SimplePortal Project Manager
Download | Docs
SimplePortal: Power of Simplicity!

Arcturus

Mod just installed. Can't believe I now have post revisions in my forum. This is totally awesome o_O Thank you very very very very much !

Advertisement: