Advertisement:

Author Topic: Disable Subject Change  (Read 26377 times)

Offline aw06

  • SMF Hero
  • ******
  • Posts: 2,763
  • Gender: Male
  • Make The Link
    • shopinja.classifieds on Facebook
    • @shopinja on Twitter
    • ShopinJA.com
Re: Disable Subject Change
« Reply #20 on: September 07, 2009, 11:21:00 PM »
done .. i hope to see an update sometime in this quarter hehe
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Offline aw06

  • SMF Hero
  • ******
  • Posts: 2,763
  • Gender: Male
  • Make The Link
    • shopinja.classifieds on Facebook
    • @shopinja on Twitter
    • ShopinJA.com
Re: Disable Subject Change
« Reply #21 on: September 13, 2009, 08:29:51 PM »
thanks for the update ... so admin can now edit the subjects ...

can the original topic starter edit as well ?
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Offline tyty1234

  • SMF Hero
  • ******
  • Posts: 2,132
  • Gender: Male
  • <?php give_support(); ?>
    • tyty1234's SMF Site
Re: Disable Subject Change
« Reply #22 on: September 13, 2009, 09:00:52 PM »
should be able to. If not, let me know. :)
My Activity: Inactive
My Links: tyty1234's SMF Site | SMF Package Parser | SMF Helper | My Mods [5]
Subscribe to my SMF blog for updates
PMs for support will not be accepted, unless requested otherwise.

Offline Smog

  • Jr. Member
  • **
  • Posts: 149
  • veritas odium parit
    • Smokey's Security Forums
Re: Disable Subject Change
« Reply #23 on: September 25, 2009, 05:57:53 PM »
Installed Disable Subject Change v1.2 on SMF 2.0 RC1.2, admins can't change the subject...

Offline tyty1234

  • SMF Hero
  • ******
  • Posts: 2,132
  • Gender: Male
  • <?php give_support(); ?>
    • tyty1234's SMF Site
Re: Disable Subject Change
« Reply #24 on: September 26, 2009, 01:43:46 AM »
Fixed in version 1.3 :)
My Activity: Inactive
My Links: tyty1234's SMF Site | SMF Package Parser | SMF Helper | My Mods [5]
Subscribe to my SMF blog for updates
PMs for support will not be accepted, unless requested otherwise.


Offline aw06

  • SMF Hero
  • ******
  • Posts: 2,763
  • Gender: Male
  • Make The Link
    • shopinja.classifieds on Facebook
    • @shopinja on Twitter
    • ShopinJA.com
Re: Disable Subject Change
« Reply #26 on: September 26, 2009, 09:40:56 AM »
can original topic starters change subject as well ?
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Offline tyty1234

  • SMF Hero
  • ******
  • Posts: 2,132
  • Gender: Male
  • <?php give_support(); ?>
    • tyty1234's SMF Site
Re: Disable Subject Change
« Reply #27 on: September 27, 2009, 08:26:58 PM »
can original topic starters change subject as well ?

Original topic starters can only change the subject of the OP, thus, changing the subject for all replies that were added after the subject of the OP was changed.
My Activity: Inactive
My Links: tyty1234's SMF Site | SMF Package Parser | SMF Helper | My Mods [5]
Subscribe to my SMF blog for updates
PMs for support will not be accepted, unless requested otherwise.

Offline aw06

  • SMF Hero
  • ******
  • Posts: 2,763
  • Gender: Male
  • Make The Link
    • shopinja.classifieds on Facebook
    • @shopinja on Twitter
    • ShopinJA.com
Re: Disable Subject Change
« Reply #28 on: September 27, 2009, 08:47:16 PM »
can original topic starters change subject as well ?

Original topic starters can only change the subject of the OP, thus, changing the subject for all replies that were added after the subject of the OP was changed.

Niceee  8)
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Offline aw06

  • SMF Hero
  • ******
  • Posts: 2,763
  • Gender: Male
  • Make The Link
    • shopinja.classifieds on Facebook
    • @shopinja on Twitter
    • ShopinJA.com
Re: Disable Subject Change
« Reply #29 on: September 27, 2009, 09:07:55 PM »
ok, i have new style message icon mod installed .. and its conflicting with this mod ... can you take a look at my post.template.php  ...

I installed version 1.3 and as admin it can't seem to edit the subjects ... i tried to edits you suggested to me on the first page of this thread, but it still does not work...
« Last Edit: September 27, 2009, 09:40:07 PM by aw06 »
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Offline aw06

  • SMF Hero
  • ******
  • Posts: 2,763
  • Gender: Male
  • Make The Link
    • shopinja.classifieds on Facebook
    • @shopinja on Twitter
    • ShopinJA.com
Re: Disable Subject Change
« Reply #30 on: September 27, 2009, 09:51:28 PM »
ahhh nevermind ... my mistake  :P was using code from old version ... get it sorted and error free now ..
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Offline aw06

  • SMF Hero
  • ******
  • Posts: 2,763
  • Gender: Male
  • Make The Link
    • shopinja.classifieds on Facebook
    • @shopinja on Twitter
    • ShopinJA.com
Re: Disable Subject Change
« Reply #31 on: September 27, 2009, 10:02:49 PM »
can original topic starters change subject as well ?

Original topic starters can only change the subject of the OP, thus, changing the subject for all replies that were added after the subject of the OP was changed.

Hmmm, just tested this ... not the case  :-[ original topic starters CANT modify subject of the original post  :(

Cand everybody can edit via quick/inline edit
« Last Edit: September 27, 2009, 10:09:04 PM by aw06 »
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Offline tyty1234

  • SMF Hero
  • ******
  • Posts: 2,132
  • Gender: Male
  • <?php give_support(); ?>
    • tyty1234's SMF Site
Re: Disable Subject Change
« Reply #32 on: September 28, 2009, 02:49:56 AM »
can original topic starters change subject as well ?

Original topic starters can only change the subject of the OP, thus, changing the subject for all replies that were added after the subject of the OP was changed.

Hmmm, just tested this ... not the case  :-[ original topic starters CANT modify subject of the original post  :(

Cand everybody can edit via quick/inline edit

Thanks for letting me know. I have released a new version that addresses these issues. :)
My Activity: Inactive
My Links: tyty1234's SMF Site | SMF Package Parser | SMF Helper | My Mods [5]
Subscribe to my SMF blog for updates
PMs for support will not be accepted, unless requested otherwise.

Offline aw06

  • SMF Hero
  • ******
  • Posts: 2,763
  • Gender: Male
  • Make The Link
    • shopinja.classifieds on Facebook
    • @shopinja on Twitter
    • ShopinJA.com
Re: Disable Subject Change
« Reply #33 on: September 28, 2009, 08:36:09 AM »
can original topic starters change subject as well ?

Original topic starters can only change the subject of the OP, thus, changing the subject for all replies that were added after the subject of the OP was changed.

Hmmm, just tested this ... not the case  :-[ original topic starters CANT modify subject of the original post  :(

Cand everybody can edit via quick/inline edit

Thanks for letting me know. I have released a new version that addresses these issues. :)

Wow .. thanks for the quick update ... do we un-install the 1.3 totally, or this new version will install and overwrite it ?

Are the new chanages only done in Post.template.php and Display.template.php ? can i just go ahead and add those edits manually while still under version 1.3 ?

****sniper edit****
Made changes to the files above .. all seems to be working and error free now ...  :P
« Last Edit: September 28, 2009, 09:00:07 AM by aw06 »
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Offline aw06

  • SMF Hero
  • ******
  • Posts: 2,763
  • Gender: Male
  • Make The Link
    • shopinja.classifieds on Facebook
    • @shopinja on Twitter
    • ShopinJA.com
Re: Disable Subject Change
« Reply #34 on: September 28, 2009, 06:34:22 PM »
Someone mad a reply to their own topic and this came up as the subject

%subject%

any ideas ??

......................

OK, i see what's happening, when a user uses the inlink/quick edit, when they hit save it changes the subject to %subject% :o

Seems to be related to this part of the codeing

Quote
var smf_template_subject_edit = \'', $modSettings['disableSubjectChange'] ? $context['user']['is_admin'] ? '' : '%subject%' . '&nbsp;' : '', '<input type="', $modSettings['disableSubjectChange'] ? $context['user']['is_admin'] ? 'text' : 'hidden' : 'text', '" name="subject" value="%subject%" size="60" style="width: 99%;"  maxlength="80" />\';

« Last Edit: September 28, 2009, 07:29:00 PM by aw06 »
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Offline aw06

  • SMF Hero
  • ******
  • Posts: 2,763
  • Gender: Male
  • Make The Link
    • shopinja.classifieds on Facebook
    • @shopinja on Twitter
    • ShopinJA.com
Re: Disable Subject Change
« Reply #35 on: September 28, 2009, 08:05:45 PM »
OK, as a fix i replaced

This Code
Quote
var smf_template_subject_edit = \'', $modSettings['disableSubjectChange'] ? $context['user']['is_admin'] ? '' : '%subject%' . '&nbsp;' : '', '<input type="', $modSettings['disableSubjectChange'] ? $context['user']['is_admin'] ? 'text' : 'hidden' : 'text', '" name="subject" value="%subject%" size="60" style="width: 99%;"  maxlength="80" />\';

With
Quote
var smf_template_subject_edit = \'', $modSettings['disableSubjectChange'] ? $context['user']['is_admin'] ? '' : '%subject%' . '&nbsp;' : '', '<input type="', $modSettings['disableSubjectChange'] ? $context['user']['is_admin'] ? 'text' : 'hidden' : 'text', '" name="subject"', $context['subject'] == '' ? '' : ' value="' . $context['subject'] . '"', ' tabindex="', $context['tabindex']++, '" size="60" style="width: 99%;"  maxlength="80" />\';

Error logs are clean ... but i don't know if this is the correct way to fix .. please advise ..
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Offline tyty1234

  • SMF Hero
  • ******
  • Posts: 2,132
  • Gender: Male
  • <?php give_support(); ?>
    • tyty1234's SMF Site
Re: Disable Subject Change
« Reply #36 on: September 28, 2009, 11:31:47 PM »
1. It's recommended you uninstall 1.3 before installing 1.4, that way, you don't need to make manual edits unless it was necessary.

2. %subject% is a JavaScript that is replaced using XML I believe. The reason why it's %subject%, is so it gets the subject of the message, not the subject of the topic. (e.g. If the subject of the message was Re: Disable Subject Change, %subject% will be replaced with the "Re: Disable Subject Change". However, if you used $context['subject'], then that will be replaced by "Disable Subject Change", which is what you don't want. I will however find a possible solution, so I will see what I can do with it.
My Activity: Inactive
My Links: tyty1234's SMF Site | SMF Package Parser | SMF Helper | My Mods [5]
Subscribe to my SMF blog for updates
PMs for support will not be accepted, unless requested otherwise.

Offline aw06

  • SMF Hero
  • ******
  • Posts: 2,763
  • Gender: Male
  • Make The Link
    • shopinja.classifieds on Facebook
    • @shopinja on Twitter
    • ShopinJA.com
Re: Disable Subject Change
« Reply #37 on: September 28, 2009, 11:43:59 PM »
Yup, you are right,,, i just notice what happens when i use the fix i did ..... It puts back the original first post subject ... and not a Re: Subject as you pointed out ...

Hoping you find a fix soon :)

how about trying $context['%subject%'] ???
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Offline tyty1234

  • SMF Hero
  • ******
  • Posts: 2,132
  • Gender: Male
  • <?php give_support(); ?>
    • tyty1234's SMF Site
Re: Disable Subject Change
« Reply #38 on: September 29, 2009, 12:04:52 AM »
$context['%subject%'] does not exist and therefore will not work.
My Activity: Inactive
My Links: tyty1234's SMF Site | SMF Package Parser | SMF Helper | My Mods [5]
Subscribe to my SMF blog for updates
PMs for support will not be accepted, unless requested otherwise.

Offline aw06

  • SMF Hero
  • ******
  • Posts: 2,763
  • Gender: Male
  • Make The Link
    • shopinja.classifieds on Facebook
    • @shopinja on Twitter
    • ShopinJA.com
Re: Disable Subject Change
« Reply #39 on: September 29, 2009, 12:09:29 AM »
$context['%subject%'] does not exist and therefore will not work.

 8) ok .. figured as much ... will wait on your fix :)
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth