Smileys and Message icons hardcoded (RC1.2)

Started by Axeia, November 03, 2009, 11:17:46 AM

Previous topic - Next topic

Axeia

The Smileys and Messages icons part of the admin area ( /index.php?action=admin;area=smileys;sa=editsmileys ) becomes quite a mess if you add a new folder with icons not present in the default theme.

In the first column it adds the images as a preview, but it always bases the image source (src) on the default theme. This seems rather odd since in the  5th column it actually states it knows that particular icon isn't in the folder... so why not base the source of the image on (one of the ) the folder(s) it knows the image exists in?

[edit]
Just for reference, the file in question is "ManageSmileys.php" in the Sources folder.
The relevant lines are line 922 (this is where the wrong the url is used)
Line 990-998. This is where I suspect the value that should be there is accessible.

SleePy

This is intended this way.  All your sets should have an image for each smiley.
Jeremy D ~ Site Team / SMF Developer ~ GitHub Profile ~ Join us on IRC @ Libera.chat/#smf ~ Support the SMF Support team!

Advertisement: