Advertisement:

Author Topic: Quick Spoiler  (Read 62668 times)

Offline Saiy

  • Semi-Newbie
  • *
  • Posts: 14
Re: Quick Spoiler
« Reply #140 on: October 08, 2019, 02:59:48 PM »
Dear friends, I'm sorry, but I can't make it work on my forum -->  bit . ly / 2MrY7dw
I just updated on SMF 2.1 RC2, and I upgraded to Quick Spoilers 2.1.
... Any idea please ? The "spoilers" are indeen hidden, but the click to open the spoiler doesn't work with me...

Offline Gandrel

  • Semi-Newbie
  • *
  • Posts: 34
    • The Outer Rim Garrison Forum
Re: Quick Spoiler
« Reply #141 on: January 08, 2020, 03:38:17 AM »
Under "Modification Settings" when I try to change anything, like set the colour to Red and click the Save button, I'm getting the following error message:

Code: [Select]
DATABASE ERROR

Duplicate entry '0-view_spoiler' for key 'PRIMARY'
File: /home/outerrim/public_html/forums/Sources/ManagePermissions.php
Line: 1843

Has anyone seen this before and if there's a fix? I'm running 2.0.15 with the Sunrise theme and PHP 7.1.

Offline Gandrel

  • Semi-Newbie
  • *
  • Posts: 34
    • The Outer Rim Garrison Forum
Re: Quick Spoiler
« Reply #142 on: January 08, 2020, 03:44:56 AM »
Here's my ManagePermissions.php file as well

Offline Bugo

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 1,659
  • Gender: Male
    • dragomano on GitHub
    • Support me on Ko-fi
Re: Quick Spoiler
« Reply #143 on: January 08, 2020, 05:58:34 AM »
Open phpMyAdmin, run this SQL script:
Code: [Select]
DELETE FROM smf_permissions
WHERE permission = "view_spoiler"

Then set spoiler permissions again.

Offline Gandrel

  • Semi-Newbie
  • *
  • Posts: 34
    • The Outer Rim Garrison Forum
Re: Quick Spoiler
« Reply #144 on: January 11, 2020, 01:04:12 AM »
Open phpMyAdmin, run this SQL script:
Code: [Select]
DELETE FROM smf_permissions
WHERE permission = "view_spoiler"

Then set spoiler permissions again.

Does this permission get set during the mod installation and if so, does it not get removed when the mod is uninstalled? I've tried to reinstall and uninstall it with no luck.

Offline dodos26

  • Semi-Newbie
  • *
  • Posts: 58
Re: Quick Spoiler
« Reply #145 on: February 05, 2020, 06:06:35 PM »
i find bug :(  See attach

Offline dodos26

  • Semi-Newbie
  • *
  • Posts: 58
Re: Quick Spoiler
« Reply #146 on: February 08, 2020, 06:13:40 PM »
How fix it?

Offline Bugo

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 1,659
  • Gender: Male
    • dragomano on GitHub
    • Support me on Ko-fi
Re: Quick Spoiler
« Reply #147 on: February 08, 2020, 09:23:06 PM »
Install the new version?

Offline dodos26

  • Semi-Newbie
  • *
  • Posts: 58
Re: Quick Spoiler
« Reply #148 on: February 09, 2020, 07:35:51 PM »
Thanks now work good :)

Offline Maxxim

  • Newbie
  • *
  • Posts: 6
Re: Quick Spoiler
« Reply #149 on: June 02, 2020, 12:48:06 AM »
An essential part of my (2.0.17) forum is TinyPortal, and it's already using jQuery:
Code: [Select]
// Load JQuery if it's not set (anticipated for SMF2.1)
    if(strpos($forum_version, '2.0') !== false && !isset($modSettings['jquery_source'])) {
$context['html_headers'] .= '<script src="https://code.jquery.com/jquery-3.3.1.min.js"></script>';
    }

Can I avoid unnecessarily loading two jQuery scripts by simply deleting the following line
Code: [Select]
<script type="text/javascript">window.jQuery || document.write(unescape(\'%3Cscript src="//code.jquery.com/jquery.min.js"%3E%3C/script%3E\'))</script>from Sources\Class-QuickSpoiler.php?

Or is it not that easy? :) Please advise.

Offline Bugo

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 1,659
  • Gender: Male
    • dragomano on GitHub
    • Support me on Ko-fi
Re: Quick Spoiler
« Reply #150 on: June 02, 2020, 03:22:07 AM »
Don't worry about this. The script is checking if jQuery has already loaded, and not must load twice.

Offline kilk

  • Semi-Newbie
  • *
  • Posts: 25
    • Elddem The MMORPG
Re: Quick Spoiler
« Reply #151 on: June 09, 2020, 04:02:59 PM »
Solid mod! Good work!
Elddem The MMORPG - https://www.elddem.com | Denarius (D) Cryptocurrrency - https://www.denarius.io | BlockForums - Cryptocurrency Community Forums - https://www.blockforums.org

Offline James Gryphon

  • Semi-Newbie
  • *
  • Posts: 73
  • Gender: Male
Re: Quick Spoiler
« Reply #152 on: January 30, 2021, 06:30:30 AM »
I switched to this mod after discovering an obscure problem in AzaToth's old Spoiler Tag mod. As it turns out, it looks as though the same thing happens here, but the good thing about using a new mod is that its issues are more likely to be fixed.

The glitch takes a very specific series of events to trigger; it looks like if someone posts a quote, then a broken spoiler tag, then BBCode right after the broken spoiler tag, the forumposts div is closed earlier than it should be.

A sample post that should be able to replicate this:
Code: [Select]
And here are the past versions.

[quote][spoiler=v0.1[center]Note to reader: This has not, I repeat, has not been exaggerated and please take extreme caution around the nuclear war heads.

[/center][/spoiler][/quote]

One triggering post is not very noticeable, especially on a theme like Curve where there aren't many distinct borders or backgrounds. The page rendering gets more broken after a second similar post: the content goes outside of the wrapper div, so that if you have a body or html background, the content shows up on top of it instead of the wrapper background. Further similar posts don't seem to make the problem any worse (or better). Other than the appearance and layout of things, there doesn't seem to be any obvious impact on forum functionality.

The problem should be reproducible on any forum that uses this mod or the old Spoiler Tag 0.7.2 mod. Of course, you don't have any control over the latter mod; I just mention it so that people who feel this is a problem might know to look into changing.

Offline Bugo

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 1,659
  • Gender: Male
    • dragomano on GitHub
    • Support me on Ko-fi
Re: Quick Spoiler
« Reply #153 on: January 30, 2021, 07:22:29 AM »
I see one missing bracket after the spoiler title. Just add it and everything will work fine.

Offline James Gryphon

  • Semi-Newbie
  • *
  • Posts: 73
  • Gender: Male
Re: Quick Spoiler
« Reply #154 on: January 30, 2021, 08:15:07 AM »
Well, yes, posts that have this problem can be easily fixed; I did that while I was experimenting trying to find out more about what causes the problem.

It is a defect, though, when any member can accidentally or intentionally break the entire page layout by putting in defective BBCode.