yabb_to_smf dies at step 12

[countludwig]

the page looks like this:


Converting posts (part 3)... successful.
Converting posts (part 3)... successful.
Converting posts (part 3)... successful.
Converting posts (part 3)... successful.
Converting posts (part 3)... successful.
Converting posts (part 3)... success


seems like it gets stuck in some kind of loop.
here is the url

/yabb_to_smf.php?step=12&start=2400

I've run it in both ie and firefox with the same result, however the ending number on the url
is not always the same.

one other thing, I ran an older version of the converter last month as I was preparing
to move my board to smf and that one ran fine. I don't however have a copy of the
old one....

have any ideas on this ?


thanks

-Ron

[[Unknown]]

Please try this one.

-[Unknown]

[Russell G.]

I found the same problem, and I think I know why it's happening.  On line 1716, in function doStep13(), it does this:

if (!isset($yabb['upload_dir']))
     return doStep12();

I should say this:

if (!isset($yabb['upload_dir']))
     return doStep14();

The problem only happens if "upload_dir" isn't set in hxxp:settings.pl [nonactive], which is the case with my installation (and yours as well).  If you change the line as above, the script runs through just fine.

One other bug in this script...

On line 363, in function doStep2(), it does this while it's loading each of the member files:

$row['passwd'] = md5($userData[0]);

But if the file is zero length (which seems to happen occasionally with Yabb), it gives an error saying "Undefined offset: 0".  But the script continues on, fortunately.

Thanks,
Russell

[[Unknown]]

My version does not have that error; neither does the one on the downloads page.

-[Unknown]

[Russell G.]

My version does not have that error; neither does the one on the downloads page.

-[Unknown]

I'm sorry, but I believe you're mistaken.  I downloaded the "yabb_to_smf" converter (not the "yabbse" converter) for the first time, today.  I've never even been to this web site before, so it's not possible that I could have been looking at an old cached version.  Please take another look:

http://www.simplemachines.org/download.php/yabb_to_smf.php

Thanks,
Russell

[[Unknown]]

If you're sure, I'll just upload it again.  But I remember uploading it the other day because I made a slight change.

-[Unknown]

[Russell G.]

The downloads page was originally showing "yabb_to_smf.php (May 09, 2005)", but I see now that you've updated it (July 06, 2005), and the new file is indeed fixed.  Well, at least the major problem is fixed -- the warning will still be displayed for empty member files, but that's no big deal.

Thanks for the quick turnaround.

Russell