Advertisement:

Author Topic: Finnish lang pack for RC3 has english buttonz.  (Read 2367 times)

Offline Owdy

  • SMF Fossil
  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 15,628
  • Gender: Male
  • W00t!
    • janoloferiksson on LinkedIn
    • @@jaoler on Twitter
Finnish lang pack for RC3 has english buttonz.
« on: April 11, 2010, 08:34:10 AM »
^
/Themes/babylon/images/finnish-utf8/
« Last Edit: July 19, 2010, 01:55:33 PM by TE »
Former Lead Support Specialist

Tarvitsetko apua SMF foorumisi kanssa? Otan työtehtäviä vastaan, lue:http://www.simplemachines.org/community/index.php?topic=375918.0

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #1 on: April 11, 2010, 08:41:37 AM »
That's because no-one ever remade the images for other languages. Since Babylonking doesn't appear to be around, and the only button maker tool there is doesn't do quite the same job as the original buttons, I'm not sure I see this being fixed for a long time either :S

Also, note that the Babylon theme for 2.0 has the wrong font in 2.0 only buttons, too.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Owdy

  • SMF Fossil
  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 15,628
  • Gender: Male
  • W00t!
    • janoloferiksson on LinkedIn
    • @@jaoler on Twitter
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #2 on: April 11, 2010, 08:53:55 AM »
1.1 buttons works fine in 2.0 with babylon, so fix is just copy those buttons in to that package.
« Last Edit: April 11, 2010, 08:57:42 AM by Øwdy »
Former Lead Support Specialist

Tarvitsetko apua SMF foorumisi kanssa? Otan työtehtäviä vastaan, lue:http://www.simplemachines.org/community/index.php?topic=375918.0

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #3 on: April 11, 2010, 08:55:39 AM »
What about buttons that don't exist in 1.1's pack, like the main menu's 'Moderate' button?
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Owdy

  • SMF Fossil
  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 15,628
  • Gender: Male
  • W00t!
    • janoloferiksson on LinkedIn
    • @@jaoler on Twitter
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #4 on: April 11, 2010, 08:59:34 AM »
What about buttons that don't exist in 1.1's pack, like the main menu's 'Moderate' button?
Well, if team doesnt update those buttons, they can be english IMO. There are only 3 new buttons, see attacment
Former Lead Support Specialist

Tarvitsetko apua SMF foorumisi kanssa? Otan työtehtäviä vastaan, lue:http://www.simplemachines.org/community/index.php?topic=375918.0

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #5 on: April 11, 2010, 09:02:24 AM »
Well, as of RC2 it's no longer provided with SMF by default (might be in the upgrade pack, not sure, but definitely isn't in the main distribution) because it was turned into a theme on the theme site...
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Owdy

  • SMF Fossil
  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 15,628
  • Gender: Male
  • W00t!
    • janoloferiksson on LinkedIn
    • @@jaoler on Twitter
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #6 on: April 11, 2010, 09:04:47 AM »
Well, as of RC2 it's no longer provided with SMF by default (might be in the upgrade pack, not sure, but definitely isn't in the main distribution) because it was turned into a theme on the theme site...
well following that logic, remove that folder from lang packs also then. There are now babylon folder with finnish button folder containing english buttons. And yes, its in upgrade package.
Former Lead Support Specialist

Tarvitsetko apua SMF foorumisi kanssa? Otan työtehtäviä vastaan, lue:http://www.simplemachines.org/community/index.php?topic=375918.0

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #7 on: April 11, 2010, 09:06:01 AM »
I thought it was supposed to have been removed and made part of the theme itself, rather than being in the language files.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Owdy

  • SMF Fossil
  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 15,628
  • Gender: Male
  • W00t!
    • janoloferiksson on LinkedIn
    • @@jaoler on Twitter
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #8 on: April 11, 2010, 09:08:07 AM »
I thought it was supposed to have been removed and made part of the theme itself, rather than being in the language files.
Yes but it is in there now, so

1. Remove babylon folder from lang packs
or
2. Change those english buttons to translated ones.

So something needs to be fixed :D
Former Lead Support Specialist

Tarvitsetko apua SMF foorumisi kanssa? Otan työtehtäviä vastaan, lue:http://www.simplemachines.org/community/index.php?topic=375918.0

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #9 on: April 11, 2010, 09:31:45 AM »
No arguments here, just trying to figure out what should be fixed so that whoever is gonna bother can go do.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Norv

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 18,313
  • Blue Wolf
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #10 on: April 18, 2010, 04:44:51 PM »
Thank you Owdy. IMO, they should be removed, if the theme is being removed for 2.0 final.
To-do lists are for deferral. The more things you write down the later they're done… until you have 100s of lists of things you don't do.
File a security report | Developers' Blog | Bug Tracker

Also known as Norv on D* | Norv N. on G+ | Norv on Github

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #11 on: April 18, 2010, 05:13:21 PM »
But it'll likely still be in the upgrade package for those who started with 2.0 RC1x where it was still in the main install package...

Really though IMHO it should be split off and not considered a true bug with SMF, instead handed to the Cust team as current maintainers of the Babylon theme to be fixed.

And if you're going to rework the buttons, would be nice to see the buttons that weren't originally part of the theme (e.g. the main menu Moderate button) having the right font.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Norv

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 18,313
  • Blue Wolf
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #12 on: April 18, 2010, 05:19:14 PM »
They *are* still in the upgrade package, which IMHO is not a good idea. Indeed in the past they were in the main install package, but that is not a reason to still make them available when they are not ready. IMHO, that is. Anyone who has a theme that wasn't upgraded to RC2/RC3 will be in a similar situation, if they were removed, it's not worse. It's just a theme which needs to be separately downloaded and installed, for the next version, if it's available.

IMHO, the two themes should be exactly that, with all the files concerning them: removed from official dev packages, and eventually, when ready, upgraded and available separately.

ETA: and about the buttons, yes, sure. I'll make sure it gets to the customize team as well.
To-do lists are for deferral. The more things you write down the later they're done… until you have 100s of lists of things you don't do.
File a security report | Developers' Blog | Bug Tracker

Also known as Norv on D* | Norv N. on G+ | Norv on Github

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Finnish lang pack for RC3 has english buttonz.
« Reply #13 on: April 18, 2010, 05:24:03 PM »
I believe the same discussion was had in November when RC2 debuted and it was concluded that the Babylon and Classic packages should be left in for upgrades - can't remember the final justification for it though.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.