Notification

[David]

If you subscribe to a thread and then post in it, your subscription gets removed.

[[Unknown]]

Test.

-[Unknown]

[[Unknown]]

Works for me.

-[Unknown]

[David]

Hmm, isn't working on the BN community which is running beta 2.5.  Ehh, will see what happens in the next build I guess.

[andrea]

I have another guess for this phenomenon, maybe this scenario is right? I do get notif. emails for some threads fine, but am missing lots for other threads. I did some research what might cause this and have found this complicated scenario (maybe it is not yet 100% right but I guess close to):

So here is the detailed scenario:

- your member profile is set to "Turn notification on when you post or reply to a topic? (checked)
- you subscribed for a specific forum
- now you open a thread in that specific forum or reply to a thread in that specific forum (I mean the forum which you did subscribe)
- you will get the very first notification email to this thread
- you reply again to this thread
- from now on you will not recieve any more notification emails referring to this thread

David is this the same phenomenon you get? My impression is the bug is currently only existent in boards which I subscribed. All other boards the email notificaiton works fine for me.

[andrea]

Positively sure the notification bug is related to the activation of email notification on forum level. From all forums which I activated notification I do not get any more email notifications after the first one. I would appreciate a lot if this bug could be fixed soon. Tell me if you need any additional informations to work on it, such as precise thread links.


Example: This thread did not send me an notif. email in spite it is still in my notification settings:
http://www.simplemachines.org/community/index.php?topic=3335;all
The reason is that I subscribed for email notification on the german forum. The same happens on all other forums where I subscribed for email notification, such as team forums etc.

[[Unknown]]

Well, this code here begs to differ:

Code Select Expand

// Notify any members who have notification turned on for this topic.
if ($newTopic)
{
// This is a new topic, so maybe we should send off notifications...
if (empty($board_info['notify_announcements']))
notifyUsersBoard();
else
notifyUsersNewAnnouncement();
}
elseif (empty($_REQUEST['msg']))
notifyUsersTopic();

As you can see, $newTopic is the only reason a board's notification status would affect it.  And that's only true if it is... well, a new topic.

-[Unknown]

[andrea]

Yes thats how its working now. The bug is that thread subscription has no effect if one has subscribed for the forum.

It would be important to be able to subscribe for threads also which are in forums for which I subscribed. This is an important issue for my moderator work. For example the german support forum: I need to be notified on new threads *and* be notified on subscribed threads upon new replies. The 2nd notification should ignore the forum subscription.

[[Unknown]]

Code Select Expand

// Notify any members who have notification turned on for this topic.
if ($newTopic)
{
// This is a new topic, so maybe we should send off notifications...
if (empty($board_info['notify_announcements']))
notifyUsersBoard();
else
notifyUsersNewAnnouncement();
}
elseif (empty($_REQUEST['msg']))
notifyUsersTopic();

Wether or not you are "subscribed" to a board doesn't even effect whether or not it sends notification for replies!

-[Unknown]

[andrea]

elseif (empty($_REQUEST['msg']))
      notifyUsersTopic();

What is the precise meaning of the "elseif" before the "notifyUsersTopic()" function call? Should that not be unconditionally called, without any "if's" before? Is it possible this "elseif" condition returns "false" after I have replied to a topic which is in a subscribed forum?

[Unknown] some worm must be in otherwise I would get the emails... How can I help best to find the worm?

[[Unknown]]

I don't know... that elseif there makes it so it doesn't send another notification when you edit the message.

-[Unknown]

[andrea]

Is it possible it returns "true" after I have modified some reply in this thread?

[[Unknown]]

No, it only happens if ;msg= is in the query string, which happens only when you click "modify".  It does not happen when posting a reply.

-[Unknown]

[LostProphecy]

I have another guess for this phenomenon, maybe this scenario is right? I do get notif. emails for some threads fine, but am missing lots for other threads. I did some research what might cause this and have found this complicated scenario (maybe it is not yet 100% right but I guess close to):

So here is the detailed scenario:

- your member profile is set to "Turn notification on when you post or reply to a topic? (checked)
- you subscribed for a specific forum
- now you open a thread in that specific forum or reply to a thread in that specific forum (I mean the forum which you did subscribe)
- you will get the very first notification email to this thread
- you reply again to this thread
- from now on you will not recieve any more notification emails referring to this thread

David is this the same phenomenon you get? My impression is the bug is currently only existent in boards which I subscribed. All other boards the email notificaiton works fine for me.

I have no idea if this bug has been fixed or what has happened to it... i would just like to note that i've noticed that this exact thing is happening at my forum... if i set a board notification and have topic notifications in that board.. i will not recieve the topic notifications. On other boards where i have no board notification, the topic notifications work fine.