Merge Double Posts By Same Member

[ディン1031]

Hi DIN1031,

Need your advise. When I tried to uninstall Merge Double Post 1.03 (MDP), I get error messages . So I uninstalled all other mods that were installed after MDP, and then uninstall MDP. I still get these error messages:

Uninstall Actions "Merge Double Posts":   
Installing this package will perform the following actions:
Type   Action   Description   
1.   Execute Modification   ./index.php   Test successful   
2.   Execute Modification   ./Sources/Display.php   Test successful   
3.   Execute Modification   ./Sources/SplitTopics.php   Test failed   
4.   Execute Modification   ./Sources/ModSettings.php   Test successful   
5.   Execute Modification   ./Sources/Subs-Post.php   Test successful   
6.   Execute Modification   ./Themes/default/Display.template.php   Test successful   
7.   Execute Modification   ./Themes/default/languages/index.english.php   Test failed   
8.   Execute Modification   ./Themes/default/languages/ModSettings.english.php   Test successful

What should I do?

?_?
Normal it should work xD (i test every mod for this :X)

Okay deinstall it!
And than

Remove in the $sourcedir/SplitTopics.php the function MergePosts (the only change of the mod xD)

Code Select Expand


function MergePosts($error_report = TRUE) {

... many text XD (i don't know how it looks like in 1.03 XD)

}


And in the index.english.php

remove only

Code Select Expand


$txt['merge_doublepost'] = 'Merge the Double Posts';
$txt['merge_error_dbpo'] = 'You are not allowed to do this!';
$txt['merge_error_notf'] = 'Sorry, no Posts found to Merge.';
$txt['merge_error_noid'] = 'No Message ID or Topic found!';
$txt['search_date_posted'] = 'Posted at';
$txt['merge_error_lenth'] = 'The merged post have reached the maximum post lenth!';

You did changed the Postet at there to Posted XD if i think correct xD

Bye
DIN1031

[fiver]

Hi DIN1031,

You did changed the Postet at there to Posted XD if i think correct xD

yes, thanks for the reminder. I had also added 2 "br' into SplitTopics.php.

I have changed them back and now uninstalled without any error..

Uninstall Actions "Merge Double Posts":   
Installing this package will perform the following actions:
Type   Action   Description   
1.   Execute Modification   ./index.php   Test successful   
2.   Execute Modification   ./Sources/Display.php   Test successful   
3.   Execute Modification   ./Sources/SplitTopics.php   Test successful   
4.   Execute Modification   ./Sources/ModSettings.php   Test successful   
5.   Execute Modification   ./Sources/Subs-Post.php   Test successful   
6.   Execute Modification   ./Themes/default/Display.template.php   Test successful   
7.   Execute Modification   ./Themes/default/languages/index.english.php   Test successful   
8.   Execute Modification   ./Themes/default/languages/ModSettings.english.php   Test successful

Any chance of adding an "Unmerge" feature?

[fiver]

Hi DIN1031,

Downloaded 1.04. This time I made the changes in the mod files before installing. 

These are the changes for your reference.

1. Added 2 br before hr. (Just my preference.)
'[hr]' :
to
'[br][br][hr]' :

2. "Posted at" to "Posted on"
"...post lenth!" to "...post length!"

$txt['search_date_posted'] = 'Posted at';
$txt['merge_error_lenth'] = 'The merged post have reached the maximum post lenth!';

to

$txt['search_date_posted'] = 'Posted on';
$txt['merge_error_lenth'] = 'The merged post have reached the maximum post length!';

3. "doubelposts" to "doubleposts"

$txt['MergePost_AdminDoublePost'] = 'Merge new "Admin" doubelposts';

to

$txt['MergePost_AdminDoublePost'] = 'Merge new "Admin" doubleposts';

4. "post lenth" to "post length"

$txt['MergePost_IgnorePostLenth'] = 'Ignore the maximum post lenth';

to

$txt['MergePost_IgnorePostLenth'] = 'Ignore the maximum post length';

Many thanks again for making this mod.

[ディン1031]

Hui XD i know my english is bad, each time i forget to made a spell check :x...

@umerge future?
Öhm impossible If it merged no way to find out the old post settings XD.

Bye
DIN1031

[DemonicInfluence]

I get this error:

8: Undefined index: current_post_lenth
File: /home/u1/libo/html/Sources/Display.php
Line: 990

whenever I view a double posted place...

[ディン1031]

hmmmm i must look... i'm sure i've no errors with eval variables... but i look...

Öhm please tell me the Forum Version...

Bye
DIN1031

[DemonicInfluence]

1.1 rc2 ....

[Gary]

Hey din1031,

This might be a nice add-on to this mod;


Appears like this;
img removed

[ディン1031]

1.1 rc2 ....

Only a small question did you realy allow posts without limit... (I think that's my bug xD). Rofl i used the wrong variable to fill xD...

Okay i found a small bug, too and insert it. Also the changes from fivearts are insert.



AwwLilMaggie how should this for my mod usefull?



New Update

Bye
DIN1031

[Gary]

AwwLilMaggie how should this for my mod usefull?

That didnt make any sense, but I got the gist of it.


Anyway, basically since your mod changes the colour on the display.template.php and well, everywhere. Users might want to change more than just the colour. They might want to change the HTML around the user too. In the example above, the administrators would appear in Red, Bold, Italic.

[ディン1031]

AwwLilMaggie how should this for my mod usefull?

That didnt make any sense, but I got the gist of it.


Anyway, basically since your mod changes the colour on the display.template.php and well, everywhere. Users might want to change more than just the colour. They might want to change the HTML around the user too. In the example above, the administrators would appear in Red, Bold, Italic.

hum here is the merge double post mod xD not my member color link mod << so i was confuesed... please post it there not here << if it so...

Bye
DIN1031

[Gary]

Wrong one. heh.

I screwed up royal. Is my face red.

[oSa]

I've installed this mod to my 1.1 rc2 (default theme). When English is selected there's no problem except that it shows the "modify.gif" instead of the "merge.gif". And when i change to my own language (Turkish) it doesn't write anything near the button. That's really strange because i've added the needed codes to both the modsettings.turkish.php and index.turkish.php.

[DemonicInfluence]

1.1 rc2 ....

Only a small question did you realy allow posts without limit... (I think that's my bug xD). Rofl i used the wrong variable to fill xD...

Okay i found a small bug, too and insert it. Also the changes from fivearts are insert.



AwwLilMaggie how should this for my mod usefull?



New Update

Bye
DIN1031

Huh? posts w/o limit? what does that mean?

[ディン1031]

You can set in the Forum Settings, how many letters can be used in one post. I think you use 0 for unlimited . That's the only way i found out where this error ocurr. Or you disable the post size check that could also creat this error .

BYe
DIN1031

[DemonicInfluence]

Ah, yes. I have unlimited post size... Will it be fixed next version?

[ディン1031]

Allready Fixed in the current version 1.05 .

Bye
DIN1031

[DemonicInfluence]

Ah, thanks/

[Chawl]

Hello all, first tx for a useful mod.

We are using 1.1.RC2...

If the merging posts have ' (single quote) or \ (back slash) in the context (some smileys also have), an error page appears with the message something like "error in SQL syntax in SELECT FROM bla bla..." and merge operation fails.

1. Is it possible to be escaped the "dangerous" characters?
2. Can this situation prone to an SQL injection hacking?
3. If can not be escaped, can this arouse a problem for "Automatic merging" for example loss of the last post and needs a retype?

I have uninstalled the mod, because the answer to the second question is unclear for me.

I am a newbie, sorry in advance

[ディン1031]

hmmm i test this... but hmmmm i look, but i'm sure that this work because my forum use this button very offen... and i never saw this but i look .

(Normal it's not posibble to use SQL insection with the script, but i test this too ).

Because SMF first made a normal post and than i merge it in the database.

If there really a bug, than i will fix it.

Bye
DIN1031