Topic: SA Chat

[Diego Andrés]

So don't really know what I'm doing but to my understanding I couldn't find another instance or usage of $password in the index.php so I did the following

Code: (sachat/index.php) [Select]

//SMF Cookie autentication!!!
list ($member_id, $password) = initCookies();


Code: (replace) [Select]

//SMF Cookie autentication!!!
$member_id = initCookies();


Code: (sachat/Sources/Subs.php) [Select]

function initCookies() {
global $cookiename;

if (isset($_COOKIE[$cookiename]) && preg_match('~^a:[34]:\{i:0;(i:\d{1,6}|s:[1-8]:"\d{1,8}");i:1;s:(0|40):"([a-fA-F0-9]{40})?";i:2;[id]:\d{1,14};(i:3;i:\d;)?\}$~i', $_COOKIE[$cookiename]) == 1) {
list ($member_id, $password) = @unserialize($_COOKIE[$cookiename]);
$member_id = !empty($member_id) && strlen($password) > 0 ? (int) $member_id : 0;

return array($member_id, $password);
} elseif (isset($_COOKIE[$cookiename])) {
list ($member_id, $password) = @unserialize(stripslashes($_COOKIE[$cookiename]));
$member_id = !empty($member_id) && strlen($password) > 0 ? (int) $member_id : 0;

return array($member_id, $password);
}
}


Code: (replace) [Select]

function initCookies() {
global $cookiename;

if (isset($_COOKIE[$cookiename]) && preg_match('~^a:[34]:\{i:0;(i:\d{1,6}|s:[1-8]:"\d{1,8}");i:1;s:(0|40):"([a-fA-F0-9]{40})?";i:2;[id]:\d{1,14};(i:3;i:\d;)?\}$~i', $_COOKIE[$cookiename]) == 1) {
list ($id_member, $password) = @unserialize($_COOKIE[$cookiename]);
$id_member = !empty($id_member) && strlen($password) > 0 ? (int) $id_member : 0;

return $id_member;
} elseif (isset($_COOKIE[$cookiename])) {
list ($id_member, $password, $login_span) = @unserialize($_SESSION['login_' . $cookiename]);
$id_member = !empty($id_member) && strlen($password) > 0 ? (int) $id_member : 0;

return $id_member;
}
}
And seems to be working on SMF 2.0.17

If anyone else with more knowledge about this can give the mod a look would be great and appreciated. 


Also

Code: (sachat/Sources/User.php) [Select]

$context['online_count'] = count(isset($context['friends']) ? $context['friends'] : null);
}
if ($type == 'list') {
$data = buddy_list_template();
return $data;
}
if ($type == 'count') {
return count(isset($context['friends']) ? $context['friends'] : null);
}

Code: (replace) [Select]

$context['online_count'] = count(isset($context['friends']) ? $context['friends'] : []);
}
if ($type == 'list') {
$data = buddy_list_template();
return $data;
}
if ($type == 'count') {
return count(isset($context['friends']) ? $context['friends'] : []);
}

[aegersz]

will give it a try later, thanks !

[aegersz]

There is no sachat/Sources directory so i am totally lost.

So don't really know what I'm doing but to my understanding I couldn't find another instance or usage of $password in the index.php so I did the following

Code: (sachat/index.php) [Select]

//SMF Cookie autentication!!!
list ($member_id, $password) = initCookies();


Code: (replace) [Select]

//SMF Cookie autentication!!!
$member_id = initCookies();


Code: (sachat/Sources/Subs.php) [Select]

function initCookies() {
global $cookiename;

if (isset($_COOKIE[$cookiename]) && preg_match('~^a:[34]:\{i:0;(i:\d{1,6}|s:[1-8]:"\d{1,8}");i:1;s:(0|40):"([a-fA-F0-9]{40})?";i:2;[id]:\d{1,14};(i:3;i:\d;)?\}$~i', $_COOKIE[$cookiename]) == 1) {
list ($member_id, $password) = @unserialize($_COOKIE[$cookiename]);
$member_id = !empty($member_id) && strlen($password) > 0 ? (int) $member_id : 0;

return array($member_id, $password);
} elseif (isset($_COOKIE[$cookiename])) {
list ($member_id, $password) = @unserialize(stripslashes($_COOKIE[$cookiename]));
$member_id = !empty($member_id) && strlen($password) > 0 ? (int) $member_id : 0;

return array($member_id, $password);
}
}


Code: (replace) [Select]

function initCookies() {
global $cookiename;

if (isset($_COOKIE[$cookiename]) && preg_match('~^a:[34]:\{i:0;(i:\d{1,6}|s:[1-8]:"\d{1,8}");i:1;s:(0|40):"([a-fA-F0-9]{40})?";i:2;[id]:\d{1,14};(i:3;i:\d;)?\}$~i', $_COOKIE[$cookiename]) == 1) {
list ($id_member, $password) = @unserialize($_COOKIE[$cookiename]);
$id_member = !empty($id_member) && strlen($password) > 0 ? (int) $id_member : 0;

return $id_member;
} elseif (isset($_COOKIE[$cookiename])) {
list ($id_member, $password, $login_span) = @unserialize($_SESSION['login_' . $cookiename]);
$id_member = !empty($id_member) && strlen($password) > 0 ? (int) $id_member : 0;

return $id_member;
}
}
And seems to be working on SMF 2.0.17

If anyone else with more knowledge about this can give the mod a look would be great and appreciated. 


Also

Code: (sachat/Sources/User.php) [Select]

$context['online_count'] = count(isset($context['friends']) ? $context['friends'] : null);
}
if ($type == 'list') {
$data = buddy_list_template();
return $data;
}
if ($type == 'count') {
return count(isset($context['friends']) ? $context['friends'] : null);
}

Code: (replace) [Select]

$context['online_count'] = count(isset($context['friends']) ? $context['friends'] : []);
}
if ($type == 'list') {
$data = buddy_list_template();
return $data;
}
if ($type == 'count') {
return count(isset($context['friends']) ? $context['friends'] : []);
}

[Kindred]

Sources/SAchat...

[aegersz]

Sources/SAchat...

Nope, doesn't exist

[Diego Andrés]

It's in the root directory of the forum 

[aegersz]

It's in the root directory of the forum 

Not on mine. I have no idea where that is other than the SMF Subs.php in Sources and User.php doesn't exist anywhere !

[Antechinus]

Umm, this might be your problem.

[Diego Andrés]

I think you might not have the 1.0a1 version installed which seems to be the latest one according to the mod page 
The cookie changes can be done in the functions.php file for that version that you are using, but I'd recommend using the latest one? Who knows how old the 0.1.5 version is 

[aegersz]

I have version 0.1.5 Rev110  installed.

I installed the newest version and your changes but no luck. Looks like I'm doomed top sit on 0.15 for the interim.

[Rock Lee]

I have version 0.1.5 Rev110  installed.

I installed the newest version and your changes but no luck. Looks like I'm doomed top sit on 0.15 for the interim.

I downloaded the latest version of the modification to apply the changes to the installer and then install, it worked without problems with the suggested changes. That is, download version 1.0a1 Rev120 unzipped it to find the files to be edited, compressed it again to proceed to install and it worked in my test version that I am running 2.0.17.


Regards!

[aegersz]

I have version 0.1.5 Rev110  installed.

Interestingly, the new version of SA Chat failed even before any 2.0.16 changes were applied.

I installed the newest version and your changes but no luck. Looks like I'm doomed top sit on 0.15 for the interim.

[aegersz]

I have other issues by the looks of it - the other version (Rev120) doesn't work on my 2.0.15 either.

Anyhow, thanks for your help.

EDIT: After all the changes, I had to remove the Live Clock mod and then it started working ! Thanks for your help.

[kesulin]

So don't really know what I'm doing but to my understanding I couldn't find another instance or usage of $password in the index.php so I did the following

Code: (sachat/index.php) [Select]

//SMF Cookie autentication!!!
list ($member_id, $password) = initCookies();


Code: (replace) [Select]

//SMF Cookie autentication!!!
$member_id = initCookies();


Code: (sachat/Sources/Subs.php) [Select]

function initCookies() {
global $cookiename;

if (isset($_COOKIE[$cookiename]) && preg_match('~^a:[34]:\{i:0;(i:\d{1,6}|s:[1-8]:"\d{1,8}");i:1;s:(0|40):"([a-fA-F0-9]{40})?";i:2;[id]:\d{1,14};(i:3;i:\d;)?\}$~i', $_COOKIE[$cookiename]) == 1) {
list ($member_id, $password) = @unserialize($_COOKIE[$cookiename]);
$member_id = !empty($member_id) && strlen($password) > 0 ? (int) $member_id : 0;

return array($member_id, $password);
} elseif (isset($_COOKIE[$cookiename])) {
list ($member_id, $password) = @unserialize(stripslashes($_COOKIE[$cookiename]));
$member_id = !empty($member_id) && strlen($password) > 0 ? (int) $member_id : 0;

return array($member_id, $password);
}
}


Code: (replace) [Select]

function initCookies() {
global $cookiename;

if (isset($_COOKIE[$cookiename]) && preg_match('~^a:[34]:\{i:0;(i:\d{1,6}|s:[1-8]:"\d{1,8}");i:1;s:(0|40):"([a-fA-F0-9]{40})?";i:2;[id]:\d{1,14};(i:3;i:\d;)?\}$~i', $_COOKIE[$cookiename]) == 1) {
list ($id_member, $password) = @unserialize($_COOKIE[$cookiename]);
$id_member = !empty($id_member) && strlen($password) > 0 ? (int) $id_member : 0;

return $id_member;
} elseif (isset($_COOKIE[$cookiename])) {
list ($id_member, $password, $login_span) = @unserialize($_SESSION['login_' . $cookiename]);
$id_member = !empty($id_member) && strlen($password) > 0 ? (int) $id_member : 0;

return $id_member;
}
}
And seems to be working on SMF 2.0.17

If anyone else with more knowledge about this can give the mod a look would be great and appreciated. 


Also

Code: (sachat/Sources/User.php) [Select]

$context['online_count'] = count(isset($context['friends']) ? $context['friends'] : null);
}
if ($type == 'list') {
$data = buddy_list_template();
return $data;
}
if ($type == 'count') {
return count(isset($context['friends']) ? $context['friends'] : null);
}

Code: (replace) [Select]

$context['online_count'] = count(isset($context['friends']) ? $context['friends'] : []);
}
if ($type == 'list') {
$data = buddy_list_template();
return $data;
}
if ($type == 'count') {
return count(isset($context['friends']) ? $context['friends'] : []);
}

¡works great!¡fantastic work!

thanks very much 

[Sir Osis of Liver]

I've had this working on a forum in 2.0.15, but it disappears in .16/.17.  Can it be fixed?

[Rock Lee]

I've had this working on a forum in 2.0.15, but it disappears in .16/.17.  Can it be fixed?

Did you try the solution I leave @Diego Andrés? I tried it and it worked!


Regards!

[Sir Osis of Liver]

Finally got around to this.  Modded SA Chat code as per -

https://www.simplemachines.org/community/index.php?topic=391961.msg4046455#msg4046455

Works in 2.0.17.  Thanks.

[aegersz]

The new version (even prior to any 2.0.16/17) does not show the correct number of online users.

Does anyone else have this problem ?

if i can get REV120 working correctly then I can't upgrade.

Can anybody help ?

[Sir Osis of Liver]

Did the code edits posted above to 1.0a Rev120, upgraded 2.0.15 -> 2.0.17, and it seems to be working correctly.  Not a very busy forum, only myself and one other member active, but it's showing the one member.

[aegersz]

in my dev system, i have 3 active online members and only one member shows the other 2.

Can you please try a third test user or something to see how if behaves ?