POSTGRES type error on bulk delete members

[Tyris]

I'm getting the following error:

Code Select Expand

ERROR: argument of WHERE must be type boolean, not type integer
File: /path/to/smf/Sources/Subs-Members.php
Line: 1222
When I try to delete a bunch of members (after doing a member search). POSTGRES database.

The delete action seems to still follow through... but the next page fails to load.

Fix seems to be:

Code Select Expand

ManageMembers.php:424
$where = empty($query_parts) ? '1' : implode('
replace with:
$where = empty($query_parts) ? '1=1' : implode('
Subs-Members.php:1241
if (empty($where) || $where == '1')
replace with:
if (empty($where) || $where == '1=1')

Untested!

Cheers,
Tyris

[emanuele]

Thanks Tyris for both the report and the fix!

Will keep track of it.

[Tyris]

No worries.
Keep up the good work =)

[emanuele]

Fix committed:
https://github.com/emanuele45/playpen/commit/fa61e45e9746e156a6740d2e230b25a5b014589b