Simple Spoiler

[eric1234]

Erm..this is my default index.template.php >.<

[eric1234]

This is my template's index.template.php

So sorry for troubling you all >.< The rest of my template's index.template.php, i will research and put them in myself : )

[Suki]

use this one

[eric1234]

use this one

for both default and template? 

[Suki]

?  I don't get it,  the file you uploaded will only work with the specific theme, you cannot use it with another theme.

[MLM]

Love the mod and have been using it for a while. I noticed a while back that I had already called jquery this mod was adding another version of it to my headers (older versions too). There should be a miscellaneous mod setting to turn off adding jquery to the header.

Also why are you including the css file when you don't use it?

[Suki]

css file?

The mod does check if you already have jquery loaded, f not, then it loads jquery from Google, if you already have jquery then the mod doesn't load anything.

I can't add a setting for that since is not something I can have control over it.

[NanoSector]

css file?

The mod does check if you already have jquery loaded, f not, then it loads jquery from Google, if you already have jquery then the mod doesn't load anything.

I can't add a setting for that since is not something I can have control over it.

I guess MLM means that there are several <script src="jquerylink" /> codes added in his header.

[MLM]

css file?

The mod does check if you already have jquery loaded, f not, then it loads jquery from Google, if you already have jquery then the mod doesn't load anything.

I can't add a setting for that since is not something I can have control over it.

Yes you can, I did have jquery loaded from the google cdn already but it was still loading it. and I had to have noConflict going...

All you would have to add is a check modsetting in the admin cp and just say

Code Select Expand

if($modSettings['simple_spoiler_call_js'])

around the header parts you have in Subs-SimpleSpoiler.php

[Suki]

I know how to add a setting and I told you is not necessary... this script checks for jquery already:

Code Select Expand


<script type="text/javascript">!window.jQuery && document.write(unescape(\'%3Cscript src="http://code.jquery.com/jquery.min.js"%3E%3C/script%3E\'))</script>

if it is loaded already then it does nothing and doesn't load anything.

there is no need to add any setting for that, the mod does it automatically.

[eric1234]

After i use the index.template.php , the problem still persisit >.< Oh my, really sorry for troubling you

[Suki]

do you have another spoiler mod installed?

can you post a link to a topic with an spoiler.

[eric1234]

Nope, i dun have any other Spoiler mod installed in the forum
I has edited the post. All the 3 spoilers were images.

The thread

Original thread message

Code Select Expand

[spoiler][img width=600 height=359]http://i1071.photobucket.com/albums/u509/dinomice31/IMAG0407.jpg[/img][/spoiler]
[spoiler][img]http://3.bp.blogspot.com/-drs8z_B31-o/TdebhK6T1cI/AAAAAAAAB-w/-yMk7j6cmek/s400/ccc7.jpg[/img][/spoiler]
[spoiler][img]http://1.bp.blogspot.com/-b2bpZUxCKRQ/TxpL3VxP93I/AAAAAAAAPj4/RegYUOJfvDQ/s400/gereja%2Bterbesar%2Basia%2Bbom321%2B%25289%2529.jpg[/img][/spoiler]

[luuuciano]

Mmmm, today I realiced that simple spoiler do not works (maybe at some places only)
For example here: http://ikers.com.ar/index.php/topic,6586.msg103179.html#msg103179

The spoiler is showed as:
Spoiler
No leiste acaso que es ALTAS Cumbres???

[Suki]

@eric1234, @luuuciano  change in Sources/Subs-SimpleSpoiler.php

$context['html_headers'] .=

with this:

echo

[luuuciano]

I do not understand... just an "echo"? is that ok?

BTW... the spoiler, on the ecample url I have posted yesterday... it WORKS now!
Really odd.... maybe the google jquery was not available for some time? mmm

[Suki]

Perhaps it was the google CDN.


by changing $context['html_headers'] .= 'code';

to  echo 'code';

the mod will bypass the $context['html_headers'] var, it's just to make sure the problem resides on $context['html_headers'], it is not a solution since it will print JavaScript code before the doctype declaration

[eric1234]

Erm, i had changed the code like what you instructed

The thing is getting better but still, when i wanna put the spoiler on images, sometimes it works, sometimes it don't and the whole system seem like little laggy. >.<

however, it works fine when i spoiler texts.

Please has a look at the attachment, it was screenshot from the thread that i gave you in the previous post.

[Suki]

the reason it is slow is because you are loading big images, not because of the spoiler.

[eric1234]

the reason it is slow is because you are loading big images, not because of the spoiler.

i see. but how come sometime when i click on it, no picture been shown ?