Quick Reply -> Show, on by default

[ckelly06]

Hi guys,

I've asked this question a few times in a few different places, and no one has been able to answer. A little time has passed since the last time I asked so I'm trying again

All I want to do is to show the Quick Reply in its expanded state by default for all new users. I've gone into Themes and Layout and set the Quick Reply setting to "Show, on by default" for current members and as the default for guests and new members across every theme installed (I thought maybe SMF was reading this setting from the default theme instead of my installed theme so I changed the setting in both).

No dice. No matter what I do, the Quick Reply box is always collapsed by default for new users and when you go into the individual settings for a new user you see the option set as "Show, off by default". Clearly there is a bug in SMF 2.0 RC4 where this setting is not being respected, but I'm trying to find some workaround to just get this to work on my forum. Is anyone able to explain how I can edit the source code directly to hard code this setting since I can't get it to work from the admin console?

The forum where I'm having this issue is DateSphere Online Dating Forum.

Thanks for your help.

Chris

[Antechinus]

Interesting. I'll take a look at it tonight and see if I can reproduce this.

[ckelly06]

Thanks!

[ckelly06]

Just checking back on this, anyone have any ideas?

[Spuds]

Does your custom theme have its own Display.template.php file?  If so it might be missing some needed code to respect the quick reply settings. 

[Oldiesmann]

Did you set it that way for your custom theme, or for the default theme?

You may have to set it specifically for your custom theme as well.

Admin -> Configuration -> Themes and Layout -> Member Options
Click "Configure guest and new member options for this theme" under your custom theme
Make sure "Quick reply" is set to "Show, on by default".

[ckelly06]

Hi Oldiesmann,

Yes, I definitely set quick reply to "show, on by default" for every single theme I have installed in a desperate attempt to fix this (and I checked my currently installed theme as well as the default theme about 10 times).

Does anyone know how to hardcode this setting in the code? I think the admin console is just broken for this feature or something...

Thanks,

Chris

[Rain Forest]

Hi Oldiesmann,

Yes, I definitely set quick reply to "show, on by default" for every single theme I have installed in a desperate attempt to fix this (and I checked my currently installed theme as well as the default theme about 10 times).

Does anyone know how to hardcode this setting in the code? I think the admin console is just broken for this feature or something...

Thanks,

Chris

Got the same issue..

[Antechinus]

Easy. Display.template.php

Find:

Code Select Expand

// Show the jumpto box, or actually...let Javascript do it.
echo '
<div class="plainbox" id="display_jump_to">&nbsp;</div>';

if ($context['can_reply'] && !empty($options['display_quick_reply']))

Replace:

Code Select Expand

// Show the jumpto box, or actually...let Javascript do it.
echo '
<div class="plainbox" id="display_jump_to">&nbsp;</div>';

if ($context['can_reply'])

It's only the last line that is changed. I just included the rest for context.

[Gwenwyfar]

Seems to be a bug, I have the same issue as well. Thanks for the fix

[Steve]

Is this a fix we should all do?

[Rain Forest]

If it is a bug, 2.0.8 is also 'infected'.

[Gwenwyfar]

If it is a bug, 2.0.8 is also 'infected'.

Yep, I have 2.0.8 as well.

Was thinking that maybe I didn't set it properly before I saw this.

[Rain Forest]

If it is a bug, 2.0.8 is also 'infected'.

Was thinking that maybe I didn't set it properly before I saw this.

That's what I thought. Hopefully there will be a fix on shot term.

[Kindred]

don't count on it.   We will probably address it in the next release of 2.0.x, but that is currently not scheduled and probably won't be made until/unless some security issues are also discovered.

[Arantor]

Actually this is not a 'bug' but symptomatic of how SMF works in general. Quick reply is per theme because it is also a user preference (and user prefs require being per theme because of the way the EAM model is applied in the database)

I would not encourage 'fixing' it because it is not buggy. Its design is sub-optimal but it works the way it is supposed to work.

[Kindred]

hmmm... OK.

[Arantor]

Yup; user preferences are all applied per theme because of how they are subsequently loaded.

[Gwenwyfar]

Hmm, true, it works normally (without the fix). Seems the reset or change in options is not applying to admins then?

This is one of the first settings I had set when going through all of them right after installation, and I've set my default theme's "user options" to display, on by default. That remained the same the whole time and I've "reset everyone to default" a couple times, and didn't touch my own options. It still kept displaying it off the whole time. Now that I checked other user's settings, they're all normal as they should be, just mine (as admin) that isn't.

[Arantor]

I would wonder if you're on the right theme at the time since it's always worked exactly how I've expected it to.

[Gwenwyfar]

Pretty sure its the right one, which is the default theme as well, the default one probably won't even work properly at this point

Maybe I just didn't reset it the right way or something then. For everyone else other than me its working just fine, all the default options are as they should including this one.

[Arantor]

The default theme is not necessarily the default theme.

[Gwenwyfar]

The default theme is a custom theme based off a copy from default curve, just to get that part clear.

Edit: But yeah, that was it. My own options, even though I'm currently using the default (custom) theme, was still being based off the forum default curve theme from when I created it. So resetting the default (curve) settings did the trick (while resetting the custom theme's had worked for everyone else as they have always used only that one, or maybe because they were new users and got the new settings already)

Will do more tests with that once I have more free time, planning on keeping curve there to get all other future themes based off it. If settings are all based on it as well then even better, less stuff to change

And really not a bug after all

[Low]

Hi this is still an issue in 2.0.9+10. I even tried the hard coded option but still the box is collapsed for members. I noticed in my members personal forum/layout settings the options is set to NOT show quick reply by DEFAULT. So I think our admin/default settings are being overridden by member settings?

Although, for guests it is open/showing!

Any current workarounds?

[Kindred]

yes. default settings will ALWAYS be overidden by member settings. That's the entire POINT of member settings.

So, no... it's not an issue at all.

You can always FORCE a change to reset everyone to the default (in the same section of admin settings)  but - be warned - admins who force settings changes on users get pissed off users.

[Low]

yes. default settings will ALWAYS be overidden by member settings. That's the entire POINT of member settings.

So, no... it's not an issue at all.

You're missing the point. If a user wants to change their settings, fair play, great! But still, the DEFAULT settings which are set by an ADMIN are NOT being applied to NEW users because of the confirmed bug. I was wondering if there was a way around/fix for this.

[margarett]

I'm still not convinced that this is actually a bug, to be honest. We need to be able to duplicate it to confirm (or not).
In previous page, Arantor said:

Actually this is not a 'bug' but symptomatic of how SMF works in general. Quick reply is per theme because it is also a user preference (and user prefs require being per theme because of the way the EAM model is applied in the database)

I would not encourage 'fixing' it because it is not buggy. Its design is sub-optimal but it works the way it is supposed to work.

Besides, if you say

I even tried the hard coded option but still the box is collapsed for members.

I have to say that you edited the wrong file (eg: you edited Display.template.php from another theme which is not what you are using)

[Low]

I'm still not convinced that this is actually a bug, to be honest. We need to be able to duplicate it to confirm (or not).

Other members also have the same bug. Bottom line, we tell admin settings to show quick reply by default.. it does NOT show by default. YES it CAN be switched on via their individual user profile/settings, but this is NOT default, is it?

Either the admin settings are broke/bugged, or redundant because either way the users see a collapsed quick-reply.

I have to say that you edited the wrong file (eg: you edited Display.template.php from another theme which is not what you are using)

I only have the default theme and one Display.template.php?

[margarett]

And what code did you change?

[Kindred]

And did you set the quick-reply on, by default FOR EVERY THEME?

[Steve]

He says he only has the default theme, Kindred.

I only have the default theme and one Display.template.php?

[Gwenwyfar]

He says he only has the default theme, Kindred.

I only have the default theme and one Display.template.php?

But there are two default themes, he could still have changed the wrong one.

[Steve]

How can there be two default themes?

[Gwenwyfar]

Themes that come installed by default, there are two themes that come by default, so two default themes. I did not mean the theme you currently use as default for the forum (lame double meaning words).

And from what I recall on this problem, editing the "forum default theme" settings do not change the theme settings. So I had to edit curve settings, and not "forum default theme".

I may not be completely right on this though, I have since just removed the setting altogether (everyone uses quick reply on my forum as default anyways, and not like something on the bottom needs to be collapsed to be ignored). But I'd still give a try to editing the setting on all themes to see if its not just that...

[Steve]

Ah, I see what you mean now. And btw, good to see you back.

[Gwenwyfar]

Thanks Just been way too busy this year, a lot of things to do at once, forum included Will appear around here more when I have the time.

[Low]

But there are two default themes, he could still have changed the wrong one.

I've changed the theme that is used by default with SMF.

My problem is exactly the same as OP's and most others in this thread. If a new member signs up it says in my admin for example: "1 user is using own theme setting" (this is not me). The member accounts aren't starting with the default settings but are automatically using the "HIDE quick reply by default".

If I reset them users to use the forum defaults then that works but I shouldn't have to work around this bug and fix it every time I get a new member, they should use the defaults automatically.

Again, guests can see the expanded reply box, if they become a member it is then collapsed, if this helps.

[Illori]

i just tested with my test forum and test account. i set the account to not show the quick reply at all. verified that the quick reply was not showing at all. i went in the admin panel on my admin account and changed the member options for the default theme/curve [one the test user is using] to show the quick reply and be on by default. i refreshed a topic and the quick reply showed for my test user.

[Low]

i just tested with my test forum and test account. i set the account to not show the quick reply at all. verified that the quick reply was not showing at all. i went in the admin panel on my admin account and changed the member options for the default theme/curve [one the test user is using] to show the quick reply and be on by default. i refreshed a topic and the quick reply showed for my test user.

Yes I can do the same for current members. If I reset all member options they work. The quick reply does NOT show expanded by default for new members though.

[Illori]

now i can duplicate that. not sure if it will be fixed for 2.0. we can test it in 2.1 and see if it needs to be fixed there.

[Illori]

seems that in 2.1 this has been taken care of. there is no way to disable the quick reply, it is always shown and cannot be collapsed at all.

[oOo--STAR--oOo]

This still needs fixing...

Scenario, I have a custom theme, I choose Configure guest and new user options for this theme *My custom theme that is active* And set the option  Use quick reply on topic display: Show on by default.. Soon as I register a new account, there is an new row inserted into the smf_themes table with
id_theme = 1 variable = display_quick_reply  value = 1
When my custom themes ID = 2, users are not allowed to choose themes and this theme is also the forums overall default theme.

Also, how come when I choose defaults for my custom theme, most of the options go into the default theme?
Configure guest and new user options for this theme (19 options currently set.) **DEAFULT SMF THEME*
Configure guest and new user options for this theme (2 options currently set.) **MY CUSTOM THEME**

Looked in the DB, yes it made 19 options for theme ID = 1 and only 2 for my custom theme ID =2

wysiwyg_default
posts_apply_ignore_list

Are the only options that assigned to theme ID = 2

After looking at the register.php file I discovered this line

Code Select Expand


// If Quick Reply hasn't been set then set it to be shown but collapsed.
if (!isset($regOptions['theme_vars']['display_quick_reply']))
$regOptions['theme_vars']['display_quick_reply'] = 1;


I just deleted this code and it seems to of solved the problem.
Now it will use the options above.. But still why do the options get assigned to the default theme and not my theme.. Even though they are active why is the theme ID not my theme?

Also, when I have custom profile fields, if they are empty, why is there a row inserted with theme ID again 1 but the value is blank..
It should really not put anything in the database if their is nothing submitted its just clogging up the database.. I will post a fix to that soon.

SMF 2.0.11