Advertisement:

Author Topic: Play Media Attachments  (Read 16859 times)

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,691
  • Mod King
    • XPtsp.com Community
Re: Play Media Attachments
« Reply #120 on: April 29, 2018, 05:10:55 AM »
Uploaded v2.4 - April 28th, 2018
o Added mime detection for QuickTime (.mov) movies.
o Added code fragment to exclude mime type from HTML when playing QT movies.
o Fixed conditional statement so that video embed tag works if needed.



@Everybody:  A request was made via PM to see if I could support mov (QuickTime movie) files.  I managed to get the mod to do so.  WORD OF WARNING:  I do not know if any browser plugins may be required for the video file to work properly...
News: Missing GitHub repository...

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Online Drakkon

  • Semi-Newbie
  • *
  • Posts: 28
Re: Play Media Attachments
« Reply #121 on: April 29, 2018, 11:38:31 PM »
Thank you! I can confirm that it works with .mov files.

An issue I'm having is that the videos(mp4, mov) don't play when I visit the forum through my phone. I'm using an iPhone 8 plus.

Online Drakkon

  • Semi-Newbie
  • *
  • Posts: 28
Re: Play Media Attachments
« Reply #122 on: May 02, 2018, 09:06:02 PM »
I've noticed that the videos don't play on mobile because it's linking to the attachment url instead of the actual file. Is there a way to fix this?

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,691
  • Mod King
    • XPtsp.com Community
Re: Play Media Attachments
« Reply #123 on: May 03, 2018, 09:55:46 AM »
I'm looking into this....
News: Missing GitHub repository...

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Online Drakkon

  • Semi-Newbie
  • *
  • Posts: 28
Re: Play Media Attachments
« Reply #124 on: May 03, 2018, 09:44:12 PM »
Thank you for all your hard work.

Online Drakkon

  • Semi-Newbie
  • *
  • Posts: 28
Re: Play Media Attachments
« Reply #125 on: May 22, 2018, 01:27:10 AM »
Any progress?

Offline Steve

  • Support Specialist
  • SMF Hero
  • *
  • Posts: 4,302
  • Gender: Male
  • I have not yet begun to procrastinate.
Re: Play Media Attachments
« Reply #126 on: May 25, 2018, 08:33:19 AM »
I have been trying to rest the last two weeks or so, as I have gotten exhausted trying to keep up with everything....
Online Manual

Please do not PM me for support.

Online aegersz

  • Sophist Member
  • *****
  • Posts: 1,357
  • Gender: Male
  • "mods" junkie
    • dopetalk
Re: Play Media Attachments
« Reply #127 on: Today at 12:38:45 PM »
MINOR bug fix for 8: Undefined index: PMAt_no_audio

find:
Code: [Select]
, $txt['PMAt_no_audio'], '
change:
Code: [Select]
, $txt('PMAt_no_audio'), '
                                                                                       
repeat this for the video code also
Linux CentOS VPS running SMF 2.0 with 140+ mods installed (the full h/w and s/w can be seen at http://forum.drugs-and-users.org/index.php/topic,3301)

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 68,809
    • Arantor on GitHub
Re: Play Media Attachments
« Reply #128 on: Today at 12:43:07 PM »
Um... no, that's a REALLY bad idea.

Changing out the [] for () means trying to treat it as a function, and $txt isn't a function and doesn't contain a callable.

Better suggestion: actually define the language string in Modifications.english.php...
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

Online aegersz

  • Sophist Member
  • *****
  • Posts: 1,357
  • Gender: Male
  • "mods" junkie
    • dopetalk
Re: Play Media Attachments
« Reply #129 on: Today at 02:14:56 PM »
Ok, thanks - i assumed it was a function inserting a text sting ... so i decided to change it to:

Code: [Select]
', 'PMAt_no_audio' , 'and
Code: [Select]
', 'PMAt_no_video' , '
seems to work; FYI, the HTML <audio> and <video> tags are used like this:

Code: [Select]
<audio controls>
  <source src="horse.ogg" type="audio/ogg">
  Your browser does not support the audio tag.
</audio>

i am not sure what Modifications.english.php does yet ...
Linux CentOS VPS running SMF 2.0 with 140+ mods installed (the full h/w and s/w can be seen at http://forum.drugs-and-users.org/index.php/topic,3301)

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 68,809
    • Arantor on GitHub
Re: Play Media Attachments
« Reply #130 on: Today at 02:19:13 PM »
Um. Modifications.english.php is the home of all the language strings given by mods...
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

Online aegersz

  • Sophist Member
  • *****
  • Posts: 1,357
  • Gender: Male
  • "mods" junkie
    • dopetalk
Re: Play Media Attachments
« Reply #131 on: Today at 02:22:53 PM »
thank you ...
Linux CentOS VPS running SMF 2.0 with 140+ mods installed (the full h/w and s/w can be seen at http://forum.drugs-and-users.org/index.php/topic,3301)