Advertisement:

Author Topic: [4825] Firefox 8 beta bug  (Read 49017 times)

Offline emanuele

  • SMF Super Hero
  • *******
  • Posts: 14,156
  • Gender: Male
  • THERE'S JUST ME
Re: [4825] Firefox 8 beta bug
« Reply #40 on: November 12, 2011, 06:30:03 AM »
* emanuele is tired of seeing the message "Warning - while you were typing a new reply has been posted. You may wish to review your post." :P


Take a peek at what I'm doing! ;D



Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Offline Norv

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 18,313
  • Blue Wolf
Re: [4825] Firefox 8 beta bug
« Reply #41 on: November 12, 2011, 06:32:31 AM »
You mean, *I* was quicker than you this time?

* Norv marks the event. :)
To-do lists are for deferral. The more things you write down the later they're done… until you have 100s of lists of things you don't do.
File a security report | Developers' Blog | Bug Tracker

Also known as Norv on D* | Norv N. on G+ | Norv on Github

Offline emanuele

  • SMF Super Hero
  • *******
  • Posts: 14,156
  • Gender: Male
  • THERE'S JUST ME
Re: [4825] Firefox 8 beta bug
« Reply #42 on: November 12, 2011, 06:36:37 AM »
lol

I got the message three times in a row... :P


Take a peek at what I'm doing! ;D



Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Offline Norv

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 18,313
  • Blue Wolf
Re: [4825] Firefox 8 beta bug
« Reply #43 on: November 12, 2011, 06:38:43 AM »
Haha!
Well, it's an important issue at this time. But please, do state what you meant, lol.
To-do lists are for deferral. The more things you write down the later they're done… until you have 100s of lists of things you don't do.
File a security report | Developers' Blog | Bug Tracker

Also known as Norv on D* | Norv N. on G+ | Norv on Github

Offline neugi

  • Semi-Newbie
  • *
  • Posts: 65
  • Gender: Male
  • Just Me
Re: [4825] Firefox 8 beta bug
« Reply #44 on: November 13, 2011, 01:38:43 PM »
hi,

i tried the fix suggested here:
http://dev.simplemachines.org/mantis/view.php?id=4825

but than i get problmes with the images(jpg)

can anybody confirm this?

best

Offline Tomcraft

  • Jr. Member
  • **
  • Posts: 135
Re: [4825] Firefox 8 beta bug
« Reply #45 on: November 13, 2011, 01:45:50 PM »
Can you please try my patch?

Regards, Torsten

Offline neugi

  • Semi-Newbie
  • *
  • Posts: 65
  • Gender: Male
  • Just Me
Re: [4825] Firefox 8 beta bug
« Reply #46 on: November 13, 2011, 01:56:33 PM »
found the problem, there ist a space in the filename, and with the space in the filename it is not working. because the " are missing.

if removed the spaces udn replaced them with _ and now it works.

best

Offline reschke

  • Semi-Newbie
  • *
  • Posts: 24
Re: [4825] Firefox 8 beta bug
« Reply #47 on: November 13, 2011, 02:00:30 PM »
found the problem, there ist a space in the filename, and with the space in the filename it is not working. because the " are missing.

if removed the spaces udn replaced them with _ and now it works.

best

Spaces require escaping as %20 in this format. Note that you can simply send the same format to Chrome, Opera, Firefox, Konqueror, and IE >= 9. No need to special case except for legacy browsers like IE <= 8 and Safari.

Offline neugi

  • Semi-Newbie
  • *
  • Posts: 65
  • Gender: Male
  • Just Me
Re: [4825] Firefox 8 beta bug
« Reply #48 on: November 13, 2011, 02:11:42 PM »
i know ;) but the encoding ist not avalible some files are encoded some not, it has been imported form bb

you are right, the code for opera works fine.

thx

Offline forumite

  • Full Member
  • ***
  • Posts: 408
    • The RV Forum
Re: [4825] Firefox 8 beta bug
« Reply #49 on: November 14, 2011, 04:13:17 AM »
Torsten,

Could you please explain what the .DS_Store file in that archive does? TIA.

Quote from: Tomcraft
Can you please try my patch?

Offline reschke

  • Semi-Newbie
  • *
  • Posts: 24
Re: [4825] Firefox 8 beta bug
« Reply #50 on: November 14, 2011, 04:17:14 AM »
Torsten,

Could you please explain what the .DS_Store file in that archive does? TIA.

Quote from: Tomcraft
Can you please try my patch?

https://secure.wikimedia.org/wikipedia/en/wiki/.DS_Store [nofollow]

Offline forumite

  • Full Member
  • ***
  • Posts: 408
    • The RV Forum
Re: [4825] Firefox 8 beta bug
« Reply #51 on: November 14, 2011, 05:05:50 AM »
Thanks. I didn't understand why it would be included in a patch.

Offline reschke

  • Semi-Newbie
  • *
  • Posts: 24
Re: [4825] Firefox 8 beta bug
« Reply #52 on: November 14, 2011, 05:12:52 AM »
Thanks. I didn't understand why it would be included in a patch.

It's just one of these MacOS annoyances...

Offline Darknico

  • Language Moderator
  • SMF Hero
  • *
  • Posts: 1,723
  • Gender: Male
  • Italian Moderator
    • Darknico on GitHub
    • Darknico.com
Re: [4825] Firefox 8 beta bug
« Reply #53 on: November 14, 2011, 06:26:49 AM »
hi,

i tried the fix suggested here:
http://dev.simplemachines.org/mantis/view.php?id=4825

but than i get problmes with the images(jpg)

can anybody confirm this?

best

This fix work correctly or is in test?
Italian SMF - Supporto Italiano per la board SMF - Ci trovate tutti li!! :)





Offline forumite

  • Full Member
  • ***
  • Posts: 408
    • The RV Forum
Re: [4825] Firefox 8 beta bug
« Reply #54 on: November 14, 2011, 10:57:30 AM »
Quote from: reschke
It's just one of these MacOS annoyances...

Ah OK. BTW your patch worked fine - thanks. However, because I didn't know what that file was, I merely copied/pasted your code in a text editor rather than using the Package Manager.

Offline tfs

  • Full Member
  • ***
  • Posts: 443
  • Gender: Male
Re: [4825] Firefox 8 beta bug
« Reply #55 on: November 14, 2011, 01:00:29 PM »
Can you please try my patch?

Regards, Torsten

It works for files that don't contain spaces in the filename, but is still broken for files with a space in the name.

For instance My_File.txt works

My File.txt downloads as "My"
A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.

Offline Spuds

  • SMF Hero
  • ******
  • Posts: 1,798
  • Gender: Male
Re: [4825] Firefox 8 beta bug
« Reply #56 on: November 14, 2011, 01:43:41 PM »
try

Code: [Select]
if ($context['browser']['is_firefox'])
header('Content-Disposition: ' . $disposition . '; filename*=UTF-8\'\'' . rawurlencode(preg_replace('~&#(\d{3,8});~e', '$fixchar(\'$1\')', $utf8name)));
« Last Edit: November 14, 2011, 06:40:27 PM by Spuds »

Offline Tomcraft

  • Jr. Member
  • **
  • Posts: 135
Re: [4825] Firefox 8 beta bug
« Reply #57 on: November 14, 2011, 01:59:05 PM »
Seems to work fine! I modified the patch with the new code.

Regards, Torsten

Offline reschke

  • Semi-Newbie
  • *
  • Posts: 24
Re: [4825] Firefox 8 beta bug
« Reply #58 on: November 14, 2011, 02:02:02 PM »
Seems to work fine! I modified the patch with the new code.

Regards, Torsten

It's good if this fixes the current and urgent issue. But please, going forward, consider removing as much special-casing as possible, thus send the same header to all of Chrome/Opera/Konqueror/FF and IE>=9.

Offline tfs

  • Full Member
  • ***
  • Posts: 443
  • Gender: Male
Re: [4825] Firefox 8 beta bug
« Reply #59 on: November 14, 2011, 02:25:15 PM »
Seems to work fine! I modified the patch with the new code.

Regards, Torsten

Now it wants to name the download "My+File.txt" instead of "My File.txt"
A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.