Improved Attachment Error Handling

[Kays]

Link to Mod

This mod changes the method used when there is an error in uploading an attachment. Currently, when there is an error, the procedure is stopped and you are redirected back to the post page to correct the problem. With the mod installed, any attachment errors are now all displayed on a separate page after all files have been uploaded and the post is created. Any files with an error are deleted from the server and not added to the database.

[Bancherd]

Thank you! 

[samurai-lupin]

Hello, this looks like a great mod! Could you please also do a version for SMF 1.1 ? Thank you

[samurai-lupin]

Helllo Kays, I really hope you woll consider doing a SMF 1.1 Version of this great mod. I have been looking for such a mod for a long time. Thanks!

[Kays]

Sorry, but I don't intend to backport it to SMF 1.x.

And, you're welcome Bancherd.

[samurai-lupin]

Oh! It would be really great to have this mod available for SMF 1.1 ... maybe you could change your mind please?

[Kays]

Sorry, but it's a bit of a massive mod with the changes made and I'm just not into backporting it.

Why don't you consider upgrading to 2.0 instead.

[samurai-lupin]

Sorry, but it's a bit of a massive mod with the changes made and I'm just not into backporting it.

Why don't you consider upgrading to 2.0 instead.

Because I have a highly customized board.

[GL700Wing]

This mod is a great idea but it contains two minor bugs that generate LOTS of messages in the error log every time there is a problem with uploading an attachment (see Unable to load language file...)

Attached is a mod file containing the fixes.

[littlenicki]

Hello GL700Wing, would your dare doing a SMF 1.1 compatible version of this mod please? Would be great! Thank you!

[Kays]

HI GL700Wing, thanks for that.

However, rather than posting a revised mod. Could you please post the changes made.

Thanks.

[FrizzleFried]

HI GL700Wing, thanks for that.

However, rather than posting a revised mod. Could you please post the changes made.

Thanks.

Agreed... I'd love to see the changes made!

Thanks!

[GL700Wing]

HI GL700Wing, thanks for that.
However, rather than posting a revised mod. Could you please post the changes made.

You're welcome - and sure!

Both errors/fixes are in ./Sources/Post.php

Find

Code Select Expand

if (!empty($attachmentOptions['errors']))
{
if (!isset($txt['file_too_big']))
loadLanguage('errors');

Replace with

Code Select Expand

if (!empty($attachmentOptions['errors']))
{
if (!isset($txt['file_too_big']))
loadLanguage('Errors');

Find

Code Select Expand

loadTemplate('Errors');
$context['sub_template'] = 'attachment_errors';
checkSubmitOnce();

Replace with

Code Select Expand

loadTemplate('Errors');
$context['sub_template'] = 'attachment_errors';
checkSubmitOnce('free');

[GL700Wing]

Hello GL700Wing, would your dare doing a SMF 1.1 compatible version of this mod please? Would be great! Thank you!

I don't have the skills for this - you'll have to ask the mod owner.

[Kays]

The file on the mod site has been updated and as well as the version number.

Again, thanks GL700Wing.

[littlenicki]

Hello Kay, how about a SMF 1.1 compatible version please? Thank you!

[Kays]

Sorry, but it's a bit of a massive mod with the changes made and I'm just not into backporting it.

Why don't you consider upgrading to 2.0 instead.

[TomW]

Very nice, thanks for making this mod, Kays.  This really should be in the core.

[Kays]

Thanks Tom, it has been included in 2.1 already.