News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

Ohara YouTube Embed

Started by Suki, December 21, 2011, 03:04:59 PM

Previous topic - Next topic

Cola-Coca

Hi,

I have a problem with these mod, precisely with youtube. When I put the youtube link between youtube bbc I have a problem if youtube link has "s", example: https but if there is no "s" then everything works normally. Please help me!
I LOVE SMF

Suki

Use version 1.2, it has support for https
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Cola-Coca

Quote from: Suki on August 25, 2014, 10:29:53 AM
Use version 1.2, it has support for https

I just use that version and I have that in problem.
I LOVE SMF

Suki

Make sure that the OharaYTEmbed.php file was indeed replaced with the one from version 1.2.

Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Cola-Coca

Quote from: Suki on August 25, 2014, 11:03:35 AM
Make sure that the OharaYTEmbed.php file was indeed replaced with the one from version 1.2.

I have never installed this mod, this is my first time. When youtube link has "https" I get this message:

#Invalid YouTube Link#
I LOVE SMF

Suki

Then it has nothing to do with it having https it means the url you're trying to post is marked as invalid but not necessarily because it has https.

Post the complete url you're trying to use.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Cola-Coca

Quote from: Suki on August 25, 2014, 11:16:19 AM
Then it has nothing to do with it having https it means the url you're trying to post is marked as invalid but not necessarily because it has https.

Post the complete url you're trying to use.

This is just one example:
https://www.youtube.com/watch?v=nnqBJnYGObU

Link is normal but has "https" and therefore I see a message:
#Invalid YouTube Link#
If I delete "s" if it stays just like this "https:" everything is OK.
I LOVE SMF

Suki

It parses just fine on my site and my test sites, again, you need to make sure you're indeed using version 1.2.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Cola-Coca

Quote from: Suki on August 25, 2014, 11:30:33 AM
It parses just fine on my site and my test sites, again, you need to make sure you're indeed using version 1.2.

This package I installed (see attac.):
I LOVE SMF

Suki

That doesn't make any sense.  1.2 supports https, the seconde regex won't even care for http or https.
I still believe you're trying to use some weird youtube url but unless you post the exact url here, there isn't anything I cna do.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

-Captain Ghost-

Hello,

First of all thanks for great mod.No problem with it's functionality.
But one request that can you please do something for making posted youtube responsive

Thanks

Suki

Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Suki

Ok, I implemented it, just keep in mind that it needs to have a full responsive theme, if you're theme is based on the default theme, this will not work properly.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

-Captain Ghost-

Quote from: Suki on August 27, 2014, 02:21:49 PM
Ok, I implemented it, just keep in mind that it needs to have a full responsive theme, if you're theme is based on the default theme, this will not work properly.
No problem as there exist a  full responsive theme.

Thanks

Suki

Actually, having this creates a lot of issues, specially when viewing a topic on a really large screen.  This bit of css matches the whole size of the screen, meaning that you will end up with a video as large as the actual screen, that looks pretty weird on desktops...  I know it shouldn't be an issue on smaller screens but for desktop ones it really feels rather weird having a huge video screen.

Using css @media will sove this but then again I no longer trust $context['html_headers'] since mod authors use it wrongly so this will be implemented only on the version compatible with SMF 2.1.  Will post simple instructions for people who still want to have this.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

akbora

#235
Your mod new version however centered videos at all topics other vbgamer's mod videos. How can we correct?
SMF 2.0.13
Default Theme
Utf8 Turkish
---------------

Suki

Don't really understand what you're asking, sorry.  If you want to remove the centering, then find all instances if this code:


<div style="margin:auto; text-align:center;">


and replace them with this:

<div>


On your Sources/OharaYTEmbed.php file.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

akbora

Sorry for my bad english.

Let me explain:

When your mod I installed other all videos  centered and set your width height measure. For example my vbgmaer's mod videos measure 550x410 this setting converts to your measure.
SMF 2.0.13
Default Theme
Utf8 Turkish
---------------

Suki

The css bits and the width and height are specifically hardcoded into the iframe to avoid this kind of thing.

Perhaps theres an overlap of this mod and another video embed mod, in that case there isn't much I can do to avoid the overlapping as I have no idea how other mods work.

I suggest you not to use 2 different mods for the same purpose, if the other mod alreadyhas support for youtube and vimeo then you don't have to use this one.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Aaron10

Hi any updates on the vimeo URL? Thanks

Advertisement: