News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

Ohara YouTube Embed

Started by Suki, December 21, 2011, 03:04:59 PM

Previous topic - Next topic

jsx

Quote from: Steve on May 16, 2017, 09:02:56 AM
What's the point of making two mods do the same things?

These two modification are interesting but each of them is lacking these functions which I listed. I could use the one or this modification, choose some of them, but unfortunately each of them is lacking what I expect.

@Gluz

Thanks for information.

waltari

Hello, first of i would like to thank you for this great mod. Installed it recently and encoutered a weird graphical glitch in Google Chrome, iam attaching screenshots to demostrate it. Its basically this, if i put a Youtube link in the post all is fine, but when i click the play button, weird lines appear all across the active containers (category and the post itself), header, footer and menu stays untouched. again this is a bug present ONLY in Google Chrome.




Suki

Do you have a link to a topic where this happens?
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

waltari

Quote from: Suki on July 18, 2017, 11:31:50 AM
Do you have a link to a topic where this happens?

hxxp:forum.capsuleer.cz/index.php?topic=10.0 [nonactive]

Ninja ZX-10RR

You may want to update your Chrome or something, it's fine here.
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.

♥ Jess ♥

STOP EDITING MY PROFILE

waltari

Quote from: Ninja ZX-10RR on July 27, 2017, 10:50:24 PM
You may want to update your Chrome or something, it's fine here.

mine is 59.0.3071.115 64bit which seems to be latest release, same on my laptop. The "bug" is visible on both, its not present on my mobile chrome though, ill try to fiddle with my desktop chrome and its extension and try to fix this, thanks.

edit: version 60.0.3112.78 just poped up as a update, the problem persist though :(

Suki

I cannot reproduce the issue, does this happens on the default theme too?
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

jsx

@Suki

How in Ohara YouTube Embed modification set showing video from left side? In file (...)default/css/oharaEmbed.css is such a code:

.oharaEmbed {
margin-left: auto ;
margin-right: auto ;
text-align:center;
background-position: center;
background-repeat: no-repeat;
background-color: #000;
overflow: hidden;
transition: all 200ms ease-out;
cursor: pointer;
}


And into this code need to paste this code?

display: inline-block;

It's the correct solution?

And perhaps in the next version you would implement the option of setting the position video? Left, centre.

Suki

Remove this bit:

margin-left: auto;

There used to be a setting to set the position, it wasn't used at all so it was removed.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

jsx

Thanks for information but will you minded to introduce the function of setting the position of the video in the management with this modification in the panel of the admin?

Suki

Thing is, defining a UI option from the backend really isn't the way to go, specially if an user is using different themes  or decides to change themes, etc.  A far more modular approach would be to define a new css rule for each theme you have if you want to change the default behaviour.

But if enough people request it then I will add it back.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

jsx

I understand, I'm doubting that somebody will ask for it, in my opinion such a function is useful in managing this modification.

YogiBear

I have just discovered this mod. Auto-embedding? I haven't had such luxury since Aeva, A nice, simple to use, does what it says mod. Big Thankyou, Suki.   :) :)
SMF v2.1.3  Mods : Snow & Garland v1.4,  PHP  v.7.4.33

Suki

"Thank you"  ???  I'm afraid I'm unfamiliar with those words  :P

Nah, cool you like it.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

rad1701

Any idea why this is going on or how to fix it before I try to install....

Execute Code   addHooks.php   
*   2.   Execute Modification   ./Sources/Post.php   Test failed
   1.   Replace   ./Sources/Post.php   Test failed
   2.   Replace   ./Sources/Post.php   Test failed

Suki

When you click on the failed line it opens a new window indicating the modifications the mod is trying to do.

A failed test usually means some other mod has already modified the part this mod is trying to modify.

You can manually edit that file and keep on installing the mod after that. The test filaed will still appear but you already modified the file.

If you are unsure or don't know how to modify files, attach your Sources/Post.php file here.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

rad1701

Ok - looks like it's telling me this...

Code: (Find) [Select]
if ($smcFunc['htmltrim'](strip_tags(parse_bbc($_POST['message'], false), '<img>')) === '' && (!allowedTo('admin_forum') || strpos($_POST['message'], '') === false))
Code: (Replace) [Select]
if ($smcFunc['htmltrim'](strip_tags(parse_bbc($_POST['message'], false), '<img><iframe><video><div>')) === '' && (!allowedTo('admin_forum') || strpos($_POST['message'], '') === false))

Suki

If you take a closer look you will see the mod is trying to add the following tags: <iframe><video><div>

So all you have to do is adding those tags after the img tag.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Steve

Quick off-topic comment ... glad to see you're okay Suki.
DO NOT pm me for support!

Suki

Thank you and also thanks to everyone else who expressed their concerns.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Advertisement: