Author Topic: 2.02 default templates / not upgrading (Read 22079 times)

FinsandFur · « **on:** December 23, 2011, 10:41:59 AM »

I've noticed that after upgrading from 2.01 to 2.02 there's still out of date files in the default templates.
After further research, I see it's because of the PersonalMessagetemplate.php
One is being installed for the Core template but there is not one for the default Curve template.
Can we use the one packaged with Core to fix this?

Illori · « **Reply #1 on:** December 23, 2011, 10:43:36 AM »

there are no template changes in the default theme from the 2.0.1 to 2.0.1 upgrade.

FinsandFur · « **Reply #2 on:** December 23, 2011, 11:21:48 AM »

According to the file it was changed on 12-21-2011

Illori · « **Reply #3 on:** December 23, 2011, 11:23:38 AM »

according to what file?

if you look here http://custom.simplemachines.org/upgrades/index.php?action=upgrade;file=smf_patch_2.0.2.tar.gz;smf_version=2.0.1 there are NO template changes for the default theme

FinsandFur · « **Reply #4 on:** December 23, 2011, 11:32:43 AM »

Thanks Lori.
Yah, I seen the changelog before I posted, but thats actually what made me post.
The change might not be part of the actual intended upgrade, but it is being included with this release.

Illori · « **Reply #5 on:** December 23, 2011, 11:36:00 AM »

let me say it one more time THERE ARE NO CHANGES TO THE DEFAULT TEMPLATES. end of story.

FinsandFur · « **Reply #6 on:** December 23, 2011, 12:00:18 PM »

Ok, end of story.
I apologize for having a file in my downloaded zip that contains this changed file then.

Different story, can you tell me why my default PersonalMessage.template.php is out of date now that I upgraded?

Illori · « **Reply #7 on:** December 23, 2011, 12:27:02 PM »

the core theme had a problem in that file it was fixed, it should NOT affect anything else.

FinsandFur · « **Reply #8 on:** December 23, 2011, 12:45:30 PM »

(sigh) $:-\$ I think thats exactly what I said right before you got short with me.
The file isnt part of the actual upgrade but the changed file IS being included with the upgrade package.

I upgraded 9 different installs this morning, every one of them now say they have out of date default template files, because of this file. Is there a way to fix this...or are we telling people to ignore it, it doesnt effect anything?
I'm not trying to be sarcastic or difficult. Just asking what we are to do about this.

Illori · « **Reply #9 on:** December 23, 2011, 12:46:51 PM »

the default theme has NO changes in the upgrade at all, just the core theme.

FinsandFur · « **Reply #10 on:** December 24, 2011, 12:59:15 AM »

You said that three times.

So I'm going to end the story again and just assume that since the files didn't change they are suppose to be out of date.

Everyones default template files will be out of date as indicated in the admin section. We just live with it and ignore it.

I hope you have a better day tomorrow

Illori · « **Reply #11 on:** December 24, 2011, 06:50:25 AM »

in my installs none of the default themes templates are outdated, so no idea how yours could be as they get the information from the same source.

LT07 · « **Reply #12 on:** December 24, 2011, 07:01:50 AM »

This thread is hilarious, I have nothing to add I just want to be part of it

Wait yes I do, I just did a file check and I get the exact same error, don't have a cow man he spoke the truth lol

result of version check

PersonalMessage.template.php 2.0 2.0.2

Illori · « **Reply #13 on:** December 24, 2011, 07:30:31 AM »

for some reason my forum had not updated the files from sm.org, after doing so it does show the default theme has having one outdated file, BUT it is incorrect. i have asked the site team to look into fixing this.

norepli · « **Reply #14 on:** December 24, 2011, 06:21:05 PM »

Hello,

The detailed version check after upgrading is failing as follows:
PersonalMessage.template.php 2.0 2.0.2

I'm guessing that the detailed version check is looking at the "default" theme rather than the "core" theme when doing this check. I can confirm that I do have version 2.0.2 in the core theme and version 2.0 in the default theme.

FYI,

norepli

Skhilled · « **Reply #15 on:** December 25, 2011, 09:33:37 AM »

Have you all upgraded via the upgrade link in admin? If so, you can have issues with that, especially file versions and database upgrade issues where the db has not been upgrade properly.

It is always best to upload the filesvia ftp and run upgrade.php.

Illori · « **Reply #16 on:** December 25, 2011, 10:06:23 AM »

no it is not always best to upload files via ftp and run upgrade.php, this is why we have the package manager upgrades. and their are no database upgrade issues as i stated above and this is not related to the database at all.

Skhilled · « **Reply #17 on:** December 25, 2011, 12:42:54 PM »

Again, that is an old issue with smf...look it up and the countless issues with it. I've been admin and setup tons of sites and have helped many .many people upgrade. If you upgrade via the admin link (may depend on the server or permissions) you may end up with that problem. and every time you upgrade or install a mod you will possibly get that error, if the mod checks for the current db version.

This is especially true with users who have upgraded from much older versions of SMF.

Illori · « **Reply #18 on:** December 25, 2011, 02:27:43 PM »

no mod will check for the version in the database, it checks for the version in the files where it should anyway. if users run into issues with the version we will tell them when they need to upgrade and when they dont.

in this case the MESSAGE has nothing to do with the version in the database.

norepli · « **Reply #19 on:** December 26, 2011, 12:34:14 PM »

Hello Illori,

Quote from: Illori on December 24, 2011, 07:30:31 AM

for some reason my forum had not updated the files from sm.org, after doing so it does show the default theme has having one outdated file, BUT it is incorrect. i have asked the site team to look into fixing this.

Is this still on track for a fix? I'm a bit confused about the posts after your discovery.

Thank you,

norepli

News:

Author Topic: 2.02 default templates / not upgrading (Read 22079 times)