Topic: Converting poll options

[cdesseno]

I am having some troubles converting vBulletin 3.8 to SMF 2.0 with 3.7 converter. All is working fine except* from this:

Converting poll options...Wrong value type sent to the database. Integer expected. (votes).

* Changing

Code: [Select]

SELECT pollid AS id_poll, options, votes
FROM {$from_prefix}poll;to

Code: [Select]

SELECT pollid AS id_poll, options, IFNULL(votes, 0)
FROM {$from_prefix}poll;I managed to skip that bug, but obviously poll are not being imported ok.

[Oldiesmann]

What happens to the poll options after you make that change? Are they just not being imported at all?

[cdesseno]

As you can see in the image, votes are always zero. Also, another strange thing is that the first letter of label was removed in each row.

hxxp:imageshack.us/photo/my-images/3/screenshotat20120120180.png [nonactive]

[Oldiesmann]

How does vB store vote info for poll options?

We can figure out the issue with the first letter getting cut off later...

[cdesseno]

Options are stored all in the same field with this format:
Yes|||No|||May be

hxxp:imageshack.us/photo/my-images/850/screenshotat20120121160.png/ [nonactive]

[Oldiesmann]

I'm honestly not sure what the problem is with the votes.

This is the code SMF uses to get poll options and votes:

Code: [Select]

$ignore = true;
$no_add = true;
$keys = array('id_poll', 'id_choice', 'label', 'votes');

$options = explode('|||', $row['options']);
$votes = explode('|||', $row['votes']);

$id_poll = $row['id_poll'];
for ($i = 0, $n = count($options); $i < $n; $i++)
{
$rows[] = array(
'id_poll' => $id_poll,
'id_choice' => ($i + 1),
'label' => substr(addslashes($options[$i]), 1, 255),
'votes' => (is_numeric($votes[$i]) ? $votes[$i] : 0),
);
}
The only problem I see is with the label - that "1" should be a "0" instead.

SMF sets it to 0 automatically if the value isn't numeric, so the IFNULL shouldn't make any difference.

[cdesseno]

You were right with the label issue! (it is strange that nobody had noticed this bug before).
With the votes problem I think it should be solved with this:

Code: [Select]

SELECT pollid AS id_poll, options, IFNULL( votes, 0 )[b] as votes[/b]
FROM foro_poll
Is there any easy way just to run the poll's section of the converter?

[cdesseno]

Here is the diff with my working version:

Code: [Select]

< 'label' => substr(addslashes($options[$i]), 1, 255),
< 'votes' => (is_numeric($votes[$i]) ? $votes[$i] : 0),
---
> 'label' => substr(addslashes($options[$i]), 0, 255),
> 'votes' => (int) $votes[$i],


[Oldiesmann]

Did that fix the issue then?

[cdesseno]

Yes!

[Oldiesmann]

Ok. Thanks for the info. I'll let the developers know so they can get the converter updated