News:

SMF 2.1.2 has been released! Take it for a spin! Read more.

Main Menu

Voter Visibility

Started by Ray Cardillo, May 02, 2012, 12:25:01 PM

Previous topic - Next topic

FrizzleFried

Also... the top error... which I click the top error URL I get:

QuoteAn Error Has Occurred!
Either that poll doesn't exist, the poll has been locked, or you tried to vote twice.

So perhaps it's not an error exactly?

Clicking on the others take me to the CREATE A POLL screen... and when I check the logs sure enough an error pops up with my user name being I dropped in to that page.


Ray Cardillo

Quote from: FrizzleFried on May 17, 2012, 02:42:18 PM
EDIT: Oh... and there doesn't appear to be any negative impact on the users experience...nothing is "breaking" or not working from their perspective.

Oh, alright, where are you seeing this exactly (so I can look the same place you're looking)?  If you can tell me how to reproduce, then I can try for myself and see what's up.  Even if I cannot reproduce it, once you can reproduce it, I can review the code and play an educated guessing game.

If it's only happening on that other error you mentioned, perhaps I wasn't careful enough checking all the variables in the rest of that flow when the error happens... but nobody ever sees it.  Would still like to clean it up if you can document the use case while reproducing the error.

Thanks!
Author of the Voter Visibility mod customization.  Adds the ability to see (and control who sees) who voted for what.  Allows you to conduct secret ballots.  Can also be used to coordinate volunteer signups, and more.

FrizzleFried

Quote from: Ray Cardillo on May 17, 2012, 02:52:21 PM
Quote from: FrizzleFried on May 17, 2012, 02:42:18 PM
EDIT: Oh... and there doesn't appear to be any negative impact on the users experience...nothing is "breaking" or not working from their perspective.

Oh, alright, where are you seeing this exactly (so I can look the same place you're looking)?  If you can tell me how to reproduce, then I can try for myself and see what's up.  Even if I cannot reproduce it, once you can reproduce it, I can review the code and play an educated guessing game.

If it's only happening on that other error you mentioned, perhaps I wasn't careful enough checking all the variables in the rest of that flow when the error happens... but nobody ever sees it.  Would still like to clean it up if you can document the use case while reproducing the error.

Thanks!

The errors posted are from my ERROR LOG in the Admin...

When i click on one of the errors it takes me to one of my users POLLS he set up.  When I click back to the admin error log and refresh... the 8: Undefined variable: row error shows up with my user name (so the error is being thrown just looking at that screen).

dredman

I may be overlooking this, but cannot seem to find the "Voter Log" - assuming this should be somewhere in the admin area?


FrizzleFried

When enabled the voter log button appears under the poll in question at the left (standard theme).

dredman

looks like it is all theme related, how do I modify the theme?
what files do I put where?

Ray Cardillo

Quote from: dredman on May 18, 2012, 02:16:28 PM
looks like it is all theme related, how do I modify the theme?
what files do I put where?

No, but due to the way SMF words internally, there are some updates to the theme files that are required.  This mod is compatible with 2.0.2 so you can just install it using the standard Package Manager procedures.  Most people simply use Package Manager to download and install to both the Curve and Core themes since both are supported out of the box.

If you want to install this mod to any other themes, then you have to be able to do an advanced Manual Install and you are on your own at that point (that Wiki article explains why).  It's not rocket science, but it requires more knowledge of how SMF and mods work, and is a lot more work than most people are willing to commit to.

I think my comments will make more sense once you read the Wiki articles I've referenced above.  ;)
Author of the Voter Visibility mod customization.  Adds the ability to see (and control who sees) who voted for what.  Allows you to conduct secret ballots.  Can also be used to coordinate volunteer signups, and more.

Ray Cardillo

Quote from: FrizzleFried on May 17, 2012, 03:12:54 PM
The errors posted are from my ERROR LOG in the Admin...

When i click on one of the errors it takes me to one of my users POLLS he set up.  When I click back to the admin error log and refresh... the 8: Undefined variable: row error shows up with my user name (so the error is being thrown just looking at that screen).

Alright, just to make sure you know this didn't fall on deaf ears, I wanted to respond quickly.  I reviewed quickly and it looks like a small cosmetic problem causing some errors to be logged that are harmless.  Since it's not causing any serious problems I'm going to defer this for now, and I will review in more detail when I make my next round of updates.  I have a lot going on right now and I'm trying to prioritize carefully.  So when everything settles down, I'll review this along with any other misc issues that may be reported and consider any feedback or special requests as well.

Things will probably not settle down until August or September, so unless someone notices a high severity problem, I will not be making any updates for a few months.  I'm still going to try to be responsive to inquiries and be helpful, etc, but the time it takes to debug, make updates, test the package install against multiple configurations, etc, is just too much of a burden right now since it's basically just resulting in a cosmetic issue in the admin log.  :)
Author of the Voter Visibility mod customization.  Adds the ability to see (and control who sees) who voted for what.  Allows you to conduct secret ballots.  Can also be used to coordinate volunteer signups, and more.

FrizzleFried

Glad to see it's not an isolated issue with me (well,  sort of... I guess misery loves company).  Since this is now generating about 50 errors a day I may just uninstall it until the issue is addressed... I am a bit anal and can't stand a "dirty log"...

(that sounds vaguely dirty, huh?)...

Thanks for the work... and I hope to see the fix when you have time.


Ray Cardillo

Quote from: FrizzleFried on May 21, 2012, 10:12:03 PM
Glad to see it's not an isolated issue with me (well,  sort of... I guess misery loves company).  Since this is now generating about 50 errors a day I may just uninstall it until the issue is addressed... I am a bit anal and can't stand a "dirty log"...

Yikes, 50 errors a day, that sucks.  Alright, tell you what, if you can confirm that everyone loves the mod and will be upset if you remove it... then I'll honestly try to squeeze in the time to fix, test, release, an update.  I just don't want to go through all that if it's not going to matter anyways... but I would hate to loose a user due to something silly like that.  :)
Author of the Voter Visibility mod customization.  Adds the ability to see (and control who sees) who voted for what.  Allows you to conduct secret ballots.  Can also be used to coordinate volunteer signups, and more.

TheListener

QuoteI just don't want to go through all that if it's not going to matter anyways... but I would hate to loose a user due to something silly like that. 

Considering the mod has been downloaded 133 I think it may be worth doing.

Ray Cardillo

Quote from: Old Fossil on May 21, 2012, 10:50:24 PM
QuoteI just don't want to go through all that if it's not going to matter anyways... but I would hate to loose a user due to something silly like that. 
Considering the mod has been downloaded 133 I think it may be worth doing.

Oh, it's definitely getting fixed... In fact, I'm kind of embarrassed that nobody caught this before now.  Just trying to prioritize this in comparison to other activities going on right now... and I'm inclined to leave it for another month or two since it's a low severity problem.  The features all behave correctly, no actual failures, etc, just an unintended log file annoyance.  :-\
Author of the Voter Visibility mod customization.  Adds the ability to see (and control who sees) who voted for what.  Allows you to conduct secret ballots.  Can also be used to coordinate volunteer signups, and more.

TheListener

RL comes first no matter what.

Unless of course ya see me approach with a frying pan.

;)

FrizzleFried

It'll wait until you can get time to get it done... :)

Just please don't forget us and leave us hanging... as my users DO use and DO like this mod over the multi-poll mod I had running.

Thanks!

TheListener

Quote from: FrizzleFried on May 22, 2012, 12:06:45 AM
It'll wait until you can get time to get it done... :)

Just please don't forget us and leave us hanging... as my users DO use and DO like this mod over the multi-poll mod I had running.

Thanks!

Borrow my frying pan if ya want.


digger

Quote from: Ray Cardillo on May 11, 2012, 08:19:50 PM
I tried to follow the new SMF mod coding guidelines very carefully (and that mod may have also)
Why did you use hardcoded tables prefixes?
It will make errors if forum have tables prefix other then 'smf_'.

FrizzleFried

Any news on this?   I just deleted over 1500 errors from my log from this mod... and the user polls are getting more popular.

:o

Thanks!

FrizzleFried

#37
Bummer ... author has not been on since May 21st...

:(

EDIT: I got a PM from the author... when he has time he will update.  :)

Chalky

#38
Am I missing something?  Even when creating a poll, my voter visibility is set to read only and won't allow me to modify it to anything other than Only forum admins can see votes.  I want everyone to see the votes!

Ah, this seems to be when adding a poll to an existing thread!  I can set the option if I hit "New Poll" to start a new topic.  Please can anyone tell me how to add a poll to an existing topic and set the voter visibility to public?  Is this possible?

I just had to create a new poll, so I could set the VV to public, (luckily Lazarus completed the fields for me, the little star!) then merge the poll topic with the existing topic that I wanted the poll to be on.  It was a bit of a faff....

bigggan

Hi when i installed this mod, i get a few errors in the download manager, but when i installed it, it didnt add a button under the poll, though we have a multipoll feature called "Additional Polls" could you add support for this mod if this is the issue? :/ or add your own multipoll in this plugin? :/

Advertisement: