Topic: 2.0.2, useless permission title

[Robert.]

G'day So I'm back again When you disable the calendar or just don't enable it, the "select a permission" dropdown doesn't display the permissions of the calendar, but it does display "[Calendar]", which doesn't make sense when there are no permissions for it (as the calendar has been disabled). So far I've got no idea how to fix it, though. Using SMF 2.0.2, no mods installed

[NanoSector]

What "select a permission" dropdown are you talking about?

[Robert.]

When you go to the manage permissions page, you see a list of groups and below that, you'll see some other things, like remove permissions and add permissions. I mean that one

[NanoSector]

Oh, that thing. Let me seek the code for it in a minute.

[emanuele]

mmm...
ManagePermissions.php

Code: (find) [Select]

ksort($context['permissions'][$permissionType]['columns']);
}

// Check we don't leave any empty groups - and mark hidden ones as such.
foreach ($context['permissions'][$permissionType]['columns'] as $column => $groups)
foreach ($groups as $id => $group)
{
if (empty($group['permissions']))
unset($context['permissions'][$permissionType]['columns'][$column][$id]);
else
{
$foundNonHidden = false;
foreach ($group['permissions'] as $permission)
if (empty($permission['hidden']))
$foundNonHidden = true;
if (!$foundNonHidden)
$context['permissions'][$permissionType]['columns'][$column][$id]['hidden'] = true;
}
}


Code: (replace with) [Select]

ksort($context['permissions'][$permissionType]['columns']);

// Check we don't leave any empty groups - and mark hidden ones as such.
foreach ($context['permissions'][$permissionType]['columns'] as $column => $groups)
foreach ($groups as $id => $group)
{
if (empty($group['permissions']))
unset($context['permissions'][$permissionType]['columns'][$column][$id]);
else
{
$foundNonHidden = false;
foreach ($group['permissions'] as $permission)
if (empty($permission['hidden']))
$foundNonHidden = true;
if (!$foundNonHidden)
$context['permissions'][$permissionType]['columns'][$column][$id]['hidden'] = true;
}
}
}


* emanuele hopes this doesn't break anything else...

* emanuele waits a bit before apply it.

[Robert.]

Thanks for the patch. Applied and it works fine now

[emanuele]

commit b6fb1aeb92c9651e72a972ee452680604a67b026
Date:   Sun Jun 17 2012

    Removed unnecessary permissions from the select a permission dropdown - thank Dr. Deejay for the report
 

[GL700Wing]

I've noticed this is not in ManagePermissions.php in SMF 2.0.14 - it is implemented some other way/no longer necessary?

[Illori]

as stated above the fix was committed. that is why this bug is in the fixed board.