ssi_boardnews $limit slips up on linebreaks

Started by Roph, September 01, 2010, 06:58:25 PM

Previous topic - Next topic

Roph

SMF 2.0 RC3. Fairly simple to recreate, just use ssi_boardnews with a $limit param and echo the body. If the cutoff happens to fall on a line break, the HTML tags aren't closed properly. This is probably quite rare, but I was unlucky enough to have this happen twice just recently in the same output.

Firefox's source viewer helpfully points out the issue:


Gecko and Webkit based browsers deal with this ok, but (potentially, depending on your layout of course) Opera and IE will break the layout because of this problem.


Firefox picks up the error, but deals with it


Opera - Noo, my divs :(

Norv

To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

emanuele

#2
commit 585cc133906aafcb3403a004acf5451570e9ff9f
Author: emanuele
Date:   Sat Aug 18

    ssi_boardnews doesn't produce any more invalid html cutting <br>s in between


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Advertisement: