Advertisement:
GCWebhosting

Author Topic: Some updates on SMF 2.1  (Read 356954 times)

Offline AllanD

  • Sr. Member
  • ****
  • Posts: 730
  • Gender: Male
  • It's All Good
    • KnD Hosting
Re: Some updates on SMF 2.1
« Reply #340 on: May 14, 2013, 06:33:23 PM »
I replied at github, fix didn't work. Thank you though.
Check out this great sites.
KnD Hosting

Offline Matthew K.

  • SMF Super Hero
  • *******
  • Posts: 12,430
  • Gender: Male
    • matthew.kerle on Facebook
    • @matthew_kerle on Twitter
Re: Some updates on SMF 2.1
« Reply #341 on: May 14, 2013, 06:47:49 PM »
When I tested it...$_POST['reg_mode'] was most definitely available. Maybe it was not tested thoroughly enough, but it also could possibly be something else...

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,252
    • StoryBB/StoryBB on GitHub
Re: Some updates on SMF 2.1
« Reply #342 on: May 14, 2013, 06:50:37 PM »
Available to what, exactly?

The original code makes use of the value of $_POST['reg_mode'] during ForumSettings(), which means it's shown to the user at the previous stage. Only trouble is, ForumSettings() is only for populating Settings.php and the database doesn't yet contain the settings table, so putting in the insert at that point is guaranteed to fail.

The update moves the population step into DatabasePopulation() but still relies on $_POST['reg_mode']. Since that's requested from the user two steps back and originally applied in ForumSettings(), there is no reason for ForumSettings() to push it back to the form for submission through into DatabasePopulation().

Edit: I suppose one of these days I'll actually try to install SMF 2.1 again, haven't installed it in months (and didn't for this, after seeing two people report it failing, I just looked at it)
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Matthew K.

  • SMF Super Hero
  • *******
  • Posts: 12,430
  • Gender: Male
    • matthew.kerle on Facebook
    • @matthew_kerle on Twitter
Re: Some updates on SMF 2.1
« Reply #343 on: May 14, 2013, 06:52:52 PM »
You should definitely take a peak at it after that registration thing is fixed then.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 58,337
  • Gender: Male
    • Kindred-999 on GitHub
Re: Some updates on SMF 2.1
« Reply #344 on: May 14, 2013, 07:49:51 PM »
Where can we get support if needed.

Please do note, there is no actual "support" for alpha versions.
If there is a bug, we will attempt to fix it - but, at this point, the only folks who should really be running the software are folks who are knowledgeable about coding, etc and ones who can help track down the details behind reported issues.
(which is not to say that you or anyone else is not such a person... but there are people who will install alphas and betas and expect full production level support)
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline AllanD

  • Sr. Member
  • ****
  • Posts: 730
  • Gender: Male
  • It's All Good
    • KnD Hosting
Re: Some updates on SMF 2.1
« Reply #345 on: May 14, 2013, 08:19:38 PM »
Where can we get support if needed.

Please do note, there is no actual "support" for alpha versions.
If there is a bug, we will attempt to fix it - but, at this point, the only folks who should really be running the software are folks who are knowledgeable about coding, etc and ones who can help track down the details behind reported issues.
(which is not to say that you or anyone else is not such a person... but there are people who will install alphas and betas and expect full production level support)


Ok so then the common user shouldn't have any say. Sorry I don't know much about mysql. Talking about turning away interested members.
Check out this great sites.
KnD Hosting

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,252
    • StoryBB/StoryBB on GitHub
Re: Some updates on SMF 2.1
« Reply #346 on: May 14, 2013, 08:22:25 PM »
You should definitely take a peak at it after that registration thing is fixed then.

I should definitely climb a mountain after that registration thing is fixed? Unless you mean 'peek' which is a different thing entirely.

I just find it all a bit sad that people would report it elsewhere in the hopes I'd be able to give them a better answer than they would if they had posted here.


@Allan: What Kindred is trying to say is that alpha grade software is still under active development and that things can and will change, to the point where only competent developers will be able to investigate.

Take this very bug. There are, what, half a dozen reports of it now? And yet there are only 3 people who might actually be able to fix it, at least that are actively involved in the discussion.

This is the thing I raised with my comment on the Wedge FB page and why I don't really want to give out alphas to people who don't understand what 'alpha' really means.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline AllanD

  • Sr. Member
  • ****
  • Posts: 730
  • Gender: Male
  • It's All Good
    • KnD Hosting
Re: Some updates on SMF 2.1
« Reply #347 on: May 14, 2013, 08:29:00 PM »
 understand about that, I wanted to play around with making a themes on it.
Check out this great sites.
KnD Hosting

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,252
    • StoryBB/StoryBB on GitHub
Re: Some updates on SMF 2.1
« Reply #348 on: May 14, 2013, 08:33:54 PM »
Making a theme for a moving target is just that: a moving target. Which means the only people who can really help you are the people writing the code themselves.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 58,337
  • Gender: Male
    • Kindred-999 on GitHub
Re: Some updates on SMF 2.1
« Reply #349 on: May 14, 2013, 09:08:42 PM »
I am not turning away anyone...and, of curse, "common users" can have input.

However,
Alpha and beta software is in a state of flux.
As arantor said there is a certain level of debugging that s expected from people who are running test versions...   And it would be useless to try and develop a theme for 2.1 yet, since, in alpha it is possible to completely drop or rewrite anything.

As much as I like the availability of the code on github, it does present a problem because general users will nstalled it and expect support. However, there is no support for alpha and only limited for beta software.
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline emanuele

  • SMF Super Hero
  • *******
  • Posts: 14,156
  • Gender: Male
  • THERE'S JUST ME
Re: Some updates on SMF 2.1
« Reply #350 on: May 15, 2013, 05:52:26 AM »
The only problem I see with that is that I'm not sure $_POST['reg_mode'] is still available at that precise moment in time; if it's set for ForumSettings() to read it, IIRC it won't be passed through for DatabasePopulation() to handle it.
Yep, it's still there (it's the same mechanism used for $enableCompressedOutput and $databaseSession_enable) because DatabasePopulation is run in the loop just after ForumSettings has returned true.

I should definitely climb a mountain after that registration thing is fixed? Unless you mean 'peek' which is a different thing entirely.
Mountains in summer are nice! :P (Especially if there are trees around with some shadow O:))

Take this very bug. There are, what, half a dozen reports of it now? And yet there are only 3 people who might actually be able to fix it, at least that are actively involved in the discussion.
I agree that's sad that people report issues on other forums. I don't know why they do, but for those involved here (or at least for me) becomes a bit more tricky to even know they have been reported (anyway yes, I was aware of the report at Wedge, and I didn't answer because I was doing other things...and also because I felt a bit uncomfortable doing debug on SMF on the board of another software, then when I "woke up" (yeah, difficult morning and early afternoon yesterday) there was the issue open, the time to have a look and test it and I sent the PR with the fix).

A topic in bug reports or a message in this same topic would have been quite nice to have...I usually don't kill people reporting bugs... usually. O:) (maybe someone else does, in that case feel free to shoot him/her :P)


Take a peek at what I'm doing! ;D



Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Offline emanuele

  • SMF Super Hero
  • *******
  • Posts: 14,156
  • Gender: Male
  • THERE'S JUST ME
Re: Some updates on SMF 2.1
« Reply #351 on: May 15, 2013, 06:09:18 AM »
However,
Alpha and beta software is in a state of flux.
As arantor said there is a certain level of debugging that s expected from people who are running test versions...   And it would be useless to try and develop a theme for 2.1 yet, since, in alpha it is possible to completely drop or rewrite anything.
Well, I always considered 2.1 quite "stable" theme-side because we really didn't change much of the background (of course in the early steps we changed few things, but nothing that would require a total rebuild of the theme, rewrite of certain things, but not completely. Of course it may become a bit tricky to keep track of changes if you are not using a local repo...that's true. And of course it all depends on what you want to obtain from your theme, if you just want to tweak the css it's one thing, if you want to redo it almost entirely it's another and the two options require different approaches).

As much as I like the availability of the code on github, it does present a problem because general users will nstalled it and expect support. However, there is no support for alpha and only limited for beta software.
What you are missing here is that we are supporting our product.
We are not giving support to the users of our product.
In that phase it's SMF that needs support and feedback from people installing it and using it, this is support that *we* need.

Building a new theme may let AllanD discover a bug somewhere, or may allow him to suggest some trick to the template that would improve the theming experience, or whatever.
Have users that create mods for devel versions provides feedback to improve some aspect (we introduced tons of hooks, but do we really know if they are *really* useful? No.). Of course is a possible waste of time, but that's part of the game (all the time we "developers" are putting into our code is potentially a huge waste of time, but we nevertheless continue to do it).

We have warned people (at least I think), so as long as they are aware of that, play with a development version (and anyway the current 2.1 doesn't receive many commits) is fine. And if they don't know or don't understand that, they will learn at some point.


Take a peek at what I'm doing! ;D



Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Offline ziycon

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 2,692
  • Gender: Male
Re: Some updates on SMF 2.1
« Reply #352 on: May 15, 2013, 06:18:47 AM »
As much as I like the availability of the code on github, it does present a problem because general users will nstalled it and expect support. However, there is no support for alpha and only limited for beta software.
Make a point of saying that, update the git repos so that the installer has a very prominent message saying that it wont be supported as it's an alpha or put a banner at the top of the installer/installed forum to this regard for anything on git.

Offline AllanD

  • Sr. Member
  • ****
  • Posts: 730
  • Gender: Male
  • It's All Good
    • KnD Hosting
Re: Some updates on SMF 2.1
« Reply #353 on: May 15, 2013, 07:23:21 AM »
Thanks emanuele, but I got it working last night the was an ) that was left out.
Check out this great sites.
KnD Hosting

Offline emanuele

  • SMF Super Hero
  • *******
  • Posts: 14,156
  • Gender: Male
  • THERE'S JUST ME
Re: Some updates on SMF 2.1
« Reply #354 on: May 15, 2013, 07:48:21 AM »
Where exactly?
The missing parenthesis is something broken in the code?


Take a peek at what I'm doing! ;D



Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Offline AllanD

  • Sr. Member
  • ****
  • Posts: 730
  • Gender: Male
  • It's All Good
    • KnD Hosting
Re: Some updates on SMF 2.1
« Reply #355 on: May 15, 2013, 12:37:27 PM »
It was on line 1750 on the install_2-1_mysql.sql. Could have been something I did when editing.
Check out this great sites.
KnD Hosting

Offline emanuele

  • SMF Super Hero
  • *******
  • Posts: 14,156
  • Gender: Male
  • THERE'S JUST ME
Re: Some updates on SMF 2.1
« Reply #356 on: May 15, 2013, 04:50:55 PM »
Okay, good, thanks. :)

Just to be sure the Allan at github it's you, right?


Take a peek at what I'm doing! ;D



Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Offline AllanD

  • Sr. Member
  • ****
  • Posts: 730
  • Gender: Male
  • It's All Good
    • KnD Hosting
Re: Some updates on SMF 2.1
« Reply #357 on: May 15, 2013, 05:40:11 PM »
Yeppers, one in the same.
Check out this great sites.
KnD Hosting

Offline feline

  • SMF Hero
  • ******
  • Posts: 1,638
  • Gender: Female
Re: Some updates on SMF 2.1
« Reply #358 on: June 11, 2013, 10:59:36 AM »
I think there is a bug in the Who.php if a action=credits request ...
Fix for this:
in Who.php find:
Code: [Select]
function Credits($in_admin = false)
{
global $context, $smcFunc, $modSettings, $forum_copyright, $forum_version, $boardurl, $txt, $user_info;

// Don't blink. Don't even blink. Blink and you're dead.
loadLanguage('Who');

$context[$context['admin_menu_name']]['tab_data'] = array(
'title' => $txt['support_credits_title'],
'help' => '',
'description' => '',
);

replace with:
Code: [Select]
function Credits($in_admin = false)
{
global $context, $smcFunc, $modSettings, $forum_copyright, $forum_version, $boardurl, $txt, $user_info;

// Don't blink. Don't even blink. Blink and you're dead.
loadLanguage('Who');

if ($in_admin)
$context[$context['admin_menu_name']]['tab_data'] = array(
'title' => $txt['support_credits_title'],
'help' => '',
'description' => '',
);

Then the error is gone  ;)

Offline emanuele

  • SMF Super Hero
  • *******
  • Posts: 14,156
  • Gender: Male
  • THERE'S JUST ME
Re: Some updates on SMF 2.1
« Reply #359 on: June 11, 2013, 11:06:10 AM »
mmmm...arg...yes I thought I fixed that some time ago, but apparently either I didn't fix it or I fixed and not pushed it...or fixed somewhere else. :P


Take a peek at what I'm doing! ;D



Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.